[v2] json-c: Disable icecc to avoid implicit-fallthrough warning as error

Submitted by Andrii Bordunov via Openembedded-core on June 7, 2019, 1:21 a.m. | Patch ID: 162029

Details

Message ID 20190607012157.16757-1-douglas.royds@taitradio.com
State New
Headers show

Commit Message

Andrii Bordunov via Openembedded-core June 7, 2019, 1:21 a.m.
icecc preprocesses source files locally before shipping them off to be compiled
on remote hosts. This preprocessing removes comments, including /* fallthrough */
comments in switch statements that normally prevent the implicit-fallthrough
warning.

Rather than turning off -Werror by patching configure.ac, it is simpler to
disable icecc completely for json-c. There are very few source files to compile,
so the compilation is quick even without icecc.

See https://github.com/icecc/icecream/issues/419

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
---
 meta/classes/icecc.bbclass | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
index edb0e10434..c0f21bdbfd 100644
--- a/meta/classes/icecc.bbclass
+++ b/meta/classes/icecc.bbclass
@@ -76,6 +76,7 @@  ICECC_ENV_DEBUG ??= ""
 # target-sdk-provides-dummy - ${HOST_PREFIX} is empty which triggers the "NULL
 #                             prefix" error.
 ICECC_SYSTEM_PACKAGE_BL += "\
+    json-c \
     libgcc-initial \
     target-sdk-provides-dummy \
     "

Comments

Ross Burton June 7, 2019, 11:20 a.m.
FWIW I still believe that just patching out -Werror is the correct fix
here.  To be honest I'm really close to writing a QA check that
-Werror and friends isn't being used at all...

Filed https://github.com/json-c/json-c/issues/489 in the hope that
upstream will handle it.

Ross

On Fri, 7 Jun 2019 at 02:22, Douglas Royds via Openembedded-core
<openembedded-core@lists.openembedded.org> wrote:
>
> icecc preprocesses source files locally before shipping them off to be compiled
> on remote hosts. This preprocessing removes comments, including /* fallthrough */
> comments in switch statements that normally prevent the implicit-fallthrough
> warning.
>
> Rather than turning off -Werror by patching configure.ac, it is simpler to
> disable icecc completely for json-c. There are very few source files to compile,
> so the compilation is quick even without icecc.
>
> See https://github.com/icecc/icecream/issues/419
>
> Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> ---
>  meta/classes/icecc.bbclass | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
> index edb0e10434..c0f21bdbfd 100644
> --- a/meta/classes/icecc.bbclass
> +++ b/meta/classes/icecc.bbclass
> @@ -76,6 +76,7 @@ ICECC_ENV_DEBUG ??= ""
>  # target-sdk-provides-dummy - ${HOST_PREFIX} is empty which triggers the "NULL
>  #                             prefix" error.
>  ICECC_SYSTEM_PACKAGE_BL += "\
> +    json-c \
>      libgcc-initial \
>      target-sdk-provides-dummy \
>      "
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Ross Burton June 9, 2019, 7:56 p.m.
FWIW, this just landed in json-c master:

https://github.com/json-c/json-c/commit/07ea04e65193c3e5c902c5b79421d5fa48ff67c7

"build: add option --disable-werror to configure"

Ross

On Fri, 7 Jun 2019 at 12:20, Burton, Ross <ross.burton@intel.com> wrote:
>
> FWIW I still believe that just patching out -Werror is the correct fix
> here.  To be honest I'm really close to writing a QA check that
> -Werror and friends isn't being used at all...
>
> Filed https://github.com/json-c/json-c/issues/489 in the hope that
> upstream will handle it.
>
> Ross
>
> On Fri, 7 Jun 2019 at 02:22, Douglas Royds via Openembedded-core
> <openembedded-core@lists.openembedded.org> wrote:
> >
> > icecc preprocesses source files locally before shipping them off to be compiled
> > on remote hosts. This preprocessing removes comments, including /* fallthrough */
> > comments in switch statements that normally prevent the implicit-fallthrough
> > warning.
> >
> > Rather than turning off -Werror by patching configure.ac, it is simpler to
> > disable icecc completely for json-c. There are very few source files to compile,
> > so the compilation is quick even without icecc.
> >
> > See https://github.com/icecc/icecream/issues/419
> >
> > Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> > ---
> >  meta/classes/icecc.bbclass | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/classes/icecc.bbclass b/meta/classes/icecc.bbclass
> > index edb0e10434..c0f21bdbfd 100644
> > --- a/meta/classes/icecc.bbclass
> > +++ b/meta/classes/icecc.bbclass
> > @@ -76,6 +76,7 @@ ICECC_ENV_DEBUG ??= ""
> >  # target-sdk-provides-dummy - ${HOST_PREFIX} is empty which triggers the "NULL
> >  #                             prefix" error.
> >  ICECC_SYSTEM_PACKAGE_BL += "\
> > +    json-c \
> >      libgcc-initial \
> >      target-sdk-provides-dummy \
> >      "
> > --
> > 2.17.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
Andrii Bordunov via Openembedded-core June 11, 2019, 1:59 a.m.
Please disregard this one, I've sent a recipe update to pick up the new 
--disable-werror configure option.