[v2] json-c: Make implicit-fallthrough only a warning for compilation under icecc

Submitted by Andrii Bordunov via Openembedded-core on June 6, 2019, 1:13 a.m. | Patch ID: 161991

Details

Message ID 20190606011321.23507-1-douglas.royds@taitradio.com
State New
Headers show

Commit Message

Andrii Bordunov via Openembedded-core June 6, 2019, 1:13 a.m.
icecc preprocesses source files locally before shipping them off to be compiled
on remote hosts. This preprocessing removes comments, including /* fallthrough */
comments in switch statements that normally prevent the implicit-fallthrough
warning. Rather than turning off -Werror completely, just reduce
implicit-fallthrough to a warning only.

In the -native case, we might be building on an earlier gcc, eg. gcc 5.4
under Ubuntu 16.04, so we do disable -Werror completely.

See https://github.com/icecc/icecream/issues/419

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
---
 meta/recipes-devtools/json-c/json-c_0.13.1.bb | 3 +++
 1 file changed, 3 insertions(+)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-devtools/json-c/json-c_0.13.1.bb b/meta/recipes-devtools/json-c/json-c_0.13.1.bb
index 5b10e68297..87a87aec44 100644
--- a/meta/recipes-devtools/json-c/json-c_0.13.1.bb
+++ b/meta/recipes-devtools/json-c/json-c_0.13.1.bb
@@ -22,6 +22,9 @@  inherit autotools
 
 EXTRA_OECONF = "--enable-rdrand"
 
+TARGET_CPPFLAGS =+ "-Wno-error=implicit-fallthrough"
+BUILD_CPPFLAGS =+ "-Wno-error"
+
 do_configure_prepend() {
     # Clean up autoconf cruft that should not be in the tarball
     rm -f ${S}/config.status

Comments

Andrii Bordunov via Openembedded-core June 6, 2019, 2:09 a.m.
Please disregard this one, I have submitted a newer patch under a new 
subject-line:

    json-c: Disable icecc to avoid implicit-fallthrough warning as error


On 6/06/19 1:13 PM, Douglas Royds wrote:

> icecc preprocesses source files locally before shipping them off to be compiled
> on remote hosts. This preprocessing removes comments, including /* fallthrough */
> comments in switch statements that normally prevent the implicit-fallthrough
> warning. Rather than turning off -Werror completely, just reduce
> implicit-fallthrough to a warning only.
>
> In the -native case, we might be building on an earlier gcc, eg. gcc 5.4
> under Ubuntu 16.04, so we do disable -Werror completely.
>
> See https://github.com/icecc/icecream/issues/419
>
> Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> ---
>   meta/recipes-devtools/json-c/json-c_0.13.1.bb | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-devtools/json-c/json-c_0.13.1.bb b/meta/recipes-devtools/json-c/json-c_0.13.1.bb
> index 5b10e68297..87a87aec44 100644
> --- a/meta/recipes-devtools/json-c/json-c_0.13.1.bb
> +++ b/meta/recipes-devtools/json-c/json-c_0.13.1.bb
> @@ -22,6 +22,9 @@ inherit autotools
>   
>   EXTRA_OECONF = "--enable-rdrand"
>   
> +TARGET_CPPFLAGS =+ "-Wno-error=implicit-fallthrough"
> +BUILD_CPPFLAGS =+ "-Wno-error"
> +
>   do_configure_prepend() {
>       # Clean up autoconf cruft that should not be in the tarball
>       rm -f ${S}/config.status