[meta-oe,v2] rocksdb: Turn off Werror to fix build failure due to GCC9 checks

Submitted by zhe.he@windriver.com on June 3, 2019, 3:15 a.m. | Patch ID: 161905

Details

Message ID 1559531758-126270-1-git-send-email-zhe.he@windriver.com
State Superseded
Headers show

Commit Message

zhe.he@windriver.com June 3, 2019, 3:15 a.m.
From: He Zhe <zhe.he@windriver.com>

GCC9 introduce stricter checks, deprecated-copy and pessimizing-move, while
rocksdb uses -Werror and causes the following build error.

db/version_edit.h:178:33: error: implicitly-declared 'constexpr rocksdb::FileDescriptor::FileDescriptor(const rocksdb::FileDescriptor&)' is deprecated [-Werror=deprecated-copy]

utilities/persistent_cache/persistent_cache_util.h:51:23: error: moving a local object in a return statement prevents copy elision [-Werror=pessimizing-move]

Signed-off-by: He Zhe <zhe.he@windriver.com>
---
v2: As suggested, turn off Werror instead of the two specifc check options

 meta-oe/recipes-dbs/rocksdb/rocksdb_git.bb | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/meta-oe/recipes-dbs/rocksdb/rocksdb_git.bb b/meta-oe/recipes-dbs/rocksdb/rocksdb_git.bb
index 8d84619..5ce4c74 100644
--- a/meta-oe/recipes-dbs/rocksdb/rocksdb_git.bb
+++ b/meta-oe/recipes-dbs/rocksdb/rocksdb_git.bb
@@ -30,6 +30,7 @@  EXTRA_OECMAKE = "\
     -DPORTABLE=ON \
     -DWITH_TESTS=OFF \
     -DWITH_TOOLS=OFF \
+    -DFAIL_ON_WARNINGS=OFF \
 "
 
 do_install_append() {

Comments

Mark Asselstine June 11, 2019, 7:53 p.m.
On Sun, Jun 2, 2019 at 11:16 PM <zhe.he@windriver.com> wrote:
>
> From: He Zhe <zhe.he@windriver.com>
>
> GCC9 introduce stricter checks, deprecated-copy and pessimizing-move, while
> rocksdb uses -Werror and causes the following build error.
>
> db/version_edit.h:178:33: error: implicitly-declared 'constexpr rocksdb::FileDescriptor::FileDescriptor(const rocksdb::FileDescriptor&)' is deprecated [-Werror=deprecated-copy]
>
> utilities/persistent_cache/persistent_cache_util.h:51:23: error: moving a local object in a return statement prevents copy elision [-Werror=pessimizing-move]
>
> Signed-off-by: He Zhe <zhe.he@windriver.com>
> ---
> v2: As suggested, turn off Werror instead of the two specifc check options

There is now a proposed fix upstream and there is also an uprev in progress by
Pascal (RE: rocksdb: 5.18.3 -> 6.0.2). I have asked as part of that
the potential fix
be included along with the uprev.

Mark

>
>  meta-oe/recipes-dbs/rocksdb/rocksdb_git.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-dbs/rocksdb/rocksdb_git.bb b/meta-oe/recipes-dbs/rocksdb/rocksdb_git.bb
> index 8d84619..5ce4c74 100644
> --- a/meta-oe/recipes-dbs/rocksdb/rocksdb_git.bb
> +++ b/meta-oe/recipes-dbs/rocksdb/rocksdb_git.bb
> @@ -30,6 +30,7 @@ EXTRA_OECMAKE = "\
>      -DPORTABLE=ON \
>      -DWITH_TESTS=OFF \
>      -DWITH_TOOLS=OFF \
> +    -DFAIL_ON_WARNINGS=OFF \
>  "
>
>  do_install_append() {
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel