[1/2] phoronix-test-suite: add rconflict

Submitted by changqing.li@windriver.com on May 28, 2019, 2:51 a.m. | Patch ID: 161695

Details

Message ID 1559011919-113581-1-git-send-email-changqing.li@windriver.com
State Not Applicable
Commit befd823e6465c74f5bbd31bacde2a312fd807a02
Headers show

Commit Message

changqing.li@windriver.com May 28, 2019, 2:51 a.m.
From: Changqing Li <changqing.li@windriver.com>

phoronix-test-suite rdepend on lsb, lsb rdepend on lsbinitscripts,
lsbinitscripts rconflict with initscripts-functions. so also add
rconflict for this one.

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 .../recipes-benchmark/phoronix-test-suite/phoronix-test-suite_8.6.0.bb   | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/meta-oe/recipes-benchmark/phoronix-test-suite/phoronix-test-suite_8.6.0.bb b/meta-oe/recipes-benchmark/phoronix-test-suite/phoronix-test-suite_8.6.0.bb
index 4c7b057..bdd6855 100644
--- a/meta-oe/recipes-benchmark/phoronix-test-suite/phoronix-test-suite_8.6.0.bb
+++ b/meta-oe/recipes-benchmark/phoronix-test-suite/phoronix-test-suite_8.6.0.bb
@@ -30,6 +30,7 @@  SYSTEMD_AUTO_ENABLE = "disable"
 SYSTEMD_SERVICE_${PN} = "phoromatic-client.service phoromatic-server.service"
 
 RDEPENDS_${PN} += "bash python php-cli util-linux-lscpu os-release lsb"
+RCONFLICTS_${PN} = "initscripts-functions"
 
 FILES_${PN} += " \
     ${datadir}/phoronix-test-suite \

Comments

Adrian Bunk May 28, 2019, 7:37 p.m.
On Tue, May 28, 2019 at 10:51:58AM +0800, changqing.li@windriver.com wrote:
> From: Changqing Li <changqing.li@windriver.com>
> 
> phoronix-test-suite rdepend on lsb, lsb rdepend on lsbinitscripts,
> lsbinitscripts rconflict with initscripts-functions. so also add
> rconflict for this one.
>...

In what situation is this needed?

It sounds wrong if rconflict from lower-level packages have to be 
replicated in higher-level packages, and is likely to break in the
future.

cu
Adrian
changqing.li@windriver.com May 29, 2019, 2:51 a.m.
On 5/29/19 3:37 AM, Adrian Bunk wrote:
> On Tue, May 28, 2019 at 10:51:58AM +0800, changqing.li@windriver.com wrote:
>> From: Changqing Li <changqing.li@windriver.com>
>>
>> phoronix-test-suite rdepend on lsb, lsb rdepend on lsbinitscripts,
>> lsbinitscripts rconflict with initscripts-functions. so also add
>> rconflict for this one.
>> ...
> In what situation is this needed?
>
> It sounds wrong if rconflict from lower-level packages have to be
> replicated in higher-level packages, and is likely to break in the
> future.
>
> cu
> Adrian

My original idea is that,  by add this info,  we can get the rconflict  
info when parse recipe.

But, you are right,  this  is not good for an indirect rconflicts.


@Khem,  I noticed this is on master-next,  so maybe this patch 1/2 
needed to be reverted.  Sorry for the inconvenience.
Khem Raj May 29, 2019, 9:06 a.m.
On Wed, May 29, 2019 at 4:51 AM Changqing Li <changqing.li@windriver.com> wrote:
>
> On 5/29/19 3:37 AM, Adrian Bunk wrote:
> > On Tue, May 28, 2019 at 10:51:58AM +0800, changqing.li@windriver.com wrote:
> >> From: Changqing Li <changqing.li@windriver.com>
> >>
> >> phoronix-test-suite rdepend on lsb, lsb rdepend on lsbinitscripts,
> >> lsbinitscripts rconflict with initscripts-functions. so also add
> >> rconflict for this one.
> >> ...
> > In what situation is this needed?
> >
> > It sounds wrong if rconflict from lower-level packages have to be
> > replicated in higher-level packages, and is likely to break in the
> > future.
> >
> > cu
> > Adrian
>
> My original idea is that,  by add this info,  we can get the rconflict
> info when parse recipe.
>
> But, you are right,  this  is not good for an indirect rconflicts.
>
>
> @Khem,  I noticed this is on master-next,  so maybe this patch 1/2
> needed to be reverted.  Sorry for the inconvenience.
>

thanks for letting me know, I have dropped it.
> --
> BRs
>
> Sandy(Li Changqing)
>