[2/5] conf/machine: add rk3399 support

Submitted by ayaka on April 21, 2019, 3:53 p.m. | Patch ID: 160567

Details

Message ID 20190421155339.6332-3-ayaka@soulik.info
State New
Headers show

Commit Message

ayaka April 21, 2019, 3:53 p.m.
RK3399 is a new generation powerful SoC from Rockchip, which has
Dual Cortex-A72 + Quad Cortex-A53, 64-bit CPU.

Signed-off-by: Randy 'ayaka' Li <ayaka@soulik.info>
---
 conf/machine/excavator-rk3399.conf | 10 ++++++++++
 conf/machine/firefly-rk3399.conf   | 15 +++++++++++++++
 conf/machine/include/rk3399.inc    | 17 +++++++++++++++++
 3 files changed, 42 insertions(+)
 create mode 100644 conf/machine/excavator-rk3399.conf
 create mode 100644 conf/machine/firefly-rk3399.conf
 create mode 100644 conf/machine/include/rk3399.inc

Patch hide | download patch | download mbox

diff --git a/conf/machine/excavator-rk3399.conf b/conf/machine/excavator-rk3399.conf
new file mode 100644
index 0000000..c7134d2
--- /dev/null
+++ b/conf/machine/excavator-rk3399.conf
@@ -0,0 +1,10 @@ 
+# Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+#@TYPE: Machine
+#@NAME: EXCAVATOR 3399
+
+include conf/machine/include/rk3399.inc
+
+KERNEL_DEVICETREE = "rk3399-sapphire-excavator-linux.dtb"
+UBOOT_MACHINE = "evb-rk3399_defconfig"
diff --git a/conf/machine/firefly-rk3399.conf b/conf/machine/firefly-rk3399.conf
new file mode 100644
index 0000000..fefafed
--- /dev/null
+++ b/conf/machine/firefly-rk3399.conf
@@ -0,0 +1,15 @@ 
+# Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+#@TYPE: Machine
+#@NAME: Firefly RK3399
+#@DESCRIPTION: Firefly-RK3399 is a Six-Core 64-bit High-Performance Platform.
+#http://www.t-firefly.com/en/
+
+include conf/machine/include/rk3399.inc
+
+PREFERRED_PROVIDER_virtual/kernel = "linux-rockchip"
+KERNEL_DEVICETREE = "rockchip/rk3399-firefly-linux.dtb"
+UBOOT_MACHINE = "evb-rk3399_defconfig"
+
+GPTIMG_APPEND = "console=ttyS2,1500000n8 rw root=PARTUUID=614e0000-0000 rootfstype=ext4 init=/sbin/init"
diff --git a/conf/machine/include/rk3399.inc b/conf/machine/include/rk3399.inc
new file mode 100644
index 0000000..6e2af57
--- /dev/null
+++ b/conf/machine/include/rk3399.inc
@@ -0,0 +1,17 @@ 
+# Copyright (C) 2019 SUMOMO Computer Association
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+SOC_FAMILY = "rk3399"
+
+require conf/machine/include/tune-cortexa72.inc
+require conf/machine/include/soc-family.inc
+
+PREFERRED_PROVIDER_virtual/kernel = "linux"
+SERIAL_CONSOLES = "1500000;ttyS2"
+KERNEL_IMAGETYPE = "Image"
+#KBUILD_DEFCONFIG = "multi_v8_defconfig"
+
+PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-rockchip"
+
+IMAGE_FSTYPES = "rockchip-gpt-img"
+IMAGE_CLASSES = "rockchip-gpt-img"

Comments

Khem Raj April 22, 2019, 3:47 a.m.
This seems more a bsp layer thing may be meta-rockchip is better for this
or meta-firefly

On Sun, Apr 21, 2019 at 10:06 AM Randy 'ayaka' Li <ayaka@soulik.info> wrote:

> RK3399 is a new generation powerful SoC from Rockchip, which has
> Dual Cortex-A72 + Quad Cortex-A53, 64-bit CPU.
>
> Signed-off-by: Randy 'ayaka' Li <ayaka@soulik.info>
> ---
>  conf/machine/excavator-rk3399.conf | 10 ++++++++++
>  conf/machine/firefly-rk3399.conf   | 15 +++++++++++++++
>  conf/machine/include/rk3399.inc    | 17 +++++++++++++++++
>  3 files changed, 42 insertions(+)
>  create mode 100644 conf/machine/excavator-rk3399.conf
>  create mode 100644 conf/machine/firefly-rk3399.conf
>  create mode 100644 conf/machine/include/rk3399.inc
>
> diff --git a/conf/machine/excavator-rk3399.conf
> b/conf/machine/excavator-rk3399.conf
> new file mode 100644
> index 0000000..c7134d2
> --- /dev/null
> +++ b/conf/machine/excavator-rk3399.conf
> @@ -0,0 +1,10 @@
> +# Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +#@TYPE: Machine
> +#@NAME: EXCAVATOR 3399
> +
> +include conf/machine/include/rk3399.inc
> +
> +KERNEL_DEVICETREE = "rk3399-sapphire-excavator-linux.dtb"
> +UBOOT_MACHINE = "evb-rk3399_defconfig"
> diff --git a/conf/machine/firefly-rk3399.conf
> b/conf/machine/firefly-rk3399.conf
> new file mode 100644
> index 0000000..fefafed
> --- /dev/null
> +++ b/conf/machine/firefly-rk3399.conf
> @@ -0,0 +1,15 @@
> +# Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +#@TYPE: Machine
> +#@NAME: Firefly RK3399
> +#@DESCRIPTION: Firefly-RK3399 is a Six-Core 64-bit High-Performance
> Platform.
> +#http://www.t-firefly.com/en/
> +
> +include conf/machine/include/rk3399.inc
> +
> +PREFERRED_PROVIDER_virtual/kernel = "linux-rockchip"
> +KERNEL_DEVICETREE = "rockchip/rk3399-firefly-linux.dtb"
> +UBOOT_MACHINE = "evb-rk3399_defconfig"
> +
> +GPTIMG_APPEND = "console=ttyS2,1500000n8 rw root=PARTUUID=614e0000-0000
> rootfstype=ext4 init=/sbin/init"
> diff --git a/conf/machine/include/rk3399.inc
> b/conf/machine/include/rk3399.inc
> new file mode 100644
> index 0000000..6e2af57
> --- /dev/null
> +++ b/conf/machine/include/rk3399.inc
> @@ -0,0 +1,17 @@
> +# Copyright (C) 2019 SUMOMO Computer Association
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +SOC_FAMILY = "rk3399"
> +
> +require conf/machine/include/tune-cortexa72.inc
> +require conf/machine/include/soc-family.inc
> +
> +PREFERRED_PROVIDER_virtual/kernel = "linux"
> +SERIAL_CONSOLES = "1500000;ttyS2"
> +KERNEL_IMAGETYPE = "Image"
> +#KBUILD_DEFCONFIG = "multi_v8_defconfig"
> +
> +PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-rockchip"
> +
> +IMAGE_FSTYPES = "rockchip-gpt-img"
> +IMAGE_CLASSES = "rockchip-gpt-img"
> --
> 2.20.1
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>
ayaka April 22, 2019, 6:29 a.m.
> On Apr 22, 2019, at 11:47 AM, Khem Raj <raj.khem@gmail.com> wrote:
> 
> This seems more a bsp layer thing may be meta-rockchip is better for this or meta-firefly 
> 
You want to make a board vendor maintain a layer repository themselves? I saw every meta bsp repository would have some configures files. And those boards are sold around the world having many users, it is waste time to make people to collect layers.

Anyway, I hope the chip support would be merged.
>> On Sun, Apr 21, 2019 at 10:06 AM Randy 'ayaka' Li <ayaka@soulik.info> wrote:
>> RK3399 is a new generation powerful SoC from Rockchip, which has
>> Dual Cortex-A72 + Quad Cortex-A53, 64-bit CPU.
>> 
>> Signed-off-by: Randy 'ayaka' Li <ayaka@soulik.info>
>> ---
>>  conf/machine/excavator-rk3399.conf | 10 ++++++++++
>>  conf/machine/firefly-rk3399.conf   | 15 +++++++++++++++
>>  conf/machine/include/rk3399.inc    | 17 +++++++++++++++++
>>  3 files changed, 42 insertions(+)
>>  create mode 100644 conf/machine/excavator-rk3399.conf
>>  create mode 100644 conf/machine/firefly-rk3399.conf
>>  create mode 100644 conf/machine/include/rk3399.inc
>> 
>> diff --git a/conf/machine/excavator-rk3399.conf b/conf/machine/excavator-rk3399.conf
>> new file mode 100644
>> index 0000000..c7134d2
>> --- /dev/null
>> +++ b/conf/machine/excavator-rk3399.conf
>> @@ -0,0 +1,10 @@
>> +# Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd
>> +# Released under the MIT license (see COPYING.MIT for the terms)
>> +
>> +#@TYPE: Machine
>> +#@NAME: EXCAVATOR 3399
>> +
>> +include conf/machine/include/rk3399.inc
>> +
>> +KERNEL_DEVICETREE = "rk3399-sapphire-excavator-linux.dtb"
>> +UBOOT_MACHINE = "evb-rk3399_defconfig"
>> diff --git a/conf/machine/firefly-rk3399.conf b/conf/machine/firefly-rk3399.conf
>> new file mode 100644
>> index 0000000..fefafed
>> --- /dev/null
>> +++ b/conf/machine/firefly-rk3399.conf
>> @@ -0,0 +1,15 @@
>> +# Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd
>> +# Released under the MIT license (see COPYING.MIT for the terms)
>> +
>> +#@TYPE: Machine
>> +#@NAME: Firefly RK3399
>> +#@DESCRIPTION: Firefly-RK3399 is a Six-Core 64-bit High-Performance Platform.
>> +#http://www.t-firefly.com/en/
>> +
>> +include conf/machine/include/rk3399.inc
>> +
>> +PREFERRED_PROVIDER_virtual/kernel = "linux-rockchip"
>> +KERNEL_DEVICETREE = "rockchip/rk3399-firefly-linux.dtb"
>> +UBOOT_MACHINE = "evb-rk3399_defconfig"
>> +
>> +GPTIMG_APPEND = "console=ttyS2,1500000n8 rw root=PARTUUID=614e0000-0000 rootfstype=ext4 init=/sbin/init"
>> diff --git a/conf/machine/include/rk3399.inc b/conf/machine/include/rk3399.inc
>> new file mode 100644
>> index 0000000..6e2af57
>> --- /dev/null
>> +++ b/conf/machine/include/rk3399.inc
>> @@ -0,0 +1,17 @@
>> +# Copyright (C) 2019 SUMOMO Computer Association
>> +# Released under the MIT license (see COPYING.MIT for the terms)
>> +
>> +SOC_FAMILY = "rk3399"
>> +
>> +require conf/machine/include/tune-cortexa72.inc
>> +require conf/machine/include/soc-family.inc
>> +
>> +PREFERRED_PROVIDER_virtual/kernel = "linux"
>> +SERIAL_CONSOLES = "1500000;ttyS2"
>> +KERNEL_IMAGETYPE = "Image"
>> +#KBUILD_DEFCONFIG = "multi_v8_defconfig"
>> +
>> +PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-rockchip"
>> +
>> +IMAGE_FSTYPES = "rockchip-gpt-img"
>> +IMAGE_CLASSES = "rockchip-gpt-img"
>> -- 
>> 2.20.1
>> 
>> -- 
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
Khem Raj April 22, 2019, 8:31 p.m.
On Mon, Apr 22, 2019 at 12:29 AM Ayaka <ayaka@soulik.info> wrote:

>
>
> On Apr 22, 2019, at 11:47 AM, Khem Raj <raj.khem@gmail.com> wrote:
>
> This seems more a bsp layer thing may be meta-rockchip is better for this
> or meta-firefly
>
> You want to make a board vendor maintain a layer repository themselves? I
> saw every meta bsp repository would have some configures files. And those
> boards are sold around the world having many users, it is waste time to
> make people to collect layers.
>

It depends on how motivated the community is for example look at
meta-raspberrypi layer which effectively is a board layer using Broadcom
chip
So either way I am not suggesting one way or another if meta-rockchip
maintainer likes to maintain them then it’s ok

>
> Anyway, I hope the chip support would be merged.
>
> On Sun, Apr 21, 2019 at 10:06 AM Randy 'ayaka' Li <ayaka@soulik.info>
> wrote:
>
>> RK3399 is a new generation powerful SoC from Rockchip, which has
>> Dual Cortex-A72 + Quad Cortex-A53, 64-bit CPU.
>>
>> Signed-off-by: Randy 'ayaka' Li <ayaka@soulik.info>
>> ---
>>  conf/machine/excavator-rk3399.conf | 10 ++++++++++
>>  conf/machine/firefly-rk3399.conf   | 15 +++++++++++++++
>>  conf/machine/include/rk3399.inc    | 17 +++++++++++++++++
>>  3 files changed, 42 insertions(+)
>>  create mode 100644 conf/machine/excavator-rk3399.conf
>>  create mode 100644 conf/machine/firefly-rk3399.conf
>>  create mode 100644 conf/machine/include/rk3399.inc
>>
>> diff --git a/conf/machine/excavator-rk3399.conf
>> b/conf/machine/excavator-rk3399.conf
>> new file mode 100644
>> index 0000000..c7134d2
>> --- /dev/null
>> +++ b/conf/machine/excavator-rk3399.conf
>> @@ -0,0 +1,10 @@
>> +# Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd
>> +# Released under the MIT license (see COPYING.MIT for the terms)
>> +
>> +#@TYPE: Machine
>> +#@NAME: EXCAVATOR 3399
>> +
>> +include conf/machine/include/rk3399.inc
>> +
>> +KERNEL_DEVICETREE = "rk3399-sapphire-excavator-linux.dtb"
>> +UBOOT_MACHINE = "evb-rk3399_defconfig"
>> diff --git a/conf/machine/firefly-rk3399.conf
>> b/conf/machine/firefly-rk3399.conf
>> new file mode 100644
>> index 0000000..fefafed
>> --- /dev/null
>> +++ b/conf/machine/firefly-rk3399.conf
>> @@ -0,0 +1,15 @@
>> +# Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd
>> +# Released under the MIT license (see COPYING.MIT for the terms)
>> +
>> +#@TYPE: Machine
>> +#@NAME: Firefly RK3399
>> +#@DESCRIPTION: Firefly-RK3399 is a Six-Core 64-bit High-Performance
>> Platform.
>> +#http://www.t-firefly.com/en/
>> +
>> +include conf/machine/include/rk3399.inc
>> +
>> +PREFERRED_PROVIDER_virtual/kernel = "linux-rockchip"
>> +KERNEL_DEVICETREE = "rockchip/rk3399-firefly-linux.dtb"
>> +UBOOT_MACHINE = "evb-rk3399_defconfig"
>> +
>> +GPTIMG_APPEND = "console=ttyS2,1500000n8 rw root=PARTUUID=614e0000-0000
>> rootfstype=ext4 init=/sbin/init"
>> diff --git a/conf/machine/include/rk3399.inc
>> b/conf/machine/include/rk3399.inc
>> new file mode 100644
>> index 0000000..6e2af57
>> --- /dev/null
>> +++ b/conf/machine/include/rk3399.inc
>> @@ -0,0 +1,17 @@
>> +# Copyright (C) 2019 SUMOMO Computer Association
>> +# Released under the MIT license (see COPYING.MIT for the terms)
>> +
>> +SOC_FAMILY = "rk3399"
>> +
>> +require conf/machine/include/tune-cortexa72.inc
>> +require conf/machine/include/soc-family.inc
>> +
>> +PREFERRED_PROVIDER_virtual/kernel = "linux"
>> +SERIAL_CONSOLES = "1500000;ttyS2"
>> +KERNEL_IMAGETYPE = "Image"
>> +#KBUILD_DEFCONFIG = "multi_v8_defconfig"
>> +
>> +PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-rockchip"
>> +
>> +IMAGE_FSTYPES = "rockchip-gpt-img"
>> +IMAGE_CLASSES = "rockchip-gpt-img"
>> --
>> 2.20.1
>>
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
>>
>
Trevor Woerner April 23, 2019, 8:10 a.m.
On Sun 2019-04-21 @ 11:53:36 PM, Randy 'ayaka' Li wrote:
> RK3399 is a new generation powerful SoC from Rockchip, which has
> Dual Cortex-A72 + Quad Cortex-A53, 64-bit CPU.
> 
> Signed-off-by: Randy 'ayaka' Li <ayaka@soulik.info>
> ---
>  conf/machine/excavator-rk3399.conf | 10 ++++++++++
>  conf/machine/firefly-rk3399.conf   | 15 +++++++++++++++
>  conf/machine/include/rk3399.inc    | 17 +++++++++++++++++
>  3 files changed, 42 insertions(+)
>  create mode 100644 conf/machine/excavator-rk3399.conf
>  create mode 100644 conf/machine/firefly-rk3399.conf
>  create mode 100644 conf/machine/include/rk3399.inc
> 
> diff --git a/conf/machine/excavator-rk3399.conf b/conf/machine/excavator-rk3399.conf
> new file mode 100644
> index 0000000..c7134d2
> --- /dev/null
> +++ b/conf/machine/excavator-rk3399.conf
> @@ -0,0 +1,10 @@
> +# Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +#@TYPE: Machine
> +#@NAME: EXCAVATOR 3399
> +
> +include conf/machine/include/rk3399.inc
> +
> +KERNEL_DEVICETREE = "rk3399-sapphire-excavator-linux.dtb"
> +UBOOT_MACHINE = "evb-rk3399_defconfig"


> diff --git a/conf/machine/firefly-rk3399.conf b/conf/machine/firefly-rk3399.conf
> new file mode 100644
> index 0000000..fefafed
> --- /dev/null
> +++ b/conf/machine/firefly-rk3399.conf
> @@ -0,0 +1,15 @@
> +# Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +#@TYPE: Machine
> +#@NAME: Firefly RK3399
> +#@DESCRIPTION: Firefly-RK3399 is a Six-Core 64-bit High-Performance Platform.
> +#http://www.t-firefly.com/en/
> +
> +include conf/machine/include/rk3399.inc
> +
> +PREFERRED_PROVIDER_virtual/kernel = "linux-rockchip"

linux-rockchip doesn't exist in git.yoctoproject.org/meta-rockchip. Has
support for this MACHINE been added upstream (i.e. kernel.org)?

> +KERNEL_DEVICETREE = "rockchip/rk3399-firefly-linux.dtb"
> +UBOOT_MACHINE = "evb-rk3399_defconfig"
> +
> +GPTIMG_APPEND = "console=ttyS2,1500000n8 rw root=PARTUUID=614e0000-0000 rootfstype=ext4 init=/sbin/init"


> diff --git a/conf/machine/include/rk3399.inc b/conf/machine/include/rk3399.inc
> new file mode 100644
> index 0000000..6e2af57
> --- /dev/null
> +++ b/conf/machine/include/rk3399.inc
> @@ -0,0 +1,17 @@
> +# Copyright (C) 2019 SUMOMO Computer Association
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +SOC_FAMILY = "rk3399"
> +
> +require conf/machine/include/tune-cortexa72.inc
> +require conf/machine/include/soc-family.inc
> +
> +PREFERRED_PROVIDER_virtual/kernel = "linux"

This setting conflicts with what you set in firefly-rk3399.conf above. Ideally
include files should probably use a weaker assignment? In any case, there is
no "linux" kernel defined, maybe you want "linux-stable" instead?

> +SERIAL_CONSOLES = "1500000;ttyS2"
> +KERNEL_IMAGETYPE = "Image"
> +#KBUILD_DEFCONFIG = "multi_v8_defconfig"
> +
> +PREFERRED_PROVIDER_virtual/bootloader ?= "u-boot-rockchip"

vendor-u-boot? Does upstream U-Boot support these MACHINEs?

> +
> +IMAGE_FSTYPES = "rockchip-gpt-img"
> +IMAGE_CLASSES = "rockchip-gpt-img"
> -- 
> 2.20.1
>