mesa%bbappend: switch imx to kmsro

Submitted by Trevor Woerner on March 27, 2019, 6:22 p.m. | Patch ID: 159857

Details

Message ID 20190327182204.29498-1-trevor@toganlabs.com
State New
Headers show

Commit Message

Trevor Woerner March 27, 2019, 6:22 p.m.
According to this commit:

	https://lists.freedesktop.org/archives/mesa-dev/2019-January/214067.html

The imx gallium driver has been switched to use "KMS readonly". I realize the
"vc4" looks suspicious, but (unfortunately) it is required in order to get
kmsro configured. Without it we get:

	configure: error: Building with kmsro requires vc4

Signed-off-by: Trevor Woerner <trevor@toganlabs.com>
---
 recipes-graphics/mesa/mesa_%.bbappend | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/recipes-graphics/mesa/mesa_%.bbappend b/recipes-graphics/mesa/mesa_%.bbappend
index 8541ed7c..2d5a9469 100644
--- a/recipes-graphics/mesa/mesa_%.bbappend
+++ b/recipes-graphics/mesa/mesa_%.bbappend
@@ -16,7 +16,7 @@  python () {
 
 # Enable Etnaviv support
 PACKAGECONFIG_append_use-mainline-bsp = " gallium"
-GALLIUMDRIVERS_append_use-mainline-bsp = ",etnaviv,imx"
+GALLIUMDRIVERS_append_use-mainline-bsp = ",etnaviv,kmsro,vc4"
 
 BACKEND = \
     "${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', \

Comments

Trevor Woerner March 27, 2019, 9:49 p.m.
I'm confused. My nightly builds have been failing for a while, I look into
it, create this patch, send it in, then Fabio's patch from 2 weeks ago gets
applied... but I don't see it on the list anywhere :-(
Can we please make sure all patches make it to the list for review?

By the way, according to the etanviv people, the vc4 thing is only a
remnant of an autotools error, once mesa is being built using meson this
"dependency" should go away.
Otavio Salvador April 1, 2019, 5:05 p.m.
On Wed, Mar 27, 2019 at 6:53 PM Trevor Woerner <twoerner@gmail.com> wrote:
> I'm confused. My nightly builds have been failing for a while, I look into it, create this patch, send it in, then Fabio's patch from 2 weeks ago gets applied... but I don't see it on the list anywhere :-(
> Can we please make sure all patches make it to the list for review?
>
> By the way, according to the etanviv people, the vc4 thing is only a remnant of an autotools error, once mesa is being built using meson this "dependency" should go away.

Yes, we were carrying this during the mesa update and keeping it local
until it reached master. I am sorry you ended having it been affected
by this issue but we try to be as fast as possible.

As said here, we moved out from mailing list for patches, as github is
nicer for high volume and also easier to not loose patches and
contributions so we have been doing this way now.
Trevor Woerner April 5, 2019, 5:13 p.m.
On Mon 2019-04-01 @ 02:05:58 PM, Otavio Salvador wrote:
> Yes, we were carrying this during the mesa update and keeping it local
> until it reached master. I am sorry you ended having it been affected
> by this issue but we try to be as fast as possible.
> 
> As said here, we moved out from mailing list for patches, as github is
> nicer for high volume and also easier to not loose patches and
> contributions so we have been doing this way now.

Ah, that explains it! :-)

No worries, thanks for the update. I'll be sure to use the new workflow :-)