[meta-java] jamvm: Disable inlining

Submitted by Marek Belisko on March 7, 2019, 11:57 a.m. | Patch ID: 159395

Details

Message ID 1551959871-9647-1-git-send-email-marek.belisko@open-nandra.com
State Accepted
Delegated to: Richard Leitner
Headers show

Commit Message

Marek Belisko March 7, 2019, 11:57 a.m.
This will fix crashes seen when build openjdk-8:

ERROR: jaxp1.3-native-1.4.01-r0 do_compile: Function failed: do_compile (log file is located at /home/jenkins/my_build/tmp/work/x86_64-linux/jaxp1.3-native/1.4.01-r0/temp/log.do_compile.28894)
ERROR: Logfile of failure stored in: /home/jenkins/my_build/tmp/work/x86_64-linux/jaxp1.3-native/1.4.01-r0/temp/log.do_compile.28894
Log data follows:
| DEBUG: Executing shell function do_compile
| Illegal instruction (core dumped)
| WARNING: exit code 132 from a shell command.
| ERROR: Function failed: do_compile (log file is located at /home/jenkins/my_build/tmp/work/x86_64-linux/jaxp1.3-native/1.4.01-r0/temp/log.do_compile.28894)
ERROR: Task (virtual:native:/home/jenkins/meta-java/recipes-core/xml-commons/jaxp1.3_1.4.01.bb:do_compile) failed with exit code '1'


Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
 recipes-core/jamvm/jamvm.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/recipes-core/jamvm/jamvm.inc b/recipes-core/jamvm/jamvm.inc
index fc21380..8a1ed63 100644
--- a/recipes-core/jamvm/jamvm.inc
+++ b/recipes-core/jamvm/jamvm.inc
@@ -29,7 +29,7 @@  do_configure_append_class-native() {
 }
 
 
-EXTRA_OECONF = "--with-classpath-install-dir=${prefix} --libdir=${libdir}/jamvm --enable-ffi"
+EXTRA_OECONF = "--with-classpath-install-dir=${prefix} --libdir=${libdir}/jamvm --enable-ffi --disable-int-inlining"
 
 # Needed for big compilation targets like OpenJDK
 CFLAGS_append_class-native = " -DDEFAULT_MAX_HEAP=1024*MB"

Comments

Belisko Marek April 30, 2019, 7:48 a.m.
Ping. any comments on this?

On Thu, Mar 7, 2019 at 12:57 PM Marek Belisko <marek.belisko@open-nandra.com>
wrote:

> This will fix crashes seen when build openjdk-8:
>
> ERROR: jaxp1.3-native-1.4.01-r0 do_compile: Function failed: do_compile
> (log file is located at
> /home/jenkins/my_build/tmp/work/x86_64-linux/jaxp1.3-native/1.4.01-r0/temp/log.do_compile.28894)
> ERROR: Logfile of failure stored in:
> /home/jenkins/my_build/tmp/work/x86_64-linux/jaxp1.3-native/1.4.01-r0/temp/log.do_compile.28894
> Log data follows:
> | DEBUG: Executing shell function do_compile
> | Illegal instruction (core dumped)
> | WARNING: exit code 132 from a shell command.
> | ERROR: Function failed: do_compile (log file is located at
> /home/jenkins/my_build/tmp/work/x86_64-linux/jaxp1.3-native/1.4.01-r0/temp/log.do_compile.28894)
> ERROR: Task
> (virtual:native:/home/jenkins/meta-java/recipes-core/xml-commons/jaxp1.3_1.4.01.bb:do_compile)
> failed with exit code '1'
>
>
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
>  recipes-core/jamvm/jamvm.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-core/jamvm/jamvm.inc b/recipes-core/jamvm/jamvm.inc
> index fc21380..8a1ed63 100644
> --- a/recipes-core/jamvm/jamvm.inc
> +++ b/recipes-core/jamvm/jamvm.inc
> @@ -29,7 +29,7 @@ do_configure_append_class-native() {
>  }
>
>
> -EXTRA_OECONF = "--with-classpath-install-dir=${prefix}
> --libdir=${libdir}/jamvm --enable-ffi"
> +EXTRA_OECONF = "--with-classpath-install-dir=${prefix}
> --libdir=${libdir}/jamvm --enable-ffi --disable-int-inlining"
>
>  # Needed for big compilation targets like OpenJDK
>  CFLAGS_append_class-native = " -DDEFAULT_MAX_HEAP=1024*MB"
> --
> 2.7.4
>
>
marek
Vyacheslav Yurkov May 10, 2019, 1:36 p.m.
Hi Marek,
Thanks for your patch. I can confirm that this resolves the Illegal 
instruction issue for me on gcc-7.4 and Morty branch. I don't think 
there should be any difference for master branch regarding this fix, in 
other words it must be applicable to master too.

Thanks,
Vyacheslav

On 30/04/2019 09:48, Belisko Marek wrote:
> Ping. any comments on this?
>
> On Thu, Mar 7, 2019 at 12:57 PM Marek Belisko <marek.belisko@open-nandra.com>
> wrote:
>
>> This will fix crashes seen when build openjdk-8:
>>
>> ERROR: jaxp1.3-native-1.4.01-r0 do_compile: Function failed: do_compile
>> (log file is located at
>> /home/jenkins/my_build/tmp/work/x86_64-linux/jaxp1.3-native/1.4.01-r0/temp/log.do_compile.28894)
>> ERROR: Logfile of failure stored in:
>> /home/jenkins/my_build/tmp/work/x86_64-linux/jaxp1.3-native/1.4.01-r0/temp/log.do_compile.28894
>> Log data follows:
>> | DEBUG: Executing shell function do_compile
>> | Illegal instruction (core dumped)
>> | WARNING: exit code 132 from a shell command.
>> | ERROR: Function failed: do_compile (log file is located at
>> /home/jenkins/my_build/tmp/work/x86_64-linux/jaxp1.3-native/1.4.01-r0/temp/log.do_compile.28894)
>> ERROR: Task
>> (virtual:native:/home/jenkins/meta-java/recipes-core/xml-commons/jaxp1.3_1.4.01.bb:do_compile)
>> failed with exit code '1'
>>
>>
>> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
>> ---
>>   recipes-core/jamvm/jamvm.inc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-core/jamvm/jamvm.inc b/recipes-core/jamvm/jamvm.inc
>> index fc21380..8a1ed63 100644
>> --- a/recipes-core/jamvm/jamvm.inc
>> +++ b/recipes-core/jamvm/jamvm.inc
>> @@ -29,7 +29,7 @@ do_configure_append_class-native() {
>>   }
>>
>>
>> -EXTRA_OECONF = "--with-classpath-install-dir=${prefix}
>> --libdir=${libdir}/jamvm --enable-ffi"
>> +EXTRA_OECONF = "--with-classpath-install-dir=${prefix}
>> --libdir=${libdir}/jamvm --enable-ffi --disable-int-inlining"
>>
>>   # Needed for big compilation targets like OpenJDK
>>   CFLAGS_append_class-native = " -DDEFAULT_MAX_HEAP=1024*MB"
>> --
>> 2.7.4
>>
>>
> marek
Richard Leitner Dec. 27, 2019, 11:48 a.m.
Hi,
this is a note to let you know that I've just added this patch to the
master-next branch of the meta-java repository at
       git://git.yoctoproject.org/meta-java

As soon as it has gone through some more testing it will likely be
merged to the master branch.

If you have any questions, please let me know.

regards;Richard.L

On 07/03/2019 12:57, Marek Belisko wrote:
> This will fix crashes seen when build openjdk-8:
> 
> ERROR: jaxp1.3-native-1.4.01-r0 do_compile: Function failed: do_compile (log file is located at /home/jenkins/my_build/tmp/work/x86_64-linux/jaxp1.3-native/1.4.01-r0/temp/log.do_compile.28894)
> ERROR: Logfile of failure stored in: /home/jenkins/my_build/tmp/work/x86_64-linux/jaxp1.3-native/1.4.01-r0/temp/log.do_compile.28894
> Log data follows:
> | DEBUG: Executing shell function do_compile
> | Illegal instruction (core dumped)
> | WARNING: exit code 132 from a shell command.
> | ERROR: Function failed: do_compile (log file is located at /home/jenkins/my_build/tmp/work/x86_64-linux/jaxp1.3-native/1.4.01-r0/temp/log.do_compile.28894)
> ERROR: Task (virtual:native:/home/jenkins/meta-java/recipes-core/xml-commons/jaxp1.3_1.4.01.bb:do_compile) failed with exit code '1'
> 
> 
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
>   recipes-core/jamvm/jamvm.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-core/jamvm/jamvm.inc b/recipes-core/jamvm/jamvm.inc
> index fc21380..8a1ed63 100644
> --- a/recipes-core/jamvm/jamvm.inc
> +++ b/recipes-core/jamvm/jamvm.inc
> @@ -29,7 +29,7 @@ do_configure_append_class-native() {
>   }
>   
>   
> -EXTRA_OECONF = "--with-classpath-install-dir=${prefix} --libdir=${libdir}/jamvm --enable-ffi"
> +EXTRA_OECONF = "--with-classpath-install-dir=${prefix} --libdir=${libdir}/jamvm --enable-ffi --disable-int-inlining"
>   
>   # Needed for big compilation targets like OpenJDK
>   CFLAGS_append_class-native = " -DDEFAULT_MAX_HEAP=1024*MB"
>