systemd: RDEPENDS on util-linux-umount

Submitted by André Draszik on Feb. 11, 2019, 12:04 p.m. | Patch ID: 158648

Details

Message ID 20190211120433.16148-1-git@andred.net
State Superseded
Commit 39a3d2c603429865af632fe41b2cf32c3dfdfb1d
Headers show

Commit Message

André Draszik Feb. 11, 2019, 12:04 p.m.
From: André Draszik <andre.draszik@jci.com>

It looks like there is an implicit dependency on util-linux'
umount - as otherwise when using busybox' umount we see a
long delay on shutdown / reboot.

[YOCTO #13058]

Signed-off-by: André Draszik <andre.draszik@jci.com>

---
this should only be merged with or after the util-linux
packaging rework
---
 meta/recipes-core/systemd/systemd_239.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-core/systemd/systemd_239.bb b/meta/recipes-core/systemd/systemd_239.bb
index f843f588bd..e2dfe639b3 100644
--- a/meta/recipes-core/systemd/systemd_239.bb
+++ b/meta/recipes-core/systemd/systemd_239.bb
@@ -556,7 +556,7 @@  FILES_${PN} = " ${base_bindir}/* \
 
 FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
 
-RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV}) util-linux-agetty util-linux-fsck"
+RDEPENDS_${PN} += "kmod dbus util-linux-mount util-linux-umount udev (= ${EXTENDPKGV}) util-linux-agetty util-linux-fsck"
 RDEPENDS_${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-generator', '', 'systemd-serialgetty', d)}"
 RDEPENDS_${PN} += "volatile-binds update-rc.d systemd-conf"
 

Comments

André Draszik Feb. 11, 2019, 12:08 p.m.
Please ignore this patch. Looks like a red-herring. Sorry for the noise.

On Mon, 2019-02-11 at 12:04 +0000, André Draszik wrote:
> From: André Draszik <andre.draszik@jci.com>
> 
> It looks like there is an implicit dependency on util-linux'
> umount - as otherwise when using busybox' umount we see a
> long delay on shutdown / reboot.
> 
> [YOCTO #13058]
> 
> Signed-off-by: André Draszik <andre.draszik@jci.com>
> 
> ---
> this should only be merged with or after the util-linux
> packaging rework
> ---
>  meta/recipes-core/systemd/systemd_239.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/systemd/systemd_239.bb b/meta/recipes-
> core/systemd/systemd_239.bb
> index f843f588bd..e2dfe639b3 100644
> --- a/meta/recipes-core/systemd/systemd_239.bb
> +++ b/meta/recipes-core/systemd/systemd_239.bb
> @@ -556,7 +556,7 @@ FILES_${PN} = " ${base_bindir}/* \
>  
>  FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-
> 1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
>  
> -RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV})
> util-linux-agetty util-linux-fsck"
> +RDEPENDS_${PN} += "kmod dbus util-linux-mount util-linux-umount udev (=
> ${EXTENDPKGV}) util-linux-agetty util-linux-fsck"
>  RDEPENDS_${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-
> generator', '', 'systemd-serialgetty', d)}"
>  RDEPENDS_${PN} += "volatile-binds update-rc.d systemd-conf"
>
Mikko Rapeli Feb. 11, 2019, 12:15 p.m.
On Mon, Feb 11, 2019 at 12:08:46PM +0000, André Draszik wrote:
> Please ignore this patch. Looks like a red-herring. Sorry for the noise.

FWIW, I would like to see this patch merged. Had some issues in the past
with busybox umount and added same change as a bbappend.

-Mikko

> On Mon, 2019-02-11 at 12:04 +0000, André Draszik wrote:
> > From: André Draszik <andre.draszik@jci.com>
> > 
> > It looks like there is an implicit dependency on util-linux'
> > umount - as otherwise when using busybox' umount we see a
> > long delay on shutdown / reboot.
> > 
> > [YOCTO #13058]
> > 
> > Signed-off-by: André Draszik <andre.draszik@jci.com>
> > 
> > ---
> > this should only be merged with or after the util-linux
> > packaging rework
> > ---
> >  meta/recipes-core/systemd/systemd_239.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-core/systemd/systemd_239.bb b/meta/recipes-
> > core/systemd/systemd_239.bb
> > index f843f588bd..e2dfe639b3 100644
> > --- a/meta/recipes-core/systemd/systemd_239.bb
> > +++ b/meta/recipes-core/systemd/systemd_239.bb
> > @@ -556,7 +556,7 @@ FILES_${PN} = " ${base_bindir}/* \
> >  
> >  FILES_${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-
> > 1/interfaces/ ${sysconfdir}/rpm/macros.systemd"
> >  
> > -RDEPENDS_${PN} += "kmod dbus util-linux-mount udev (= ${EXTENDPKGV})
> > util-linux-agetty util-linux-fsck"
> > +RDEPENDS_${PN} += "kmod dbus util-linux-mount util-linux-umount udev (=
> > ${EXTENDPKGV}) util-linux-agetty util-linux-fsck"
> >  RDEPENDS_${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-
> > generator', '', 'systemd-serialgetty', d)}"
> >  RDEPENDS_${PN} += "volatile-binds update-rc.d systemd-conf"
> >  
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Jonas Bonn Feb. 13, 2019, 10 a.m.
On 11/02/2019 13:15, Mikko.Rapeli@bmw.de wrote:
> On Mon, Feb 11, 2019 at 12:08:46PM +0000, André Draszik wrote:
>> Please ignore this patch. Looks like a red-herring. Sorry for the noise.
> 
> FWIW, I would like to see this patch merged. Had some issues in the past
> with busybox umount and added same change as a bbappend.

I'm also carrying a patch locally for this with the following explanation:

systemd passes the "-c" parameter (do not canonicalize) to the umount 
command and busybox's umount does not understand this parameter.

/Jonas
Randy MacLeod Feb. 13, 2019, 8:45 p.m.
On 2/13/19 5:00 AM, Jonas Bonn wrote:
> 
> 
> On 11/02/2019 13:15, Mikko.Rapeli@bmw.de wrote:
>> On Mon, Feb 11, 2019 at 12:08:46PM +0000, André Draszik wrote:
>>> Please ignore this patch. Looks like a red-herring. Sorry for the noise.
>>
>> FWIW, I would like to see this patch merged. Had some issues in the past
>> with busybox umount and added same change as a bbappend.
> 
> I'm also carrying a patch locally for this with the following explanation:
> 
> systemd passes the "-c" parameter (do not canonicalize) to the umount 
> command and busybox's umount does not understand this parameter.

With the current busybox do you really still see a problem since
busybox umount has been told to ignore "-c" now:
 
https://git.busybox.net/busybox/commit/?id=426134128112738c97a665170b21153ef0764b7d

    umount: ignore -c
"-c, --no-canonicalize: Do not canonicalize paths."

As busybox doesn't canonicalize paths in the first place it is safe to 
ignore
this option.

See https://github.com/systemd/systemd/issues/7786

Signed-off-by: Shawn Landden <slandden@gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>


and that's released in:

$ git tag --contains 426134128112738c97a665170b21153ef0764b7d
1_29_0
1_29_1
1_29_2
1_29_3
1_30_0


and we have:
meta/recipes-core/busybox/busybox_1.29.3.bb
Jonas Bonn Feb. 14, 2019, 9:15 a.m.
On 13/02/2019 21:45, Randy MacLeod wrote:
> On 2/13/19 5:00 AM, Jonas Bonn wrote:
>>
>>
>> On 11/02/2019 13:15, Mikko.Rapeli@bmw.de wrote:
>>> On Mon, Feb 11, 2019 at 12:08:46PM +0000, André Draszik wrote:
>>>> Please ignore this patch. Looks like a red-herring. Sorry for the 
>>>> noise.
>>>
>>> FWIW, I would like to see this patch merged. Had some issues in the past
>>> with busybox umount and added same change as a bbappend.
>>
>> I'm also carrying a patch locally for this with the following 
>> explanation:
>>
>> systemd passes the "-c" parameter (do not canonicalize) to the umount 
>> command and busybox's umount does not understand this parameter.
> 
> With the current busybox do you really still see a problem since
> busybox umount has been told to ignore "-c" now:

OK, my patch predates the fix in busybox and I haven't tested without it 
recently.  Previously umount would error out due to the unknown option 
and systemd-mount would fail rather inelegantly; the busybox fix should 
be sufficient to rectify this.

/Jonas
Adrian Bunk March 8, 2019, 1:27 a.m.
This is a system generated Comment: Patch 158648 was automatically marked as superseded by patch 159400.