modemmanager: Add libxslt-native to DEPENDS

Submitted by Theodore A. Roth on Jan. 11, 2019, 7:14 p.m. | Patch ID: 157802

Details

Message ID 20190111191454.GA7211@mrt.bozoland.org
State Accepted
Commit aad4917e13bb014ea11cb140ba568e065b147c21
Headers show

Commit Message

Theodore A. Roth Jan. 11, 2019, 7:14 p.m.
Addresses the following build error:

| make[2]: Entering directory '/home/matt/renew_thud/build/tmp/work/armv5e-poky-linux-gnueabi/modemmanager/1.8.2-r0.tr0/build/include'
| xsltproc --xinclude --nonet ../../ModemManager-1.8.2/build-aux/header-generator.xsl ../../ModemManager-1.8.2/introspection/all.xml > ModemManager-names.h
| /bin/bash: xsltproc: command not found
| make[2]: *** [Makefile:651: ModemManager-names.h] Error 127

Problem doesn't manifest if the host has already installed xsltproc
outside of OE environment.

Signed-off-by: Theodore A. Roth <troth@openavr.org>
Signed-off-by: Matthew Stanger <matthew_stanger@trimble.com>
Signed-off-by: Theodore A. Roth <theodore_roth@trimble.com>
---
 meta-oe/recipes-connectivity/modemmanager/modemmanager_1.8.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.8.2.bb b/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.8.2.bb
index f8e074a87..b374cb77a 100644
--- a/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.8.2.bb
+++ b/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.8.2.bb
@@ -9,7 +9,7 @@  LIC_FILES_CHKSUM = " \
 
 inherit gnomebase gettext systemd vala gobject-introspection bash-completion
 
-DEPENDS = "glib-2.0 libgudev dbus-glib intltool-native"
+DEPENDS = "glib-2.0 libgudev dbus-glib intltool-native libxslt-native"
 
 SRC_URI = "http://www.freedesktop.org/software/ModemManager/ModemManager-${PV}.tar.xz \
            file://0001-Do-not-set-Wno-unused-but-set-variable.patch \

Comments

Khem Raj Jan. 11, 2019, 8:23 p.m.
On Fri, Jan 11, 2019 at 11:15 AM Theodore A. Roth <troth@openavr.org> wrote:

> Addresses the following build error:
>
> | make[2]: Entering directory
> '/home/matt/renew_thud/build/tmp/work/armv5e-poky-linux-gnueabi/modemmanager/1.8.2-r0.tr0/build/include'
> | xsltproc --xinclude --nonet
> ../../ModemManager-1.8.2/build-aux/header-generator.xsl
> ../../ModemManager-1.8.2/introspection/all.xml > ModemManager-names.h
> | /bin/bash: xsltproc: command not found
> | make[2]: *** [Makefile:651: ModemManager-names.h] Error 127
>
> Problem doesn't manifest if the host has already installed xsltproc
> outside of OE environment.


The fix is good but I wonder how it’s able to peek st the one installed on
host do we have it in whitelist for hosttools

>
>
> Signed-off-by: Theodore A. Roth <troth@openavr.org>
> Signed-off-by: Matthew Stanger <matthew_stanger@trimble.com>
> Signed-off-by: Theodore A. Roth <theodore_roth@trimble.com>
> ---
>  meta-oe/recipes-connectivity/modemmanager/modemmanager_1.8.2.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-connectivity/modemmanager/
> modemmanager_1.8.2.bb b/meta-oe/recipes-connectivity/modemmanager/
> modemmanager_1.8.2.bb
> index f8e074a87..b374cb77a 100644
> --- a/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.8.2.bb
> +++ b/meta-oe/recipes-connectivity/modemmanager/modemmanager_1.8.2.bb
> @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = " \
>
>  inherit gnomebase gettext systemd vala gobject-introspection
> bash-completion
>
> -DEPENDS = "glib-2.0 libgudev dbus-glib intltool-native"
> +DEPENDS = "glib-2.0 libgudev dbus-glib intltool-native libxslt-native"
>
>  SRC_URI = "
> http://www.freedesktop.org/software/ModemManager/ModemManager-${PV}.tar.xz
> \
>             file://0001-Do-not-set-Wno-unused-but-set-variable.patch \
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>