[v2] libinput: Enable gui PACKAGECONFIG by default

Submitted by Alistair Francis on Jan. 10, 2019, 7:51 p.m. | Patch ID: 157727

Details

Message ID 20190110195121.13070-1-alistair.francis@wdc.com
State New
Headers show

Commit Message

Alistair Francis Jan. 10, 2019, 7:51 p.m.
Most users are going to be using libinput with some sort of display, so
enable gui in the PACKAGECONFIG by default.

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
 meta/recipes-graphics/wayland/libinput_1.12.3.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-graphics/wayland/libinput_1.12.3.bb b/meta/recipes-graphics/wayland/libinput_1.12.3.bb
index 3d1ab59309..d3f34c5040 100644
--- a/meta/recipes-graphics/wayland/libinput_1.12.3.bb
+++ b/meta/recipes-graphics/wayland/libinput_1.12.3.bb
@@ -15,7 +15,7 @@  SRC_URI[sha256sum] = "f266ff861a2e7a97e1402c4345e3547b900efde68adbd40e56403e2617
 UPSTREAM_CHECK_REGEX = "libinput-(?P<pver>\d+\.\d+\.(?!9\d+)\d+)"
 inherit meson pkgconfig lib_package
 
-PACKAGECONFIG ??= ""
+PACKAGECONFIG ??= "gui"
 PACKAGECONFIG[libwacom] = "-Dlibwacom=true,-Dlibwacom=false,libwacom"
 PACKAGECONFIG[gui] = "-Ddebug-gui=true,-Ddebug-gui=false,cairo gtk+3"
 

Comments

Ross Burton Jan. 10, 2019, 8:04 p.m.
On Thu, 10 Jan 2019 at 19:51, Alistair Francis <Alistair.Francis@wdc.com>
wrote:

> Most users are going to be using libinput with some sort of display, so
> enable gui in the PACKAGECONFIG by default.


Whilst the assertion that people will be using libinput with a display is
true, this turns on a debug mode (and promptly pulled gtk+3 into the
dependency tree).  Is this something that is universally useful?  I'm
leaning towards thinking it should remain as-is.

Ross
Alistair Francis Jan. 10, 2019, 10:08 p.m.
On Thu, Jan 10, 2019 at 12:04 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> On Thu, 10 Jan 2019 at 19:51, Alistair Francis <Alistair.Francis@wdc.com> wrote:
>>
>> Most users are going to be using libinput with some sort of display, so
>> enable gui in the PACKAGECONFIG by default.
>
>
> Whilst the assertion that people will be using libinput with a display is true, this turns on a debug mode (and promptly pulled gtk+3 into the dependency tree).  Is this something that is universally useful?  I'm leaning towards thinking it should remain as-is.

I would argue that it is universally useful and that libinput is not
really useful without it.

Alistair

>
> Ross
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Ross Burton Jan. 10, 2019, 11:04 p.m.
On Thu, 10 Jan 2019 at 22:09, Alistair Francis <alistair23@gmail.com> wrote:

> > Whilst the assertion that people will be using libinput with a display
> is true, this turns on a debug mode (and promptly pulled gtk+3 into the
> dependency tree).  Is this something that is universally useful?  I'm
> leaning towards thinking it should remain as-is.
>
> I would argue that it is universally useful and that libinput is not
> really useful without it.


libinput isn't useful without a graphical debugging tool?  That seems quite
a stretch.

Ross
Alistair Francis Jan. 10, 2019, 11:14 p.m.
On Thu, Jan 10, 2019 at 3:04 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> On Thu, 10 Jan 2019 at 22:09, Alistair Francis <alistair23@gmail.com> wrote:
>>
>> > Whilst the assertion that people will be using libinput with a display is true, this turns on a debug mode (and promptly pulled gtk+3 into the dependency tree).  Is this something that is universally useful?  I'm leaning towards thinking it should remain as-is.
>>
>> I would argue that it is universally useful and that libinput is not
>> really useful without it.
>
>
> libinput isn't useful without a graphical debugging tool?  That seems quite a stretch.

I meant that libinput isn't useful without the gui support.

I think that this is worth having the extra packages as libinput is
not really useful without gui support.

Alistair

>
> Ross
Ross Burton Jan. 10, 2019, 11:53 p.m.
On Thu, 10 Jan 2019 at 23:14, Alistair Francis <alistair23@gmail.com> wrote:

> > libinput isn't useful without a graphical debugging tool?  That seems
> quite a stretch.
>
> I meant that libinput isn't useful without the gui support.
>
> I think that this is worth having the extra packages as libinput is
> not really useful without gui support.


Sure, but the gui packageconfig just does -Ddebug-gui=yes, which just
builds the libinput-debug-gui binary.  Surely that isn't essential?

Ross
Alistair Francis Jan. 12, 2019, 1:32 a.m.
On Thu, Jan 10, 2019 at 3:54 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> On Thu, 10 Jan 2019 at 23:14, Alistair Francis <alistair23@gmail.com> wrote:
>>
>> > libinput isn't useful without a graphical debugging tool?  That seems quite a stretch.
>>
>> I meant that libinput isn't useful without the gui support.
>>
>> I think that this is worth having the extra packages as libinput is
>> not really useful without gui support.
>
>
> Sure, but the gui packageconfig just does -Ddebug-gui=yes, which just builds the libinput-debug-gui binary.  Surely that isn't essential?

Hmm... I thought it was, but apparently it isn't. Looks like we don't
need this then.

Alistair

>
> Ross