libunwind: Enable building static archive on musl

Submitted by Khem Raj on Dec. 6, 2018, 12:07 a.m. | Patch ID: 156942

Details

Message ID 20181206000749.28731-1-raj.khem@gmail.com
State Accepted
Commit 37ddab09f0ed9b532fb9ac57f622c8609121aa65
Headers show

Commit Message

Khem Raj Dec. 6, 2018, 12:07 a.m.
This ensures that we have .a for libunwind on musl targets, this is used
for stack unwinding infra e.g. in rust

Help compiling rust compiler and standard library from meta-rust

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-support/libunwind/libunwind_1.2.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-support/libunwind/libunwind_1.2.1.bb b/meta/recipes-support/libunwind/libunwind_1.2.1.bb
index e7fb2b2190..c9239b695e 100644
--- a/meta/recipes-support/libunwind/libunwind_1.2.1.bb
+++ b/meta/recipes-support/libunwind/libunwind_1.2.1.bb
@@ -14,7 +14,7 @@  SRC_URI = "http://download.savannah.nongnu.org/releases/libunwind/libunwind-${PV
            "
 
 SRC_URI_append_libc-musl = " file://musl-header-conflict.patch"
-EXTRA_OECONF_append_libc-musl = " --disable-documentation --disable-tests "
+EXTRA_OECONF_append_libc-musl = " --disable-documentation --disable-tests --enable-static"
 
 # http://errors.yoctoproject.org/Errors/Details/20487/
 ARM_INSTRUCTION_SET_armv4 = "arm"

Comments

Ross Burton Dec. 6, 2018, 11:49 a.m.
Presumably static archives are disabled by the no-static-libs include.
So is this really musl-specific?

Ross
On Thu, 6 Dec 2018 at 00:08, Khem Raj <raj.khem@gmail.com> wrote:
>
> This ensures that we have .a for libunwind on musl targets, this is used
> for stack unwinding infra e.g. in rust
>
> Help compiling rust compiler and standard library from meta-rust
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-support/libunwind/libunwind_1.2.1.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-support/libunwind/libunwind_1.2.1.bb b/meta/recipes-support/libunwind/libunwind_1.2.1.bb
> index e7fb2b2190..c9239b695e 100644
> --- a/meta/recipes-support/libunwind/libunwind_1.2.1.bb
> +++ b/meta/recipes-support/libunwind/libunwind_1.2.1.bb
> @@ -14,7 +14,7 @@ SRC_URI = "http://download.savannah.nongnu.org/releases/libunwind/libunwind-${PV
>             "
>
>  SRC_URI_append_libc-musl = " file://musl-header-conflict.patch"
> -EXTRA_OECONF_append_libc-musl = " --disable-documentation --disable-tests "
> +EXTRA_OECONF_append_libc-musl = " --disable-documentation --disable-tests --enable-static"
>
>  # http://errors.yoctoproject.org/Errors/Details/20487/
>  ARM_INSTRUCTION_SET_armv4 = "arm"
> --
> 2.19.2
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj Dec. 6, 2018, 3:45 p.m.
Yes, they are. But for musl libunwind static lib is required for rust
runtime to build all the time static or not

On Thu, Dec 6, 2018 at 3:49 AM Burton, Ross <ross.burton@intel.com> wrote:

> Presumably static archives are disabled by the no-static-libs include.
> So is this really musl-specific?
>
> Ross
> On Thu, 6 Dec 2018 at 00:08, Khem Raj <raj.khem@gmail.com> wrote:
> >
> > This ensures that we have .a for libunwind on musl targets, this is used
> > for stack unwinding infra e.g. in rust
> >
> > Help compiling rust compiler and standard library from meta-rust
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta/recipes-support/libunwind/libunwind_1.2.1.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-support/libunwind/libunwind_1.2.1.bb
> b/meta/recipes-support/libunwind/libunwind_1.2.1.bb
> > index e7fb2b2190..c9239b695e 100644
> > --- a/meta/recipes-support/libunwind/libunwind_1.2.1.bb
> > +++ b/meta/recipes-support/libunwind/libunwind_1.2.1.bb
> > @@ -14,7 +14,7 @@ SRC_URI = "
> http://download.savannah.nongnu.org/releases/libunwind/libunwind-${PV
> >             "
> >
> >  SRC_URI_append_libc-musl = " file://musl-header-conflict.patch"
> > -EXTRA_OECONF_append_libc-musl = " --disable-documentation
> --disable-tests "
> > +EXTRA_OECONF_append_libc-musl = " --disable-documentation
> --disable-tests --enable-static"
> >
> >  # http://errors.yoctoproject.org/Errors/Details/20487/
> >  ARM_INSTRUCTION_SET_armv4 = "arm"
> > --
> > 2.19.2
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
Ross Burton Dec. 6, 2018, 4:03 p.m.
On Thu, 6 Dec 2018 at 15:45, Khem Raj <raj.khem@gmail.com> wrote:
> Yes, they are. But for musl libunwind static lib is required for rust runtime to build all the time static or not

And that's a musl-specific quirk of rust?

Ross
Khem Raj Dec. 6, 2018, 4:06 p.m.
Yes, that's correct, for glibc is uses libbacktrace, which is provided
by glibc itself, thats why we dont see a need for this with glibc

On Thu, Dec 6, 2018 at 8:03 AM Burton, Ross <ross.burton@intel.com> wrote:
>
> On Thu, 6 Dec 2018 at 15:45, Khem Raj <raj.khem@gmail.com> wrote:
> > Yes, they are. But for musl libunwind static lib is required for rust runtime to build all the time static or not
>
> And that's a musl-specific quirk of rust?
>
> Ross