[meta-oe] ndctl: remove useless module-base inheriting

Submitted by Hongxu Jia on Dec. 5, 2018, 6:43 a.m. | Patch ID: 156911

Details

Message ID 1543992181-27004-1-git-send-email-hongxu.jia@windriver.com
State Accepted
Commit f87aac8cfea7cf0b65b67661298cea94b9091506
Headers show

Commit Message

Hongxu Jia Dec. 5, 2018, 6:43 a.m.
Inherit module-base is allarch, which caused building lib32-libblockdev
do_configure failure:
[snip]
checking for libndctl >= 58.4... no
No package 'libndctl' found
[snip]

The lib32-ndctl of allarch deploy to /usr/lib64/pkgconfig/libndctl.pc
rather than expected /usr/lib/pkgconfig/libndctl.pc

Except allarch, inherit module-base is helpless, remove it.

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta-oe/recipes-core/ndctl/ndctl_v63.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta-oe/recipes-core/ndctl/ndctl_v63.bb b/meta-oe/recipes-core/ndctl/ndctl_v63.bb
index 17f3405..0c62743 100644
--- a/meta-oe/recipes-core/ndctl/ndctl_v63.bb
+++ b/meta-oe/recipes-core/ndctl/ndctl_v63.bb
@@ -8,7 +8,7 @@  HOMEPAGE = "https://git.kernel.org/cgit/linux/kernel/git/nvdimm/nvdimm.git/tree/
 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=e66651809cac5da60c8b80e9e4e79e08"
 
-inherit autotools-brokensep pkgconfig module-base bash-completion systemd
+inherit autotools-brokensep pkgconfig bash-completion systemd
 
 SRCREV = "cb2d678dd6d286dd96d31548c32449a8b883ae32"
 SRC_URI = "git://github.com/pmem/ndctl.git"

Comments

Hongxu Jia Dec. 5, 2018, 6:51 a.m.
On 2018/12/5 下午2:43, Hongxu Jia wrote:
> Inherit module-base is allarch, which caused building lib32-libblockdev

Sorry, the commit is not accurate, it should be s/allarch/MACHINE_ARCH/

//Hongxu

> do_configure failure:
> [snip]
> checking for libndctl >= 58.4... no
> No package 'libndctl' found
> [snip]
>
> The lib32-ndctl of allarch deploy to /usr/lib64/pkgconfig/libndctl.pc
> rather than expected /usr/lib/pkgconfig/libndctl.pc
>
> Except allarch, inherit module-base is helpless, remove it.
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>   meta-oe/recipes-core/ndctl/ndctl_v63.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-core/ndctl/ndctl_v63.bb b/meta-oe/recipes-core/ndctl/ndctl_v63.bb
> index 17f3405..0c62743 100644
> --- a/meta-oe/recipes-core/ndctl/ndctl_v63.bb
> +++ b/meta-oe/recipes-core/ndctl/ndctl_v63.bb
> @@ -8,7 +8,7 @@ HOMEPAGE = "https://git.kernel.org/cgit/linux/kernel/git/nvdimm/nvdimm.git/tree/
>   LICENSE = "GPLv2+"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=e66651809cac5da60c8b80e9e4e79e08"
>   
> -inherit autotools-brokensep pkgconfig module-base bash-completion systemd
> +inherit autotools-brokensep pkgconfig bash-completion systemd
>   
>   SRCREV = "cb2d678dd6d286dd96d31548c32449a8b883ae32"
>   SRC_URI = "git://github.com/pmem/ndctl.git"
Hongxu Jia Dec. 5, 2018, 6:06 p.m.
This is a system generated Comment: Patch 156911 was automatically marked as superseded by patch 156912.