[3/3] insane: clarify GNU_HASH warning

Submitted by Ross Burton on Dec. 3, 2018, 8:35 p.m. | Patch ID: 156841

Details

Message ID 20181203203516.26461-3-ross.burton@intel.com
State New
Headers show

Commit Message

Ross Burton Dec. 3, 2018, 8:35 p.m.
We have a fatal error if ELF objects don't have GNU_HASH segments don't don't
explain what the problem is.  At least give a hint to users by suggesting that
LDFLAGS wasn't passed to the compiler.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/classes/insane.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 4644221bc6b..6718feb3af5 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -383,7 +383,7 @@  def package_qa_hash_style(path, name, d, elf, messages):
             sane = True
 
     if has_syms and not sane:
-        package_qa_add_message(messages, "ldflags", "No GNU_HASH in the elf binary: '%s'" % path)
+        package_qa_add_message(messages, "ldflags", "No GNU_HASH in the ELF binary %s, didn't pass LDFLAGS?" % path)
 
 
 QAPATHTEST[buildpaths] = "package_qa_check_buildpaths"