[meta-oe,2/2] a2jmidid: Define own do_configure

Submitted by Khem Raj on Dec. 3, 2018, 8:12 p.m. | Patch ID: 156838

Details

Message ID 20181203201250.23144-2-raj.khem@gmail.com
State Accepted
Commit 04df72ad372d7148068d731a306806537a8d195b
Headers show

Commit Message

Khem Raj Dec. 3, 2018, 8:12 p.m.
waf script here does not support -o switch so define own which can
be run in B

Secondly, ensure to use python2

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-oe/recipes-multimedia/jack/a2jmidid_8.bb | 5 +++++
 1 file changed, 5 insertions(+)

Patch hide | download patch | download mbox

diff --git a/meta-oe/recipes-multimedia/jack/a2jmidid_8.bb b/meta-oe/recipes-multimedia/jack/a2jmidid_8.bb
index 59b73f8e8b..7dcaaf6828 100644
--- a/meta-oe/recipes-multimedia/jack/a2jmidid_8.bb
+++ b/meta-oe/recipes-multimedia/jack/a2jmidid_8.bb
@@ -23,4 +23,9 @@  LDFLAGS_append_libc-musl = " -lexecinfo"
 
 export LINKFLAGS="${LDFLAGS}"
 
+do_configure() {
+    sed -i 's|/usr/bin/.*python$|/usr/bin/env python2|' ${S}/a2j_control ${S}/waf ${S}/wscript
+    (cd ${B} && ${S}/waf configure --prefix=${prefix} ${WAF_EXTRA_CONF} ${EXTRA_OECONF})
+}
+
 FILES_${PN} += "${datadir}/dbus-1/services"

Comments

Andreas Müller Dec. 3, 2018, 9:27 p.m.
On Mon, Dec 3, 2018 at 9:13 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> waf script here does not support -o switch so define own which can
> be run in B
>
> Secondly, ensure to use python2
1. Why?
2. There is no python2 in sysroot Maybe it was doing it before but now
I think it makes recipe use host's python2.

Andreas
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta-oe/recipes-multimedia/jack/a2jmidid_8.bb | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/meta-oe/recipes-multimedia/jack/a2jmidid_8.bb b/meta-oe/recipes-multimedia/jack/a2jmidid_8.bb
> index 59b73f8e8b..7dcaaf6828 100644
> --- a/meta-oe/recipes-multimedia/jack/a2jmidid_8.bb
> +++ b/meta-oe/recipes-multimedia/jack/a2jmidid_8.bb
> @@ -23,4 +23,9 @@ LDFLAGS_append_libc-musl = " -lexecinfo"
>
>  export LINKFLAGS="${LDFLAGS}"
>
> +do_configure() {
> +    sed -i 's|/usr/bin/.*python$|/usr/bin/env python2|' ${S}/a2j_control ${S}/waf ${S}/wscript
> +    (cd ${B} && ${S}/waf configure --prefix=${prefix} ${WAF_EXTRA_CONF} ${EXTRA_OECONF})
> +}
> +
>  FILES_${PN} += "${datadir}/dbus-1/services"
> --
> 2.19.2
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Khem Raj Dec. 3, 2018, 9:52 p.m.
On Mon, Dec 3, 2018 at 1:27 PM Andreas Müller <schnitzeltony@gmail.com>
wrote:

> On Mon, Dec 3, 2018 at 9:13 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > waf script here does not support -o switch so define own which can
> > be run in B
> >
> > Secondly, ensure to use python2
> 1. Why?
> 2. There is no python2 in sysroot Maybe it was doing it before but now
> I think it makes recipe use host's python2.


This is during build not runtime
This is to ensure build works on hosts who have switched to python 3

>
>
> Andreas
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta-oe/recipes-multimedia/jack/a2jmidid_8.bb | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/meta-oe/recipes-multimedia/jack/a2jmidid_8.bb
> b/meta-oe/recipes-multimedia/jack/a2jmidid_8.bb
> > index 59b73f8e8b..7dcaaf6828 100644
> > --- a/meta-oe/recipes-multimedia/jack/a2jmidid_8.bb
> > +++ b/meta-oe/recipes-multimedia/jack/a2jmidid_8.bb
> > @@ -23,4 +23,9 @@ LDFLAGS_append_libc-musl = " -lexecinfo"
> >
> >  export LINKFLAGS="${LDFLAGS}"
> >
> > +do_configure() {
> > +    sed -i 's|/usr/bin/.*python$|/usr/bin/env python2|'
> ${S}/a2j_control ${S}/waf ${S}/wscript
> > +    (cd ${B} && ${S}/waf configure --prefix=${prefix} ${WAF_EXTRA_CONF}
> ${EXTRA_OECONF})
> > +}
> > +
> >  FILES_${PN} += "${datadir}/dbus-1/services"
> > --
> > 2.19.2
> >
> > --
> > _______________________________________________
> > Openembedded-devel mailing list
> > Openembedded-devel@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>