[v4,6/8] acl: Use install instead of cp

Submitted by douglas.royds on Nov. 28, 2018, 11:43 p.m. | Patch ID: 156720

Details

Message ID 20181128234345.19191-7-douglas.royds@taitradio.com
State New
Headers show

Commit Message

douglas.royds Nov. 28, 2018, 11:43 p.m.
Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
---
 meta/recipes-support/attr/acl_2.2.52.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-support/attr/acl_2.2.52.bb b/meta/recipes-support/attr/acl_2.2.52.bb
index 8b89de9b42..318308a009 100644
--- a/meta/recipes-support/attr/acl_2.2.52.bb
+++ b/meta/recipes-support/attr/acl_2.2.52.bb
@@ -41,8 +41,8 @@  inherit ptest
 
 do_install_ptest() {
 	tar -c --exclude=nfs test/ | ( cd ${D}${PTEST_PATH} && tar -xf - )
-	mkdir ${D}${PTEST_PATH}/include
-	cp ${S}/include/builddefs ${S}/include/buildmacros ${S}/include/buildrules ${D}${PTEST_PATH}/include/
+	install -d ${D}${PTEST_PATH}/include
+	install -m 644 ${S}/include/builddefs ${S}/include/buildmacros ${S}/include/buildrules ${D}${PTEST_PATH}/include/
 	# Remove any build host references
 	sed -e "s:--sysroot=${STAGING_DIR_TARGET}::g" \
 	    -e 's:${HOSTTOOLS_DIR}/::g' \

Comments

Mark Hatle Nov. 28, 2018, 11:47 p.m.
You should explain in the commit message -why- you made the change.  It's
already clear WHAT the change is, but not why you did it.

On 11/28/18 5:43 PM, Douglas Royds wrote:
> Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> ---
>  meta/recipes-support/attr/acl_2.2.52.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-support/attr/acl_2.2.52.bb b/meta/recipes-support/attr/acl_2.2.52.bb
> index 8b89de9b42..318308a009 100644
> --- a/meta/recipes-support/attr/acl_2.2.52.bb
> +++ b/meta/recipes-support/attr/acl_2.2.52.bb
> @@ -41,8 +41,8 @@ inherit ptest
>  
>  do_install_ptest() {
>  	tar -c --exclude=nfs test/ | ( cd ${D}${PTEST_PATH} && tar -xf - )
> -	mkdir ${D}${PTEST_PATH}/include
> -	cp ${S}/include/builddefs ${S}/include/buildmacros ${S}/include/buildrules ${D}${PTEST_PATH}/include/
> +	install -d ${D}${PTEST_PATH}/include
> +	install -m 644 ${S}/include/builddefs ${S}/include/buildmacros ${S}/include/buildrules ${D}${PTEST_PATH}/include/
>  	# Remove any build host references
>  	sed -e "s:--sysroot=${STAGING_DIR_TARGET}::g" \
>  	    -e 's:${HOSTTOOLS_DIR}/::g' \
>