[meta-java] java-library: make easy to override jar package name

Submitted by nick83ola on Nov. 23, 2018, 3:09 p.m. | Patch ID: 156583

Details

Message ID CABPh3UPXB=MzAUwMgmfaKZ100Fqgp7juiv1R61AaYfpFCFeefw@mail.gmail.com
State Changes Requested
Delegated to: Richard Leitner
Headers show

Commit Message

nick83ola Nov. 23, 2018, 3:09 p.m.
define JARFILENAME and ALTJARFILENAMES with ?= to make simple
to override them

Signed-off-by: Nicola Lunghi <nick83ola@gmail.com>
---
classes/java-library.bbclass | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Patch hide | download patch | download mbox

diff --git a/classes/java-library.bbclass b/classes/java-library.bbclass
index ce1cd28..c69cf6b 100644
--- a/classes/java-library.bbclass
+++ b/classes/java-library.bbclass
@@ -42,10 +42,10 @@  PACKAGES += "${JPN}"
FILES_${JPN} = "${datadir_java}"
# File name of the libraries' main Jar file
-JARFILENAME = "${BP}.jar"
+JARFILENAME ?= "${BP}.jar"
# Space-separated list of alternative file names.
-ALTJARFILENAMES = "${BPN}.jar"
+ALTJARFILENAMES ?= "${BPN}.jar"
# Java "source" distributions often contain precompiled things
# we want to delete first.
-- 
2.19.1
-- 
_______________________________________________
Openembedded-devel mailing list

Comments

Richard Leitner Dec. 17, 2018, 2:53 p.m.
Hi,
thanks for the patch.

Two things:

First can you please use your real name in the From: (or prepend the From: line to the email body).

Second: would you please describe the reasons for changing = to ?= in more detail?
What's the purpose/benefit you get from it?

thanks & regards;Richard.L

On 23.11.18 16:09, nick83ola wrote:
> define JARFILENAME and ALTJARFILENAMES with ?= to make simple
> to override them
> 
> Signed-off-by: Nicola Lunghi <nick83ola@gmail.com>
> ---
> classes/java-library.bbclass | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/classes/java-library.bbclass b/classes/java-library.bbclass
> index ce1cd28..c69cf6b 100644
> --- a/classes/java-library.bbclass
> +++ b/classes/java-library.bbclass
> @@ -42,10 +42,10 @@ PACKAGES += "${JPN}"
> FILES_${JPN} = "${datadir_java}"
> # File name of the libraries' main Jar file
> -JARFILENAME = "${BP}.jar"
> +JARFILENAME ?= "${BP}.jar"
> # Space-separated list of alternative file names.
> -ALTJARFILENAMES = "${BPN}.jar"
> +ALTJARFILENAMES ?= "${BPN}.jar"
> # Java "source" distributions often contain precompiled things
> # we want to delete first.
>