[bitbake-devel,2/2] fetch: don't use shell=True when listing ar files

Submitted by Ross Burton on Nov. 23, 2018, 3:01 p.m. | Patch ID: 156582

Details

Message ID 20181123150122.23585-2-ross.burton@intel.com
State New
Headers show

Commit Message

Ross Burton Nov. 23, 2018, 3:01 p.m.
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 bitbake/lib/bb/fetch2/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py
index 572b71a9655..8d05f0c3d82 100644
--- a/bitbake/lib/bb/fetch2/__init__.py
+++ b/bitbake/lib/bb/fetch2/__init__.py
@@ -1469,7 +1469,7 @@  class FetchMethod(object):
                 else:
                     cmd = 'rpm2cpio.sh %s | cpio -id' % (file)
             elif file.endswith('.deb') or file.endswith('.ipk'):
-                output = subprocess.check_output('ar -t %s' % file, preexec_fn=subprocess_setup, shell=True)
+                output = subprocess.check_output(['ar', '-t', file], preexec_fn=subprocess_setup)
                 datafile = None
                 if output:
                     for line in output.decode().splitlines():