[bitbake-devel,1/2] layerindex: don't use shell=True when cloning

Submitted by Ross Burton on Nov. 23, 2018, 3:01 p.m. | Patch ID: 156581

Details

Message ID 20181123150122.23585-1-ross.burton@intel.com
State New
Headers show

Commit Message

Ross Burton Nov. 23, 2018, 3:01 p.m.
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 bitbake/lib/bblayers/layerindex.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/bitbake/lib/bblayers/layerindex.py b/bitbake/lib/bblayers/layerindex.py
index 9f02a9da2ef..b2ff2268ea6 100644
--- a/bitbake/lib/bblayers/layerindex.py
+++ b/bitbake/lib/bblayers/layerindex.py
@@ -28,7 +28,7 @@  class LayerIndexPlugin(ActionPlugin):
         layerdir = os.path.join(repodir, subdir)
         if not os.path.exists(repodir):
             if fetch_layer:
-                result = subprocess.call('git clone %s %s' % (url, repodir), shell = True)
+                result = subprocess.call(['git', 'clone', url, repodir])
                 if result:
                     logger.error("Failed to download %s" % url)
                     return None, None, None