[meta-oe] ndctl: fix compile issue

Submitted by Armin Kuster on Nov. 18, 2018, 5:08 p.m. | Patch ID: 156371

Details

Message ID 1542560899-8877-1-git-send-email-akuster808@gmail.com
State Changes Requested
Commit 2c9681654b01c1bfcfd6162fe20e52e14a93e354
Headers show

Commit Message

Armin Kuster Nov. 18, 2018, 5:08 p.m.
| No package 'systemd' found
| configure: error: systemd support requested but pkg-config unable to query systemd package

add PACKCONFIG to disable systemd

Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 meta-oe/recipes-core/ndctl/ndctl_git.bb | 3 +++
 1 file changed, 3 insertions(+)

Patch hide | download patch | download mbox

diff --git a/meta-oe/recipes-core/ndctl/ndctl_git.bb b/meta-oe/recipes-core/ndctl/ndctl_git.bb
index b20915f..048f166 100644
--- a/meta-oe/recipes-core/ndctl/ndctl_git.bb
+++ b/meta-oe/recipes-core/ndctl/ndctl_git.bb
@@ -21,6 +21,9 @@  S = "${WORKDIR}/git"
 
 EXTRA_OECONF += "--enable-test --enable-destructive --disable-docs"
 
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[systemd] = "--with-systemd-unit-dir=${systemd_system_unitdir}, --without-systemd-unit-dir,"
+
 do_configure_prepend() {
     ${S}/autogen.sh
 }

Comments

Martin Hundebøll Nov. 23, 2018, 9:16 a.m.
Hi Armin,

On 18/11/2018 18.08, Armin Kuster wrote:
> | No package 'systemd' found
> | configure: error: systemd support requested but pkg-config unable to query systemd package
> 
> add PACKCONFIG to disable systemd
> 
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
>   meta-oe/recipes-core/ndctl/ndctl_git.bb | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/meta-oe/recipes-core/ndctl/ndctl_git.bb b/meta-oe/recipes-core/ndctl/ndctl_git.bb
> index b20915f..048f166 100644
> --- a/meta-oe/recipes-core/ndctl/ndctl_git.bb
> +++ b/meta-oe/recipes-core/ndctl/ndctl_git.bb
> @@ -21,6 +21,9 @@ S = "${WORKDIR}/git"
>   
>   EXTRA_OECONF += "--enable-test --enable-destructive --disable-docs"
>   
> +PACKAGECONFIG ??= ""

Can you make the default PACKAGECONFIG include systemd if it is in 
distrofeatures?

PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"

// Martin

> +PACKAGECONFIG[systemd] = "--with-systemd-unit-dir=${systemd_system_unitdir}, --without-systemd-unit-dir,"
> +
>   do_configure_prepend() {
>       ${S}/autogen.sh
>   }
>
Khem Raj Nov. 26, 2018, 5:43 p.m.
On Fri, Nov 23, 2018 at 1:17 AM Martin Hundebøll <martin@geanix.com> wrote:
>
> Hi Armin,
>
> On 18/11/2018 18.08, Armin Kuster wrote:
> > | No package 'systemd' found
> > | configure: error: systemd support requested but pkg-config unable to query systemd package
> >
> > add PACKCONFIG to disable systemd
> >
> > Signed-off-by: Armin Kuster <akuster808@gmail.com>
> > ---
> >   meta-oe/recipes-core/ndctl/ndctl_git.bb | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/meta-oe/recipes-core/ndctl/ndctl_git.bb b/meta-oe/recipes-core/ndctl/ndctl_git.bb
> > index b20915f..048f166 100644
> > --- a/meta-oe/recipes-core/ndctl/ndctl_git.bb
> > +++ b/meta-oe/recipes-core/ndctl/ndctl_git.bb
> > @@ -21,6 +21,9 @@ S = "${WORKDIR}/git"
> >
> >   EXTRA_OECONF += "--enable-test --enable-destructive --disable-docs"
> >
> > +PACKAGECONFIG ??= ""
>
> Can you make the default PACKAGECONFIG include systemd if it is in
> distrofeatures?

This is needed. See

http://errors.yoctoproject.org/Errors/Details/202222/

>
> PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)}"
>
> // Martin
>
> > +PACKAGECONFIG[systemd] = "--with-systemd-unit-dir=${systemd_system_unitdir}, --without-systemd-unit-dir,"
> > +
> >   do_configure_prepend() {
> >       ${S}/autogen.sh
> >   }
> >
>
> --
> Kind regards,
> Martin Hundebøll
> Embedded Linux Consultant
>
> +45 61 65 54 61
> martin@geanix.com
>
> Geanix IVS
> https://geanix.com
> DK39600706
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel