[bitbake-devel] siggen: Adapt colors used by bitbake-diffsigs to support light themes

Submitted by Peter Kjellerstedt on Nov. 14, 2018, 1:51 a.m. | Patch ID: 156271


Message ID 20181114015141.11564-1-pkj@axis.com
State Superseded
Headers show

Commit Message

Peter Kjellerstedt Nov. 14, 2018, 1:51 a.m.
The colors specified for use with bitbake-diffsigs were adapted for a
dark theme, e.g., by setting the background color to black, which made
it look very bad when used with a light theme.

To make it look good both with a dark or a light theme, it is better
to drop the background color. It is also better to leave out the color
altogether for the title and just use bold. Finally, dropping bold for
the red and green texts indicating removed/added values better matches
other colorized diff implementations as, e.g., git diff.

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
 bitbake/lib/bb/siggen.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Patch hide | download patch | download mbox

diff --git a/bitbake/lib/bb/siggen.py b/bitbake/lib/bb/siggen.py
index c619b596d8..fdbb2a3998 100644
--- a/bitbake/lib/bb/siggen.py
+++ b/bitbake/lib/bb/siggen.py
@@ -342,10 +342,10 @@  def dump_this_task(outfile, d):
 def init_colors(enable_color):
     """Initialise colour dict for passing to compare_sigfiles()"""
     # First set up the colours
-    colors = {'color_title':   '\033[1;37;40m',
-              'color_default': '\033[0;37;40m',
-              'color_add':     '\033[1;32;40m',
-              'color_remove':  '\033[1;31;40m',
+    colors = {'color_title':   '\033[1m',
+              'color_default': '\033[0m',
+              'color_add':     '\033[0;32m',
+              'color_remove':  '\033[0;31m',
     # Leave all keys present but clear the values
     if not enable_color:


Peter Kjellerstedt Dec. 23, 2018, 9:16 a.m.
This is a system generated Comment: Patch 156271 was automatically marked as superseded by patch 157394.