[meta-networking] blueman: fix rdepends issue

Submitted by Armin Kuster on Nov. 7, 2018, 7:11 p.m. | Patch ID: 156151

Details

Message ID 1541617902-21755-1-git-send-email-akuster808@gmail.com
State Changes Requested
Headers show

Commit Message

Armin Kuster Nov. 7, 2018, 7:11 p.m.
fixes
ERROR: Required build target 'blueman' has no buildable providers.
Missing or unbuildable dependency chain was: ['blueman', 'thunar']

Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/meta-networking/recipes-connectivity/blueman/blueman_git.bb b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
index 8eb99ed..06a11b7 100644
--- a/meta-networking/recipes-connectivity/blueman/blueman_git.bb
+++ b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
@@ -27,9 +27,10 @@  RRECOMENDS_${PN} += "adwaita-icon-theme"
 RDEPENDS_${PN} += " \
     python3-dbus \
     packagegroup-tools-bluetooth \
+    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
 "
-
-PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
+PACKAGECONGIG ??= ""
+PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
 
 FILES_${PN} += " \
     ${datadir}/dbus-1 \

Comments

Andreas Müller Nov. 7, 2018, 7:22 p.m.
On Wed, Nov 7, 2018 at 8:12 PM Armin Kuster <akuster808@gmail.com> wrote:
>
> fixes
> ERROR: Required build target 'blueman' has no buildable providers.
> Missing or unbuildable dependency chain was: ['blueman', 'thunar']
>
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
>  meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta-networking/recipes-connectivity/blueman/blueman_git.bb b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> index 8eb99ed..06a11b7 100644
> --- a/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> +++ b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> @@ -27,9 +27,10 @@ RRECOMENDS_${PN} += "adwaita-icon-theme"
>  RDEPENDS_${PN} += " \
>      python3-dbus \
>      packagegroup-tools-bluetooth \
> +    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
>  "
> -
> -PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
> +PACKAGECONGIG ??= ""
> +PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
>
>  FILES_${PN} += " \
>      ${datadir}/dbus-1 \
> --
> 2.7.4
>
This is not right: How shall this happen if meta-xfce is not in your
layers - I suggest you run a cleansstate after changing layer
configuration

Andreas
Armin Kuster Nov. 7, 2018, 7:40 p.m.
On 11/7/18 11:22 AM, Andreas Müller wrote:
> On Wed, Nov 7, 2018 at 8:12 PM Armin Kuster <akuster808@gmail.com> wrote:
>> fixes
>> ERROR: Required build target 'blueman' has no buildable providers.
>> Missing or unbuildable dependency chain was: ['blueman', 'thunar']
>>
>> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>> ---
>>  meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta-networking/recipes-connectivity/blueman/blueman_git.bb b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
>> index 8eb99ed..06a11b7 100644
>> --- a/meta-networking/recipes-connectivity/blueman/blueman_git.bb
>> +++ b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
>> @@ -27,9 +27,10 @@ RRECOMENDS_${PN} += "adwaita-icon-theme"
>>  RDEPENDS_${PN} += " \
>>      python3-dbus \
>>      packagegroup-tools-bluetooth \
>> +    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
>>  "
>> -
>> -PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
>> +PACKAGECONGIG ??= ""
>> +PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
>>
>>  FILES_${PN} += " \
>>      ${datadir}/dbus-1 \
>> --
>> 2.7.4
>>
> This is not right: How shall this happen if meta-xfce is not in your
> layers - I suggest you run a cleansstate after changing layer
> configuration


I am running the yocto-check-layer.  Should this recipe really be in
meta-xfce? .. I am out of options on how to get this to pass. Maybe no
one cares if it ever does???


- armin

> Andreas
Andreas Müller Nov. 7, 2018, 8 p.m.
On Wed, Nov 7, 2018 at 8:40 PM akuster808 <akuster808@gmail.com> wrote:
>
>
> On 11/7/18 11:22 AM, Andreas Müller wrote:
> > On Wed, Nov 7, 2018 at 8:12 PM Armin Kuster <akuster808@gmail.com> wrote:
> >> fixes
> >> ERROR: Required build target 'blueman' has no buildable providers.
> >> Missing or unbuildable dependency chain was: ['blueman', 'thunar']
> >>
> >> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> >> ---
> >>  meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
> >>  1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/meta-networking/recipes-connectivity/blueman/blueman_git.bb b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> >> index 8eb99ed..06a11b7 100644
> >> --- a/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> >> +++ b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> >> @@ -27,9 +27,10 @@ RRECOMENDS_${PN} += "adwaita-icon-theme"
> >>  RDEPENDS_${PN} += " \
> >>      python3-dbus \
> >>      packagegroup-tools-bluetooth \
> >> +    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
> >>  "
> >> -
> >> -PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
> >> +PACKAGECONGIG ??= ""
> >> +PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
> >>
> >>  FILES_${PN} += " \
> >>      ${datadir}/dbus-1 \
> >> --
> >> 2.7.4
> >>
> > This is not right: How shall this happen if meta-xfce is not in your
> > layers - I suggest you run a cleansstate after changing layer
> > configuration
>
>
> I am running the yocto-check-layer.
> Should this recipe really be in
> meta-xfce? .. I am out of options on how to get this to pass. Maybe no
> one cares if it ever does???
Put it to meta-xfce to make script happy - what a waste of time...

Andreas
Khem Raj Nov. 7, 2018, 8:26 p.m.
On Wed, Nov 7, 2018 at 12:01 PM Andreas Müller <schnitzeltony@gmail.com> wrote:
>
> On Wed, Nov 7, 2018 at 8:40 PM akuster808 <akuster808@gmail.com> wrote:
> >
> >
> > On 11/7/18 11:22 AM, Andreas Müller wrote:
> > > On Wed, Nov 7, 2018 at 8:12 PM Armin Kuster <akuster808@gmail.com> wrote:
> > >> fixes
> > >> ERROR: Required build target 'blueman' has no buildable providers.
> > >> Missing or unbuildable dependency chain was: ['blueman', 'thunar']
> > >>
> > >> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> > >> ---
> > >>  meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
> > >>  1 file changed, 3 insertions(+), 2 deletions(-)
> > >>
> > >> diff --git a/meta-networking/recipes-connectivity/blueman/blueman_git.bb b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> > >> index 8eb99ed..06a11b7 100644
> > >> --- a/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> > >> +++ b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> > >> @@ -27,9 +27,10 @@ RRECOMENDS_${PN} += "adwaita-icon-theme"
> > >>  RDEPENDS_${PN} += " \
> > >>      python3-dbus \
> > >>      packagegroup-tools-bluetooth \
> > >> +    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
> > >>  "
> > >> -
> > >> -PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
> > >> +PACKAGECONGIG ??= ""
> > >> +PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
> > >>
> > >>  FILES_${PN} += " \
> > >>      ${datadir}/dbus-1 \
> > >> --
> > >> 2.7.4
> > >>
> > > This is not right: How shall this happen if meta-xfce is not in your
> > > layers - I suggest you run a cleansstate after changing layer
> > > configuration
> >
> >
> > I am running the yocto-check-layer.
> > Should this recipe really be in
> > meta-xfce? .. I am out of options on how to get this to pass. Maybe no
> > one cares if it ever does???
> Put it to meta-xfce to make script happy - what a waste of time...
>

I think we can put a bbappend in meta-xfce which enables this
packageconfig and as such
this patch is fine.

> Andreas
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Martin Jansa Nov. 7, 2018, 8:44 p.m.
On Wed, Nov 07, 2018 at 11:40:40AM -0800, akuster808 wrote:
> 
> On 11/7/18 11:22 AM, Andreas Müller wrote:
> > On Wed, Nov 7, 2018 at 8:12 PM Armin Kuster <akuster808@gmail.com> wrote:
> >> fixes
> >> ERROR: Required build target 'blueman' has no buildable providers.
> >> Missing or unbuildable dependency chain was: ['blueman', 'thunar']
> >>
> >> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> >> ---
> >>  meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
> >>  1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/meta-networking/recipes-connectivity/blueman/blueman_git.bb b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> >> index 8eb99ed..06a11b7 100644
> >> --- a/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> >> +++ b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> >> @@ -27,9 +27,10 @@ RRECOMENDS_${PN} += "adwaita-icon-theme"
> >>  RDEPENDS_${PN} += " \
> >>      python3-dbus \
> >>      packagegroup-tools-bluetooth \
> >> +    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
> >>  "
> >> -
> >> -PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
> >> +PACKAGECONGIG ??= ""
> >> +PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
> >>
> >>  FILES_${PN} += " \
> >>      ${datadir}/dbus-1 \
> >> --
> >> 2.7.4
> >>
> > This is not right: How shall this happen if meta-xfce is not in your
> > layers - I suggest you run a cleansstate after changing layer
> > configuration
> 
> 
> I am running the yocto-check-layer.  Should this recipe really be in
> meta-xfce? .. I am out of options on how to get this to pass. Maybe no
> one cares if it ever does???

Isn't the error shown only with your addition to RDEPENDS? Because
without this patch the thunar dependency is enabled only when meta-xfce
layer is included with:

cat ./meta-xfce/recipes-connectivity/blueman/blueman_%.bbappend
PACKAGECONFIG_append = " thunar"

Why would blueman depend on thunar without meta-xfce?
And with both meta-networking and meta-xfce included it will find thunar
depdencency in meta-xfce.

But with your change you're adding thunar dependency whenever x11 is in
DISTRO_FEATURES with or without meta-xfce included which is clearly
wrong and yocto-check-layer would be correct to complain.
Andreas Müller Nov. 7, 2018, 9:30 p.m.
On Wed, Nov 7, 2018 at 9:44 PM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> On Wed, Nov 07, 2018 at 11:40:40AM -0800, akuster808 wrote:
> >
> > On 11/7/18 11:22 AM, Andreas Müller wrote:
> > > On Wed, Nov 7, 2018 at 8:12 PM Armin Kuster <akuster808@gmail.com> wrote:
> > >> fixes
> > >> ERROR: Required build target 'blueman' has no buildable providers.
> > >> Missing or unbuildable dependency chain was: ['blueman', 'thunar']
> > >>
> > >> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> > >> ---
> > >>  meta-networking/recipes-connectivity/blueman/blueman_git.bb | 5 +++--
> > >>  1 file changed, 3 insertions(+), 2 deletions(-)
> > >>
> > >> diff --git a/meta-networking/recipes-connectivity/blueman/blueman_git.bb b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> > >> index 8eb99ed..06a11b7 100644
> > >> --- a/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> > >> +++ b/meta-networking/recipes-connectivity/blueman/blueman_git.bb
> > >> @@ -27,9 +27,10 @@ RRECOMENDS_${PN} += "adwaita-icon-theme"
> > >>  RDEPENDS_${PN} += " \
> > >>      python3-dbus \
> > >>      packagegroup-tools-bluetooth \
> > >> +    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'thunar', '', d)} \
> > >>  "
> > >> -
> > >> -PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,thunar"
> > >> +PACKAGECONGIG ??= ""
> > >> +PACKAGECONFIG[thunar] = "--enable-thunar-sendto,--disable-thunar-sendto,,"
> > >>
> > >>  FILES_${PN} += " \
> > >>      ${datadir}/dbus-1 \
> > >> --
> > >> 2.7.4
> > >>
> > > This is not right: How shall this happen if meta-xfce is not in your
> > > layers - I suggest you run a cleansstate after changing layer
> > > configuration
> >
> >
> > I am running the yocto-check-layer.  Should this recipe really be in
> > meta-xfce? .. I am out of options on how to get this to pass. Maybe no
> > one cares if it ever does???
>
> Isn't the error shown only with your addition to RDEPENDS? Because
> without this patch the thunar dependency is enabled only when meta-xfce
> layer is included with:
>
> cat ./meta-xfce/recipes-connectivity/blueman/blueman_%.bbappend
> PACKAGECONFIG_append = " thunar"
>
> Why would blueman depend on thunar without meta-xfce?
> And with both meta-networking and meta-xfce included it will find thunar
> depdencency in meta-xfce.
>
> But with your change you're adding thunar dependency whenever x11 is in
> DISTRO_FEATURES with or without meta-xfce included which is clearly
> wrong and yocto-check-layer would be correct to complain.
>
My opinion as author and user of blueman recipe: The patch sent is
wrong. It breaks blueman's thunar-sendto-blueman.desktop in case
thunar is not in the image and I cannot see what's wrong with current
layout.

For me this is yet another example of wasting time for the sake of
yocto-layer-script.  Correct answer should have been: 'Go fix that
script' but that certainly would have caused further discussion. So I
agreed the suggestion to move blueman to meta-xfce. This makes holy
marketing script happy, matches my used-case and I can continue with
useful things.

Regards

Andreas