Message ID | 20181030233304.214025-1-joe.slater@windriver.com |
---|---|
State | New |
Headers | show |
diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py index 71a0eba..2a3721b 100644 --- a/lib/bb/cooker.py +++ b/lib/bb/cooker.py @@ -383,7 +383,8 @@ class BBCooker: try: self.prhost = prserv.serv.auto_start(self.data) except prserv.serv.PRServiceConfigError as e: - bb.fatal("Unable to start PR Server, exitting") + logger.error("Unable to start PR Server. Continuing anyway...") + self.prhost = None def enableDataTracking(self): self.configuration.tracking = True
On Tue, 2018-10-30 at 16:33 -0700, Joe Slater wrote: > Calls to bb.fatal() will block at this point of initialization. > > Signed-off-by: Joe Slater <joe.slater@windriver.com> > --- > lib/bb/cooker.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py > index 71a0eba..2a3721b 100644 > --- a/lib/bb/cooker.py > +++ b/lib/bb/cooker.py > @@ -383,7 +383,8 @@ class BBCooker: > try: > self.prhost = prserv.serv.auto_start(self.data) > except prserv.serv.PRServiceConfigError as e: > - bb.fatal("Unable to start PR Server, exitting") > + logger.error("Unable to start PR Server. Continuing anyway...") > + self.prhost = None > Shouldn't we fix the blocking? Cheers, Richard
Calls to bb.fatal() will block at this point of initialization. Signed-off-by: Joe Slater <joe.slater@windriver.com> --- lib/bb/cooker.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)