[RFC,meta-gnome,16/16] gnome-tweak-tool: add recipe for the GNOME Tweak tool

Submitted by brendank310 on Oct. 29, 2018, 4:41 p.m. | Patch ID: 155961

Details

Message ID dd28c909c895c7e30064a9646f5ccbde1414d3fa.1540830650.git.brendank310@gmail.com
State Changes Requested
Headers show

Commit Message

brendank310 Oct. 29, 2018, 4:41 p.m.
From: Brendan Kerrigan <kerriganb@ainfosec.com>

Signed-off-by:  Brendan Kerrigan <kerriganb@ainfosec.com>
---
 .../recipes-gnome/gnome3/gnome-tweaks_git.bb  | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb

Patch hide | download patch | download mbox

diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
new file mode 100644
index 000000000..fe305c922
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
@@ -0,0 +1,19 @@ 
+DESCRIPTION = "GNOME Tweaks"
+LICENSE = "GPLv2"
+DEPENDS = " \
+            gnome-shell \
+          "
+
+LIC_FILES_CHKSUM = "file://LICENSES/GPL-3.0;md5=9eef91148a9b14ec7f9df333daebc746"
+
+SRC_URI = "git://gitlab.gnome.org/GNOME/gnome-tweaks.git;protocol=http;branch=master;tag=3.30.1 \
+           "
+
+S = "${WORKDIR}/git"
+
+FILES_${PN} += "${libdir}"
+FILES_${PN} += "${datadir}"
+
+inherit pkgconfig meson gobject-introspection gettext
+
+

Comments

Andreas Müller Oct. 29, 2018, 11:09 p.m.
On Mon, Oct 29, 2018 at 5:42 PM brendank310 <brendank310@gmail.com> wrote:
>
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by:  Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
>  .../recipes-gnome/gnome3/gnome-tweaks_git.bb  | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
> new file mode 100644
> index 000000000..fe305c922
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
> @@ -0,0 +1,19 @@
> +DESCRIPTION = "GNOME Tweaks"
^ Maybe I have missed this in other patches: SUMMARY is default short
description
> +LICENSE = "GPLv2"
> +DEPENDS = " \
> +            gnome-shell \
> +          "
> +
> +LIC_FILES_CHKSUM = "file://LICENSES/GPL-3.0;md5=9eef91148a9b14ec7f9df333daebc746"
> +
> +SRC_URI = "git://gitlab.gnome.org/GNOME/gnome-tweaks.git;protocol=http;branch=master;tag=3.30.1 \
> +           "
> +
> +S = "${WORKDIR}/git"
> +
> +FILES_${PN} += "${libdir}"
> +FILES_${PN} += "${datadir}"
^ again libdir necessary? / one staetment / end of recipe
> +
> +inherit pkgconfig meson gobject-introspection gettext
> +
> +
> --
> 2.17.1
>
Khem Raj Oct. 30, 2018, 2:32 a.m.
On Mon, Oct 29, 2018 at 9:43 AM brendank310 <brendank310@gmail.com> wrote:

> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by:  Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
>  .../recipes-gnome/gnome3/gnome-tweaks_git.bb  | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
> b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
> new file mode 100644
> index 000000000..fe305c922
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/gnome-tweaks_git.bb
> @@ -0,0 +1,19 @@
> +DESCRIPTION = "GNOME Tweaks"
> +LICENSE = "GPLv2"


This seems should be GPL-3.0 as that’s what
Being checksummed few lines below

>
> +DEPENDS = " \
> +            gnome-shell \
> +          "
> +
> +LIC_FILES_CHKSUM =
> "file://LICENSES/GPL-3.0;md5=9eef91148a9b14ec7f9df333daebc746"
> +
> +SRC_URI = "git://
> gitlab.gnome.org/GNOME/gnome-tweaks.git;protocol=http;branch=master;tag=3.30.1
> \
> +           "
> +
> +S = "${WORKDIR}/git"
> +
> +FILES_${PN} += "${libdir}"
> +FILES_${PN} += "${datadir}"
> +
> +inherit pkgconfig meson gobject-introspection gettext
> +
> +
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
Ross Burton Oct. 30, 2018, 11:54 a.m.
On Tue, 30 Oct 2018 at 03:43, Khem Raj <raj.khem@gmail.com> wrote:
> > +LICENSE = "GPLv2"
> This seems should be GPL-3.0 as that’s what
> Being checksummed few lines below

> > +LIC_FILES_CHKSUM =
> > "file://LICENSES/GPL-3.0;md5=9eef91148a9b14ec7f9df333daebc746"

There's also a CCO license file in there which should be referred to
in LICENSE and checksummed.

Ross