[RFC,meta-gnome,14/16] packagegroup-gnome3-base: add packagegroup for installing gnome3/gnome-shell

Submitted by brendank310 on Oct. 29, 2018, 4:41 p.m. | Patch ID: 155959

Details

Message ID 9f5b028fdf90a7650a62e538889580dc31864a6b.1540830650.git.brendank310@gmail.com
State Changes Requested
Headers show

Commit Message

brendank310 Oct. 29, 2018, 4:41 p.m.
From: Brendan Kerrigan <kerriganb@ainfosec.com>

Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
 .../packagegroups/packagegroup-gnome3-base.bb | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb

Patch hide | download patch | download mbox

diff --git a/meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb b/meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb
new file mode 100644
index 000000000..8484087b8
--- /dev/null
+++ b/meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb
@@ -0,0 +1,27 @@ 
+SUMMARY = "All packages required for a base install of Gnome Shell"
+SECTION = "x11/wm"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"
+PR = "r0"
+
+inherit packagegroup distro_features_check
+
+REQUIRED_DISTRO_FEATURES = "x11"
+
+RDEPENDS_${PN} = " \
+    packagegroup-core-x11 \
+    xinit \
+    atk \
+    at-spi2-core \
+    at-spi2-atk \
+    cairo \
+    gnome-shell \
+    gnome-bluetooth \
+    upower \
+    pulseaudio \
+    librsvg \
+    ibus \
+    gnome-desktop3 \
+    accountsservice \
+    gnome-settings-daemon \
+"

Comments

Andreas Müller Oct. 29, 2018, 11:03 p.m.
On Mon, Oct 29, 2018 at 5:41 PM brendank310 <brendank310@gmail.com> wrote:
>
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
>  .../packagegroups/packagegroup-gnome3-base.bb | 27 +++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb
>
> diff --git a/meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb b/meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb
> new file mode 100644
> index 000000000..8484087b8
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/packagegroups/packagegroup-gnome3-base.bb
> @@ -0,0 +1,27 @@
> +SUMMARY = "All packages required for a base install of Gnome Shell"
> +SECTION = "x11/wm"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"
> +PR = "r0"
^ Please remove - we have auto-pr
> +
> +inherit packagegroup distro_features_check
> +
> +REQUIRED_DISTRO_FEATURES = "x11"
> +
> +RDEPENDS_${PN} = " \
> +    packagegroup-core-x11 \
> +    xinit \
> +    atk \
> +    at-spi2-core \
> +    at-spi2-atk \
> +    cairo \
> +    gnome-shell \
> +    gnome-bluetooth \
> +    upower \
> +    pulseaudio \
> +    librsvg \
> +    ibus \
> +    gnome-desktop3 \
> +    accountsservice \
> +    gnome-settings-daemon \
> +"
> --
> 2.17.1
>
Ross Burton Oct. 30, 2018, 11:32 a.m.
On Mon, 29 Oct 2018 at 16:43, brendank310 <brendank310@gmail.com> wrote:
> +inherit packagegroup distro_features_check
> +
> +REQUIRED_DISTRO_FEATURES = "x11"

Everyone running GNOME 3 on Wayland will be surprised by this.  This
packagegroup should be *just* GNOME and then the image using it can
decide whether to pull in X11 or Weston.

Ross
Ross Burton Oct. 30, 2018, noon
On Mon, 29 Oct 2018 at 16:43, brendank310 <brendank310@gmail.com> wrote:
> +LICENSE = "MIT"

Implied by packagegroup.bbclass.

> +LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"

Not required.

> +RDEPENDS_${PN} = " \
> +    packagegroup-core-x11 \
> +    xinit \
> +    atk \
> +    at-spi2-core \
> +    at-spi2-atk \
> +    cairo \
> +    gnome-shell \
> +    gnome-bluetooth \
> +    upower \
> +    pulseaudio \
> +    librsvg \
> +    ibus \
> +    gnome-desktop3 \
> +    accountsservice \
> +    gnome-settings-daemon \
> +"

A large proportion of those are libraries that will be pulled in
automatically (atk, cairo, librsvg, etc).  These can be removed.

Ross