[RFC,meta-gnome,09/16] gdm: add recipe for gdm (Gnome Desktop Manager)

Submitted by brendank310 on Oct. 29, 2018, 4:41 p.m. | Patch ID: 155954

Details

Message ID 245bf6e59b04956ad91357d74a93c4ecd5326faf.1540830650.git.brendank310@gmail.com
State Changes Requested
Headers show

Commit Message

brendank310 Oct. 29, 2018, 4:41 p.m.
From: Brendan Kerrigan <kerriganb@ainfosec.com>

Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
 meta-gnome/recipes-gnome/gnome3/gdm_git.bb | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 meta-gnome/recipes-gnome/gnome3/gdm_git.bb

Patch hide | download patch | download mbox

diff --git a/meta-gnome/recipes-gnome/gnome3/gdm_git.bb b/meta-gnome/recipes-gnome/gnome3/gdm_git.bb
new file mode 100644
index 000000000..752aad13e
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/gdm_git.bb
@@ -0,0 +1,33 @@ 
+DESCRIPTION = "GNOME Desktop Manager"
+LICENSE = "GPLv2"
+DEPENDS = " \
+           libcanberra \
+           glib-2.0 \
+           gtk+3 \
+           accountsservice \
+           plymouth \
+           gconf-native \
+           dconf-native \
+          "
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+
+SRC_URI = "git://gitlab.gnome.org/GNOME/gdm.git;protocol=http;branch=master;tag=3.30.1 \
+           "
+
+S = "${WORKDIR}/git"
+
+inherit autotools pkgconfig distro_features_check gobject-introspection gettext
+
+FILES_${PN} += "${systemd_system_unitdir}"
+FILES_${PN} += "${libdir}"
+FILES_${PN} += "${datadir}"
+
+do_configure_prepend() {
+	install -d ${S}/build-aux
+	sed -i '/AC_CHECK_FILE/d' ${S}/configure.ac
+}
+
+do_install_append() {
+	rm -rf ${D}/var/run
+}

Comments

Andreas Müller Oct. 29, 2018, 10:51 p.m.
On Mon, Oct 29, 2018 at 5:41 PM brendank310 <brendank310@gmail.com> wrote:
>
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
>  meta-gnome/recipes-gnome/gnome3/gdm_git.bb | 33 ++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 meta-gnome/recipes-gnome/gnome3/gdm_git.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/gdm_git.bb b/meta-gnome/recipes-gnome/gnome3/gdm_git.bb
> new file mode 100644
> index 000000000..752aad13e
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/gdm_git.bb
> @@ -0,0 +1,33 @@
> +DESCRIPTION = "GNOME Desktop Manager"
> +LICENSE = "GPLv2"
> +DEPENDS = " \
> +           libcanberra \
> +           glib-2.0 \
> +           gtk+3 \
> +           accountsservice \
> +           plymouth \
> +           gconf-native \
> +           dconf-native \
> +          "
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +
> +SRC_URI = "git://gitlab.gnome.org/GNOME/gdm.git;protocol=http;branch=master;tag=3.30.1 \
> +           "
> +
> +S = "${WORKDIR}/git"
> +
> +inherit autotools pkgconfig distro_features_check gobject-introspection gettext
> +
> +FILES_${PN} += "${systemd_system_unitdir}"
> +FILES_${PN} += "${libdir}"
> +FILES_${PN} += "${datadir}"
^ Same as mentioned before
> +
> +do_configure_prepend() {
> +       install -d ${S}/build-aux
> +       sed -i '/AC_CHECK_FILE/d' ${S}/configure.ac
> +}
> +
> +do_install_append() {
> +       rm -rf ${D}/var/run
> +}
> --
> 2.17.1
>
Ross Burton Oct. 30, 2018, 11:33 a.m.
On Mon, 29 Oct 2018 at 16:42, brendank310 <brendank310@gmail.com> wrote:
> +SRC_URI = "git://gitlab.gnome.org/GNOME/gdm.git;protocol=http;branch=master;tag=3.30.1 \

Tarball.

> +FILES_${PN} += "${systemd_system_unitdir}"

Use systemd class.

> +FILES_${PN} += "${libdir}"

Breaks library packaging.

> +do_configure_prepend() {
> +       install -d ${S}/build-aux
> +       sed -i '/AC_CHECK_FILE/d' ${S}/configure.ac

Why?  If this is needed then do it as a patch.

Ross