[RFC,meta-gnome,08/16] libgweather: add recipe for libgweather

Submitted by brendank310 on Oct. 29, 2018, 4:41 p.m. | Patch ID: 155953

Details

Message ID 950a5e000cdf171ed8bce8d574a7f7d4b91c1fb7.1540830650.git.brendank310@gmail.com
State Changes Requested
Headers show

Commit Message

brendank310 Oct. 29, 2018, 4:41 p.m.
From: Brendan Kerrigan <kerriganb@ainfosec.com>

Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
 .../recipes-gnome/gnome3/libgweather_git.bb   | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 meta-gnome/recipes-gnome/gnome3/libgweather_git.bb

Patch hide | download patch | download mbox

diff --git a/meta-gnome/recipes-gnome/gnome3/libgweather_git.bb b/meta-gnome/recipes-gnome/gnome3/libgweather_git.bb
new file mode 100644
index 000000000..29ee2c90d
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/libgweather_git.bb
@@ -0,0 +1,23 @@ 
+DESCRIPTION = "GNOME Weather Library"
+LICENSE = "GPLv2"
+DEPENDS = " \
+           gtk+3 \
+           glib-2.0 \
+           libsoup-2.4 \
+           libxml2 \
+           geocode-glib \
+          "
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
+
+SRC_URI = "git://gitlab.gnome.org/GNOME/libgweather.git;protocol=http;branch=gnome-3-28 \
+           "
+
+FILES_${PN} += "${datadir}"
+FILES_${PN} += "${libdir}"
+
+SRCREV="${AUTOREV}"
+S = "${WORKDIR}/git"
+
+inherit pkgconfig meson gobject-introspection
+

Comments

Khem Raj Oct. 30, 2018, 2:49 a.m.
On Mon, Oct 29, 2018 at 9:42 AM brendank310 <brendank310@gmail.com> wrote:

> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
>  .../recipes-gnome/gnome3/libgweather_git.bb   | 23 +++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 meta-gnome/recipes-gnome/gnome3/libgweather_git.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/libgweather_git.bb
> b/meta-gnome/recipes-gnome/gnome3/libgweather_git.bb
> new file mode 100644
> index 000000000..29ee2c90d
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/libgweather_git.bb
> @@ -0,0 +1,23 @@
> +DESCRIPTION = "GNOME Weather Library"
> +LICENSE = "GPLv2"
> +DEPENDS = " \
> +           gtk+3 \
> +           glib-2.0 \
> +           libsoup-2.4 \
> +           libxml2 \
> +           geocode-glib \
> +          "
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> +
> +SRC_URI = "git://
> gitlab.gnome.org/GNOME/libgweather.git;protocol=http;branch=gnome-3-28 \
> +           "
> +
> +FILES_${PN} += "${datadir}"
> +FILES_${PN} += "${libdir}"
> +


Does is make sense to package these libraries separately? I ask because if
they are used by other packages then it will not need to pull whole package


> +SRCREV="${AUTOREV}"
> +S = "${WORKDIR}/git"
> +
> +inherit pkgconfig meson gobject-introspection
> +
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
Ross Burton Oct. 30, 2018, 11:18 a.m.
On Mon, 29 Oct 2018 at 16:42, brendank310 <brendank310@gmail.com> wrote:
> +SRC_URI = "git://gitlab.gnome.org/GNOME/libgweather.git;protocol=http;branch=gnome-3-28 \

Why not tarball (small, checksumed, easier to mirror)

> +FILES_${PN} += "${libdir}"

This breaks library packaging.

> +SRCREV="${AUTOREV}"

Never use this in mainline recipes.

Ross