[RFC,meta-gnome,05/16] lcms2: add recipe for Little Color Management System

Submitted by brendank310 on Oct. 29, 2018, 4:41 p.m. | Patch ID: 155950

Details

Message ID 068fb23bf91af2a10eacc81156dc72dfb5d8ee79.1540830650.git.brendank310@gmail.com
State Changes Requested
Headers show

Commit Message

brendank310 Oct. 29, 2018, 4:41 p.m.
From: Brendan Kerrigan <kerriganb@ainfosec.com>

Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
---
 meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb

Patch hide | download patch | download mbox

diff --git a/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb b/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
new file mode 100644
index 000000000..29947ae76
--- /dev/null
+++ b/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
@@ -0,0 +1,14 @@ 
+DESCRIPTION = "Little Color Management System"
+LICENSE = "MIT"
+#DEPENDS = " glib-2.0 gettext-native "
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=6c786c3b7a4afbd3c990f1b81261d516"
+
+SRC_URI = "https://sourceforge.net/projects/lcms/files/lcms/${PV}/${PN}-${PV}.tar.gz \
+           "
+
+SRC_URI[md5sum] = "8de1b7724f578d2995c8fdfa35c3ad0e"
+SRC_URI[sha256sum] = "48c6fdf98396fa245ed86e622028caf49b96fa22f3e5734f853f806fbc8e7d20"
+
+inherit autotools pkgconfig distro_features_check 
+

Comments

Andreas Müller Oct. 29, 2018, 10:46 p.m.
On Mon, Oct 29, 2018 at 5:41 PM brendank310 <brendank310@gmail.com> wrote:
>
> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
>  meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb b/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
> new file mode 100644
> index 000000000..29947ae76
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
> @@ -0,0 +1,14 @@
> +DESCRIPTION = "Little Color Management System"
> +LICENSE = "MIT"
> +#DEPENDS = " glib-2.0 gettext-native "
> +
> +LIC_FILES_CHKSUM = "file://COPYING;md5=6c786c3b7a4afbd3c990f1b81261d516"
> +
> +SRC_URI = "https://sourceforge.net/projects/lcms/files/lcms/${PV}/${PN}-${PV}.tar.gz \
> +           "
> +
> +SRC_URI[md5sum] = "8de1b7724f578d2995c8fdfa35c3ad0e"
> +SRC_URI[sha256sum] = "48c6fdf98396fa245ed86e622028caf49b96fa22f3e5734f853f806fbc8e7d20"
> +
> +inherit autotools pkgconfig distro_features_check
> +
There is a lcms 2.7 in meta-oe - what about upddating that?
Khem Raj Oct. 30, 2018, 2:41 a.m.
On Mon, Oct 29, 2018 at 9:42 AM brendank310 <brendank310@gmail.com> wrote:

> From: Brendan Kerrigan <kerriganb@ainfosec.com>
>
> Signed-off-by: Brendan Kerrigan <kerriganb@ainfosec.com>
> ---
>  meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>  create mode 100644 meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
>
> diff --git a/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
> b/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
> new file mode 100644
> index 000000000..29947ae76
> --- /dev/null
> +++ b/meta-gnome/recipes-gnome/gnome3/lcms2_2.9.bb
> @@ -0,0 +1,14 @@
> +DESCRIPTION = "Little Color Management System"
> +LICENSE = "MIT"
> +#DEPENDS = " glib-2.0 gettext-native "
> +


We can delete this if commented out

>
> +LIC_FILES_CHKSUM = "file://COPYING;md5=6c786c3b7a4afbd3c990f1b81261d516"
> +
> +SRC_URI = "
> https://sourceforge.net/projects/lcms/files/lcms/${PV}/${PN}-${PV}.tar.gz
> \
> +           "
> +
> +SRC_URI[md5sum] = "8de1b7724f578d2995c8fdfa35c3ad0e"
> +SRC_URI[sha256sum] =
> "48c6fdf98396fa245ed86e622028caf49b96fa22f3e5734f853f806fbc8e7d20"
> +
> +inherit autotools pkgconfig distro_features_check
> +
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
Ross Burton Oct. 30, 2018, 11:22 a.m.
On Mon, 29 Oct 2018 at 16:42, brendank310 <brendank310@gmail.com> wrote:
> +inherit autotools pkgconfig distro_features_check

distro_features_check isn't being used.

But mainly, just update the existing recipe.

Ross
brendank310 Oct. 30, 2018, 3:03 p.m.
Sounds good, I hadn't seen that. Should the existing lcms recipe be renamed
to lcms2? Most distros seem to package it as such and it'd also simplify
the recipe a bit (the PN would align with the tarball and source directory
name).

On Tue, Oct 30, 2018 at 7:23 AM Burton, Ross <ross.burton@intel.com> wrote:

> On Mon, 29 Oct 2018 at 16:42, brendank310 <brendank310@gmail.com> wrote:
> > +inherit autotools pkgconfig distro_features_check
>
> distro_features_check isn't being used.
>
> But mainly, just update the existing recipe.
>
> Ross
>
Khem Raj Oct. 30, 2018, 9:07 p.m.
On Tue, Oct 30, 2018 at 9:04 AM Brendan Kerrigan <brendank310@gmail.com> wrote:
>
> Sounds good, I hadn't seen that. Should the existing lcms recipe be renamed
> to lcms2? Most distros seem to package it as such and it'd also simplify
> the recipe a bit (the PN would align with the tarball and source directory
> name).
>

as long as we maintain upgrade path for binary feeds I would think its ok.

> On Tue, Oct 30, 2018 at 7:23 AM Burton, Ross <ross.burton@intel.com> wrote:
>
> > On Mon, 29 Oct 2018 at 16:42, brendank310 <brendank310@gmail.com> wrote:
> > > +inherit autotools pkgconfig distro_features_check
> >
> > distro_features_check isn't being used.
> >
> > But mainly, just update the existing recipe.
> >
> > Ross
> >
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Andreas Müller Oct. 30, 2018, 11:08 p.m.
On Tue, Oct 30, 2018 at 4:04 PM Brendan Kerrigan <brendank310@gmail.com> wrote:
>
> Sounds good, I hadn't seen that. Should the existing lcms recipe be renamed to lcms2? Most distros seem to package it as such and it'd also simplify the recipe a bit (the PN would align with the tarball and source directory name).
>
If you want ro rename don't forget to set PROVIDES / RRPROVIDES /
RREPLACES / RCONFLICTS - otherwise you break recipes depending on lcms
(there are many) or package feeds. I wouldn't do that.

Andreas