[meta-oe,2/5] vlc: add x11 to REQUIRED_DISTRO_FEATURES

Submitted by Armin Kuster on Oct. 12, 2018, 3:26 p.m. | Patch ID: 155629

Details

Message ID 1539357981-3675-3-git-send-email-akuster808@gmail.com
State Changes Requested
Headers show

Commit Message

Armin Kuster Oct. 12, 2018, 3:26 p.m.
Nothing PROVIDES gtk+

Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 meta-multimedia/recipes-multimedia/vlc/vlc.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
index f13c0ea..e395b24 100644
--- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
+++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
@@ -19,6 +19,8 @@  LICENSE_FLAGS = "commercial"
 SRC_URI = "http://download.videolan.org/pub/videolan/${BPN}/${PV}/${BP}.tar.xz"
 
 inherit autotools gettext pkgconfig distro_features_check
+#REQUIRED_DISTRO_FEATURES = "x11"
+
 
 ARM_INSTRUCTION_SET = "arm"
 
@@ -40,7 +42,7 @@  EXTRA_OECONF = "\
     ac_cv_path_UIC=${STAGING_BINDIR_NATIVE}/uic4 \
 "
 
-PACKAGECONFIG ?= " live555 dc1394 dv1394 notify fontconfig freetype dvdread png ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 sdl vdpau', '', d)}"
+PACKAGECONFIG ?= " live555 dc1394 dv1394 fontconfig freetype dvdread png ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 sdl vdpau notify', '', d)}"
 PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
 PACKAGECONFIG[sdl] = "--enable-sdl,--disable-sdl,virtual/libsdl libsdl-image "
 PACKAGECONFIG[a52] = "--enable-a52,--disable-a52,liba52"

Comments

Khem Raj Oct. 12, 2018, 3:29 p.m.
Hi Armin

On Fri, Oct 12, 2018 at 8:27 AM Armin Kuster <akuster808@gmail.com> wrote:
>
> Nothing PROVIDES gtk+
>

Commit message and code changes seems to not matching

> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
>  meta-multimedia/recipes-multimedia/vlc/vlc.inc | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta-multimedia/recipes-multimedia/vlc/vlc.inc b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> index f13c0ea..e395b24 100644
> --- a/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> +++ b/meta-multimedia/recipes-multimedia/vlc/vlc.inc
> @@ -19,6 +19,8 @@ LICENSE_FLAGS = "commercial"
>  SRC_URI = "http://download.videolan.org/pub/videolan/${BPN}/${PV}/${BP}.tar.xz"
>
>  inherit autotools gettext pkgconfig distro_features_check
> +#REQUIRED_DISTRO_FEATURES = "x11"
> +
>
>  ARM_INSTRUCTION_SET = "arm"
>
> @@ -40,7 +42,7 @@ EXTRA_OECONF = "\
>      ac_cv_path_UIC=${STAGING_BINDIR_NATIVE}/uic4 \
>  "
>
> -PACKAGECONFIG ?= " live555 dc1394 dv1394 notify fontconfig freetype dvdread png ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 sdl vdpau', '', d)}"
> +PACKAGECONFIG ?= " live555 dc1394 dv1394 fontconfig freetype dvdread png ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11 sdl vdpau notify', '', d)}"
>  PACKAGECONFIG[mad] = "--enable-mad,--disable-mad,libmad"
>  PACKAGECONFIG[sdl] = "--enable-sdl,--disable-sdl,virtual/libsdl libsdl-image "
>  PACKAGECONFIG[a52] = "--enable-a52,--disable-a52,liba52"
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel