mesa: Disable asm on musl

Submitted by Khem Raj on Oct. 2, 2018, 7:11 p.m. | Patch ID: 155378

Details

Message ID 20181002191136.8792-1-raj.khem@gmail.com
State Master Next
Commit 2f03da66d370c95f3b7002b5252e1126689adb8f
Headers show

Commit Message

Khem Raj Oct. 2, 2018, 7:11 p.m.
some unknown part of mesa's x86 assembly
code is broken by readonly text segments

[ YOCTO #12918 ]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-graphics/mesa/mesa.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
index 8d0e2cb67c..e6f3712706 100644
--- a/meta/recipes-graphics/mesa/mesa.inc
+++ b/meta/recipes-graphics/mesa/mesa.inc
@@ -107,7 +107,7 @@  PACKAGECONFIG[osmesa] = "--enable-${OSMESA},--disable-${OSMESA}"
 PACKAGECONFIG[unwind] = "--enable-libunwind,--disable-libunwind,libunwind"
 
 EXTRA_OECONF_remove_libc-musl = "--enable-glx-tls"
-EXTRA_OECONF_append_libc-musl = " --disable-glx-tls"
+EXTRA_OECONF_append_libc-musl = " --disable-asm --disable-glx-tls"
 # llvmpipe is slow if compiled with -fomit-frame-pointer (e.g. -O2)
 FULL_OPTIMIZATION_append = " -fno-omit-frame-pointer"
 

Comments

Ross Burton Oct. 2, 2018, 7:27 p.m.
Isn't this a bit overkill?  Is the assembler actually broken?

Ross
On Tue, 2 Oct 2018 at 20:21, Khem Raj <raj.khem@gmail.com> wrote:
>
> some unknown part of mesa's x86 assembly
> code is broken by readonly text segments
>
> [ YOCTO #12918 ]
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-graphics/mesa/mesa.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
> index 8d0e2cb67c..e6f3712706 100644
> --- a/meta/recipes-graphics/mesa/mesa.inc
> +++ b/meta/recipes-graphics/mesa/mesa.inc
> @@ -107,7 +107,7 @@ PACKAGECONFIG[osmesa] = "--enable-${OSMESA},--disable-${OSMESA}"
>  PACKAGECONFIG[unwind] = "--enable-libunwind,--disable-libunwind,libunwind"
>
>  EXTRA_OECONF_remove_libc-musl = "--enable-glx-tls"
> -EXTRA_OECONF_append_libc-musl = " --disable-glx-tls"
> +EXTRA_OECONF_append_libc-musl = " --disable-asm --disable-glx-tls"
>  # llvmpipe is slow if compiled with -fomit-frame-pointer (e.g. -O2)
>  FULL_OPTIMIZATION_append = " -fno-omit-frame-pointer"
>
> --
> 2.19.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj Oct. 2, 2018, 7:37 p.m.
I think it is. The way th calls are set for performance reasons seems to be
causing this
Ideally we should ensure to use right dialect for  tls calls I think musl
is exposing a bug in Mesa
Which we covered by disabling tls in Glx once we disable that then this
problem pops up so we disable ASM

So this is a workaround until then

On Tue, Oct 2, 2018 at 12:28 PM Burton, Ross <ross.burton@intel.com> wrote:

> Isn't this a bit overkill?  Is the assembler actually broken?
>
> Ross
> On Tue, 2 Oct 2018 at 20:21, Khem Raj <raj.khem@gmail.com> wrote:
> >
> > some unknown part of mesa's x86 assembly
> > code is broken by readonly text segments
> >
> > [ YOCTO #12918 ]
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta/recipes-graphics/mesa/mesa.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-graphics/mesa/mesa.inc
> b/meta/recipes-graphics/mesa/mesa.inc
> > index 8d0e2cb67c..e6f3712706 100644
> > --- a/meta/recipes-graphics/mesa/mesa.inc
> > +++ b/meta/recipes-graphics/mesa/mesa.inc
> > @@ -107,7 +107,7 @@ PACKAGECONFIG[osmesa] =
> "--enable-${OSMESA},--disable-${OSMESA}"
> >  PACKAGECONFIG[unwind] =
> "--enable-libunwind,--disable-libunwind,libunwind"
> >
> >  EXTRA_OECONF_remove_libc-musl = "--enable-glx-tls"
> > -EXTRA_OECONF_append_libc-musl = " --disable-glx-tls"
> > +EXTRA_OECONF_append_libc-musl = " --disable-asm --disable-glx-tls"
> >  # llvmpipe is slow if compiled with -fomit-frame-pointer (e.g. -O2)
> >  FULL_OPTIMIZATION_append = " -fno-omit-frame-pointer"
> >
> > --
> > 2.19.0
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
Ross Burton Oct. 2, 2018, 8:42 p.m.
Can you file a bug with mesa so we don't forget and Mesa knows?

Ross
On Tue, 2 Oct 2018 at 20:37, Khem Raj <raj.khem@gmail.com> wrote:
>
> I think it is. The way th calls are set for performance reasons seems to be causing this
> Ideally we should ensure to use right dialect for  tls calls I think musl is exposing a bug in Mesa
> Which we covered by disabling tls in Glx once we disable that then this problem pops up so we disable ASM
>
> So this is a workaround until then
>
> On Tue, Oct 2, 2018 at 12:28 PM Burton, Ross <ross.burton@intel.com> wrote:
>>
>> Isn't this a bit overkill?  Is the assembler actually broken?
>>
>> Ross
>> On Tue, 2 Oct 2018 at 20:21, Khem Raj <raj.khem@gmail.com> wrote:
>> >
>> > some unknown part of mesa's x86 assembly
>> > code is broken by readonly text segments
>> >
>> > [ YOCTO #12918 ]
>> >
>> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> > ---
>> >  meta/recipes-graphics/mesa/mesa.inc | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
>> > index 8d0e2cb67c..e6f3712706 100644
>> > --- a/meta/recipes-graphics/mesa/mesa.inc
>> > +++ b/meta/recipes-graphics/mesa/mesa.inc
>> > @@ -107,7 +107,7 @@ PACKAGECONFIG[osmesa] = "--enable-${OSMESA},--disable-${OSMESA}"
>> >  PACKAGECONFIG[unwind] = "--enable-libunwind,--disable-libunwind,libunwind"
>> >
>> >  EXTRA_OECONF_remove_libc-musl = "--enable-glx-tls"
>> > -EXTRA_OECONF_append_libc-musl = " --disable-glx-tls"
>> > +EXTRA_OECONF_append_libc-musl = " --disable-asm --disable-glx-tls"
>> >  # llvmpipe is slow if compiled with -fomit-frame-pointer (e.g. -O2)
>> >  FULL_OPTIMIZATION_append = " -fno-omit-frame-pointer"
>> >
>> > --
>> > 2.19.0
>> >
>> > --
>> > _______________________________________________
>> > Openembedded-core mailing list
>> > Openembedded-core@lists.openembedded.org
>> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj Oct. 2, 2018, 8:58 p.m.
Yes, will do. I think it will need some time since this needs to be
well explained so mesa devs can see the reasoning behind it
On Tue, Oct 2, 2018 at 1:42 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> Can you file a bug with mesa so we don't forget and Mesa knows?
>
> Ross
> On Tue, 2 Oct 2018 at 20:37, Khem Raj <raj.khem@gmail.com> wrote:
> >
> > I think it is. The way th calls are set for performance reasons seems to be causing this
> > Ideally we should ensure to use right dialect for  tls calls I think musl is exposing a bug in Mesa
> > Which we covered by disabling tls in Glx once we disable that then this problem pops up so we disable ASM
> >
> > So this is a workaround until then
> >
> > On Tue, Oct 2, 2018 at 12:28 PM Burton, Ross <ross.burton@intel.com> wrote:
> >>
> >> Isn't this a bit overkill?  Is the assembler actually broken?
> >>
> >> Ross
> >> On Tue, 2 Oct 2018 at 20:21, Khem Raj <raj.khem@gmail.com> wrote:
> >> >
> >> > some unknown part of mesa's x86 assembly
> >> > code is broken by readonly text segments
> >> >
> >> > [ YOCTO #12918 ]
> >> >
> >> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> > ---
> >> >  meta/recipes-graphics/mesa/mesa.inc | 2 +-
> >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
> >> > index 8d0e2cb67c..e6f3712706 100644
> >> > --- a/meta/recipes-graphics/mesa/mesa.inc
> >> > +++ b/meta/recipes-graphics/mesa/mesa.inc
> >> > @@ -107,7 +107,7 @@ PACKAGECONFIG[osmesa] = "--enable-${OSMESA},--disable-${OSMESA}"
> >> >  PACKAGECONFIG[unwind] = "--enable-libunwind,--disable-libunwind,libunwind"
> >> >
> >> >  EXTRA_OECONF_remove_libc-musl = "--enable-glx-tls"
> >> > -EXTRA_OECONF_append_libc-musl = " --disable-glx-tls"
> >> > +EXTRA_OECONF_append_libc-musl = " --disable-asm --disable-glx-tls"
> >> >  # llvmpipe is slow if compiled with -fomit-frame-pointer (e.g. -O2)
> >> >  FULL_OPTIMIZATION_append = " -fno-omit-frame-pointer"
> >> >
> >> > --
> >> > 2.19.0
> >> >
> >> > --
> >> > _______________________________________________
> >> > Openembedded-core mailing list
> >> > Openembedded-core@lists.openembedded.org
> >> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
Paul Eggleton Oct. 2, 2018, 9:19 p.m.
Can we have bit more detail in the commit message about what the issues are? 
We're not supposed to rely solely on a bug report reference to do that; also 
if it's considered a workaround and we're working with upstream to fix it, the 
commit message should state that as well.

Thanks
Paul

On Wednesday, 3 October 2018 8:37:10 AM NZDT Khem Raj wrote:
> I think it is. The way th calls are set for performance reasons seems to be
> causing this
> Ideally we should ensure to use right dialect for  tls calls I think musl
> is exposing a bug in Mesa
> Which we covered by disabling tls in Glx once we disable that then this
> problem pops up so we disable ASM
> 
> So this is a workaround until then
> 
> On Tue, Oct 2, 2018 at 12:28 PM Burton, Ross <ross.burton@intel.com> wrote:
> 
> > Isn't this a bit overkill?  Is the assembler actually broken?
> >
> > Ross
> > On Tue, 2 Oct 2018 at 20:21, Khem Raj <raj.khem@gmail.com> wrote:
> > >
> > > some unknown part of mesa's x86 assembly
> > > code is broken by readonly text segments
> > >
> > > [ YOCTO #12918 ]
> > >
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > ---
> > >  meta/recipes-graphics/mesa/mesa.inc | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-graphics/mesa/mesa.inc
> > b/meta/recipes-graphics/mesa/mesa.inc
> > > index 8d0e2cb67c..e6f3712706 100644
> > > --- a/meta/recipes-graphics/mesa/mesa.inc
> > > +++ b/meta/recipes-graphics/mesa/mesa.inc
> > > @@ -107,7 +107,7 @@ PACKAGECONFIG[osmesa] =
> > "--enable-${OSMESA},--disable-${OSMESA}"
> > >  PACKAGECONFIG[unwind] =
> > "--enable-libunwind,--disable-libunwind,libunwind"
> > >
> > >  EXTRA_OECONF_remove_libc-musl = "--enable-glx-tls"
> > > -EXTRA_OECONF_append_libc-musl = " --disable-glx-tls"
> > > +EXTRA_OECONF_append_libc-musl = " --disable-asm --disable-glx-tls"
> > >  # llvmpipe is slow if compiled with -fomit-frame-pointer (e.g. -O2)
> > >  FULL_OPTIMIZATION_append = " -fno-omit-frame-pointer"
> > >
> > > --
> > > 2.19.0
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-core mailing list
> > > Openembedded-core@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
>
Khem Raj Oct. 3, 2018, 10:40 a.m.
This is a system generated Comment: Patch 155378 was automatically marked as superseded by patch 155383.