Revert "cpan.bbclass: adopt to recent EU::MM"

Submitted by Khem Raj on Aug. 24, 2018, 8:07 a.m. | Patch ID: 154228

Details

Message ID 20180824080738.6061-1-raj.khem@gmail.com
State Master Next
Commit e89ce96d53b97ce3b5e08bd6c1b7650f7c456a60
Headers show

Commit Message

Khem Raj Aug. 24, 2018, 8:07 a.m.
This reverts commit 2e61533e7c1b1cfd49dc771e907207f11a15c44f.
---
 meta/classes/cpan.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/meta/classes/cpan.bbclass b/meta/classes/cpan.bbclass
index 926c6358a6..8e079e0d55 100644
--- a/meta/classes/cpan.bbclass
+++ b/meta/classes/cpan.bbclass
@@ -16,7 +16,8 @@  export PERL_ARCHLIB = "${STAGING_LIBDIR}${PERL_OWN_DIR}/perl/${@get_perl_version
 export PERLHOSTLIB = "${STAGING_LIBDIR_NATIVE}/perl-native/perl/${@get_perl_version(d)}/"
 
 cpan_do_configure () {
-	yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor NO_PERLLOCAL=1 NO_PACKLIST=1 ${EXTRA_CPANFLAGS}
+	export PERL5LIB="${PERL_ARCHLIB}"
+	yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor ${EXTRA_CPANFLAGS}
 
 	# Makefile.PLs can exit with success without generating a
 	# Makefile, e.g. in cases of missing configure time

Comments

Jens Rehsack Aug. 28, 2018, 7:21 a.m.
> Am 24.08.2018 um 10:07 schrieb Khem Raj <raj.khem@gmail.com>:
> 
> This reverts commit 2e61533e7c1b1cfd49dc771e907207f11a15c44f.
> ---
> meta/classes/cpan.bbclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/cpan.bbclass b/meta/classes/cpan.bbclass
> index 926c6358a6..8e079e0d55 100644
> --- a/meta/classes/cpan.bbclass
> +++ b/meta/classes/cpan.bbclass
> @@ -16,7 +16,8 @@ export PERL_ARCHLIB = "${STAGING_LIBDIR}${PERL_OWN_DIR}/perl/${@get_perl_version
> export PERLHOSTLIB = "${STAGING_LIBDIR_NATIVE}/perl-native/perl/${@get_perl_version(d)}/"
> 
> cpan_do_configure () {
> -	yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor NO_PERLLOCAL=1 NO_PACKLIST=1 ${EXTRA_CPANFLAGS}
> +	export PERL5LIB="${PERL_ARCHLIB}"
> +	yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor ${EXTRA_CPANFLAGS}
> 
> 	# Makefile.PLs can exit with success without generating a
> 	# Makefile, e.g. in cases of missing configure time
> --
> 2.18.0
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


This one shouldn't get tested together with
   2387c0d3 cpan.bbclass: make RPATH fix more general
since the hacked PERL5LIB="${PERL_ARCHLIB}" hides the broken RPATH
behavior.
--
Jens Rehsack - rehsack@gmail.com
Khem Raj Aug. 28, 2018, 3:16 p.m.
On Tue, Aug 28, 2018 at 12:21 AM Jens Rehsack <rehsack@gmail.com> wrote:

>
>
> Am 24.08.2018 um 10:07 schrieb Khem Raj <raj.khem@gmail.com>:
>
> This reverts commit 2e61533e7c1b1cfd49dc771e907207f11a15c44f.
> ---
> meta/classes/cpan.bbclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/cpan.bbclass b/meta/classes/cpan.bbclass
> index 926c6358a6..8e079e0d55 100644
> --- a/meta/classes/cpan.bbclass
> +++ b/meta/classes/cpan.bbclass
> @@ -16,7 +16,8 @@ export PERL_ARCHLIB =
> "${STAGING_LIBDIR}${PERL_OWN_DIR}/perl/${@get_perl_version
> export PERLHOSTLIB =
> "${STAGING_LIBDIR_NATIVE}/perl-native/perl/${@get_perl_version(d)}/"
>
> cpan_do_configure () {
> - yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor
> NO_PERLLOCAL=1 NO_PACKLIST=1 ${EXTRA_CPANFLAGS}
> + export PERL5LIB="${PERL_ARCHLIB}"
> + yes '' | perl ${EXTRA_PERLFLAGS} Makefile.PL INSTALLDIRS=vendor
> ${EXTRA_CPANFLAGS}
>
> # Makefile.PLs can exit with success without generating a
> # Makefile, e.g. in cases of missing configure time
> --
> 2.18.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
> This one shouldn't get tested together with
>    2387c0d3 cpan.bbclass: make RPATH fix more general
> since the hacked PERL5LIB="${PERL_ARCHLIB}" hides the broken RPATH
> behavior.
>

Yes it won’t this was actsully meant for master-next only

> --
> Jens Rehsack - rehsack@gmail.com
>
>
Richard Purdie Aug. 28, 2018, 3:32 p.m.
Hi Khem,

I put the alternative fix into master as it passed OE-Core testing.
Could you see how the perl failures are looking in meta-oe now please?

Cheers,

Richard