[meta-oe] lvm2-udevrules: Add ALLOW_EMPTY

Submitted by Ovidiu Panait on July 31, 2018, 10:40 a.m. | Patch ID: 153204

Details

Message ID 1533033627-32108-1-git-send-email-ovidiu.panait@windriver.com
State Under Review
Headers show

Commit Message

Ovidiu Panait July 31, 2018, 10:40 a.m.
When lvm2 is configured without udev feature, the lvm2-udevrules package
is empty, so do_rootfs will fail to install any other packages that
rdepend on it. (e.g. cryptsetup with meta-secure-core layer since commit
https://github.com/jiazhang0/meta-secure-core/commit/afc3939):

..
Problem: conflicting requests
 - nothing provides lvm2-udevrules needed by cryptsetup
..

Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
---
 meta-oe/recipes-support/lvm2/lvm2_2.02.177.bb | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/meta-oe/recipes-support/lvm2/lvm2_2.02.177.bb b/meta-oe/recipes-support/lvm2/lvm2_2.02.177.bb
index 1d9de3d94..388e89117 100644
--- a/meta-oe/recipes-support/lvm2/lvm2_2.02.177.bb
+++ b/meta-oe/recipes-support/lvm2/lvm2_2.02.177.bb
@@ -46,6 +46,7 @@  FILES_${PN}-scripts = " \
 # Specified explicitly for the udev rules, just in case that it does not get picked
 # up automatically:
 FILES_${PN}-udevrules = "${nonarch_base_libdir}/udev/rules.d"
+ALLOW_EMPTY_${PN}-udevrules = "1"
 RDEPENDS_${PN}_append_class-target = " libdevmapper"
 RDEPENDS_${PN}_append_class-nativesdk = " libdevmapper"
 

Comments

Khem Raj Aug. 2, 2018, 8:18 a.m.
On Tue, Jul 31, 2018 at 3:50 AM Ovidiu Panait
<ovidiu.panait@windriver.com> wrote:
>
> When lvm2 is configured without udev feature, the lvm2-udevrules package
> is empty, so do_rootfs will fail to install any other packages that
> rdepend on it. (e.g. cryptsetup with meta-secure-core layer since commit
> https://github.com/jiazhang0/meta-secure-core/commit/afc3939):
>
> ..
> Problem: conflicting requests
>  - nothing provides lvm2-udevrules needed by cryptsetup
> ..
>

I think this is a good thing to get this error during build, since
package depends on it at runtime, having
empty content will just defer the error until the system is booted and
then its harder to debug the failures

> Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
> ---
>  meta-oe/recipes-support/lvm2/lvm2_2.02.177.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-support/lvm2/lvm2_2.02.177.bb b/meta-oe/recipes-support/lvm2/lvm2_2.02.177.bb
> index 1d9de3d94..388e89117 100644
> --- a/meta-oe/recipes-support/lvm2/lvm2_2.02.177.bb
> +++ b/meta-oe/recipes-support/lvm2/lvm2_2.02.177.bb
> @@ -46,6 +46,7 @@ FILES_${PN}-scripts = " \
>  # Specified explicitly for the udev rules, just in case that it does not get picked
>  # up automatically:
>  FILES_${PN}-udevrules = "${nonarch_base_libdir}/udev/rules.d"
> +ALLOW_EMPTY_${PN}-udevrules = "1"
>  RDEPENDS_${PN}_append_class-target = " libdevmapper"
>  RDEPENDS_${PN}_append_class-nativesdk = " libdevmapper"
>
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel