[bitbake-devel,4/4] runqueue: Stop on first unsatisfied dependency

Submitted by Joshua Watt on July 6, 2018, 3:42 p.m. | Patch ID: 152401

Details

Message ID 20180706154200.28769-4-JPEWhacker@gmail.com
State New
Headers show

Commit Message

Joshua Watt July 6, 2018, 3:42 p.m.
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
 bitbake/lib/bb/runqueue.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Patch hide | download patch | download mbox

diff --git a/bitbake/lib/bb/runqueue.py b/bitbake/lib/bb/runqueue.py
index 8ce9ad51898..ba9bebebcfe 100644
--- a/bitbake/lib/bb/runqueue.py
+++ b/bitbake/lib/bb/runqueue.py
@@ -1886,11 +1886,12 @@  class RunQueueExecuteTasks(RunQueueExecute):
                 continue
             if revdep in self.runq_buildable:
                 continue
-            alldeps = 1
+            alldeps = True
             for dep in self.rqdata.runtaskentries[revdep].depends:
                 if dep not in self.runq_complete:
-                    alldeps = 0
-            if alldeps == 1:
+                    alldeps = False
+                    break
+            if alldeps:
                 self.setbuildable(revdep)
                 logger.debug(1, "Marking task %s as buildable", revdep)
 

Comments

Paul Eggleton July 9, 2018, 3:53 p.m.
Hi Joshua

On Friday, 6 July 2018 5:42:00 PM CEST Joshua Watt wrote:
> runqueue: Stop on first unsatisfied dependency

Richard merged this already, but for future non-trivial patches could you 
please include a commit message that explains the change (particularly why the 
change is being made, rather than just restating what's been changed).

Thanks,
Paul
Joshua Watt July 9, 2018, 5:43 p.m.
On Mon, Jul 9, 2018 at 10:53 AM Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
>
> Hi Joshua
>
> On Friday, 6 July 2018 5:42:00 PM CEST Joshua Watt wrote:
> > runqueue: Stop on first unsatisfied dependency
>
> Richard merged this already, but for future non-trivial patches could you
> please include a commit message that explains the change (particularly why the
> change is being made, rather than just restating what's been changed).

Yes, sorry. I will try to be more diligent in the future.

Thanks,
Joshua Watt

>
> Thanks,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre
>
>