mbox

[0/1] create-spdx: default share_src for shared sources

Message ID AM8P192MB09633133388817BF0814341EA3389@AM8P192MB0963.EURP192.PROD.OUTLOOK.COM
State Not Applicable, archived
Headers show

Pull-request

https://github.com/witekio-kwe/poky spdx-fix

Message

Konrad WEIHMANN Nov. 3, 2022, 2:15 p.m. UTC 
as it's practically impossible to send an email patch from corporate
environment, please find the following patch at the mentioned
remote location.

It would be nice to have that backported to kirkstone as well, once merged, as this is
where I encountered the issue first

The following changes since commit 482c493cf681121fb041f98066a42af14145ff9e:

  valgrind: update to 3.20.0 (2022-11-03 07:46:47 +0000)

are available in the Git repository at:

  https://github.com/witekio-kwe/poky spdx-fix
  https://github.com/witekio-kwe/poky/tree/spdx-fix

Konrad Weihmann (1):
  create-spdx: default share_src for shared sources

 meta/classes/create-spdx.bbclass | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


Witekio GmbH is registered in Frankfurt. Registered office: Am Wartfeld 7 - 61169 Friedberg. Registered company number: HRB 95432. VAT number DE287400071
This message contains confidential information and is intended only for the individual(s) addressed in the message. If you aren't the named addressee, you should not disseminate, distribute, or copy this e-mail.

We continuously commit to comply with the applicable data protection laws and ensure fair and transparent processing of your personal data. Please read our privacy statement including an information notice and data protection policy for detailed information on our website.

Comments

Joshua Watt Nov. 3, 2022, 2:28 p.m. UTC | #1 
I see the problem, but I'm not quite sure this is the correct solution. 
It *does* fix the problem for exact recipe that provides the source code 
(e.g. the llvm-sources recipe), but I don't think it will correctly pick 
up the sources for anything that actually uses that shared source code 
(e.g. clang); this isn't necessarily a problem in your patch however, I 
think it's actually a problem with any non-kernel recipes.


On 11/3/22 09:15, Konrad WEIHMANN via lists.openembedded.org wrote:
> https://github.com/witekio-kwe/poky spdx-fix
Joshua Watt Nov. 3, 2022, 4:20 p.m. UTC | #2 
On 11/3/22 09:49, Konrad WEIHMANN wrote:
> so what's the conclusion? I would be okay to add a var like 
> SPDX_SHARED_SOURCE (default WORKDIR) or something and reference this 
> as a default - when using a weak default ppl could override that to 
> their needs...


Ya, I think what you have is fine with a minor change; the limitations 
of not handling non-kernel shared source very well isn't changing. I did 
leave a minor comment in github, but otherwise LGTM


>
> Would that be something that would work?
> ------------------------------------------------------------------------
> *From:* Joshua Watt <jpewhacker@gmail.com>
> *Sent:* Thursday, November 3, 2022 3:28 PM
> *To:* Konrad WEIHMANN <kweihmann@witekio.com>; 
> openembedded-core@lists.openembedded.org 
> <openembedded-core@lists.openembedded.org>
> *Cc:* steve@sakoman.com <steve@sakoman.com>
> *Subject:* Re: [OE-core] [PATCH 0/1] create-spdx: default share_src 
> for shared sources
> I see the problem, but I'm not quite sure this is the correct solution.
> It *does* fix the problem for exact recipe that provides the source code
> (e.g. the llvm-sources recipe), but I don't think it will correctly pick
> up the sources for anything that actually uses that shared source code
> (e.g. clang); this isn't necessarily a problem in your patch however, I
> think it's actually a problem with any non-kernel recipes.
>
>
> On 11/3/22 09:15, Konrad WEIHMANN via lists.openembedded.org wrote:
> > https://github.com/witekio-kwe/poky spdx-fix
>
> Witekio GmbH is registered in Frankfurt. Registered office: Am 
> Wartfeld 7 - 61169 Friedberg. Registered company number: HRB 95432. 
> VAT number DE287400071
> This message contains confidential information and is intended only 
> for the individual(s) addressed in the message. If you aren't the 
> named addressee, you should not disseminate, distribute, or copy this 
> e-mail.
>
> We continuously commit to comply with the applicable data protection 
> laws and ensure fair and transparent processing of your personal data. 
> Please read our privacy statement including an information notice and 
> data protection policy for detailed information on our website.
>
Joshua Watt Nov. 3, 2022, 5:40 p.m. UTC | #3 
On 11/3/22 11:20, Joshua Watt wrote:
>
> On 11/3/22 09:49, Konrad WEIHMANN wrote:
>> so what's the conclusion? I would be okay to add a var like 
>> SPDX_SHARED_SOURCE (default WORKDIR) or something and reference this 
>> as a default - when using a weak default ppl could override that to 
>> their needs...
>
>
> Ya, I think what you have is fine with a minor change; the limitations 
> of not handling non-kernel shared source very well isn't changing. I 
> did leave a minor comment in github, but otherwise LGTM

Per discussion on GitHub, this is fine to merge as is. Thanks

>
>
>>
>> Would that be something that would work?
>> ------------------------------------------------------------------------
>> *From:* Joshua Watt <jpewhacker@gmail.com>
>> *Sent:* Thursday, November 3, 2022 3:28 PM
>> *To:* Konrad WEIHMANN <kweihmann@witekio.com>; 
>> openembedded-core@lists.openembedded.org 
>> <openembedded-core@lists.openembedded.org>
>> *Cc:* steve@sakoman.com <steve@sakoman.com>
>> *Subject:* Re: [OE-core] [PATCH 0/1] create-spdx: default share_src 
>> for shared sources
>> I see the problem, but I'm not quite sure this is the correct solution.
>> It *does* fix the problem for exact recipe that provides the source code
>> (e.g. the llvm-sources recipe), but I don't think it will correctly pick
>> up the sources for anything that actually uses that shared source code
>> (e.g. clang); this isn't necessarily a problem in your patch however, I
>> think it's actually a problem with any non-kernel recipes.
>>
>>
>> On 11/3/22 09:15, Konrad WEIHMANN via lists.openembedded.org wrote:
>> > https://github.com/witekio-kwe/poky spdx-fix
>>
>> Witekio GmbH is registered in Frankfurt. Registered office: Am 
>> Wartfeld 7 - 61169 Friedberg. Registered company number: HRB 95432. 
>> VAT number DE287400071
>> This message contains confidential information and is intended only 
>> for the individual(s) addressed in the message. If you aren't the 
>> named addressee, you should not disseminate, distribute, or copy this 
>> e-mail.
>>
>> We continuously commit to comply with the applicable data protection 
>> laws and ensure fair and transparent processing of your personal 
>> data. Please read our privacy statement including an information 
>> notice and data protection policy for detailed information on our 
>> website.
>>