[v3,3/3] weston-init: Fix weston-start to allow weston args without openvt args

Submitted by Tom Hochstein on July 18, 2016, 2:43 p.m. | Patch ID: 127441

Details

Message ID 1468852986-2487-3-git-send-email-tom.hochstein@nxp.com
State New
Headers show

Commit Message

Tom Hochstein July 18, 2016, 2:43 p.m. 
The parser didn't properly handle commands of the form
weston-start -- <weston-options>.

Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
---
 meta/recipes-graphics/wayland/weston-init/weston-start | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Patch hide | download patch | download mbox 

diff --git a/meta/recipes-graphics/wayland/weston-init/weston-start b/meta/recipes-graphics/wayland/weston-init/weston-start
index cd64216..e72fbaa 100755
--- a/meta/recipes-graphics/wayland/weston-init/weston-start
+++ b/meta/recipes-graphics/wayland/weston-init/weston-start
@@ -35,13 +35,12 @@  fi
 
 openvt_args="-s"
 while [ -n "$1" ]; do
-	openvt_args="$openvt_args $1"
-	shift
-
 	if [ "$1" = "--" ]; then
 		shift
 		break
 	fi
+	openvt_args="$openvt_args $1"
+	shift
 done
 
 weston_args=$*

Comments

Otavio Salvador July 18, 2016, 3:13 p.m. 
On Mon, Jul 18, 2016 at 11:43 AM, Tom Hochstein <tom.hochstein@nxp.com> wrote:
> The parser didn't properly handle commands of the form
> weston-start -- <weston-options>.
>
> Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>



Acked-by: Otavio Salvador <otavio@ossystems.com.br>
Ross Burton July 18, 2016, 4:29 p.m. 
I can only see 1/3 and 3/3, but no 2/3.

On 18 July 2016 at 16:13, Otavio Salvador <otavio.salvador@ossystems.com.br>
wrote:

> On Mon, Jul 18, 2016 at 11:43 AM, Tom Hochstein <tom.hochstein@nxp.com>
> wrote:
> > The parser didn't properly handle commands of the form
> > weston-start -- <weston-options>.
> >
> > Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
>
>
>
> Acked-by: Otavio Salvador <otavio@ossystems.com.br>
>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
Tom Hochstein July 18, 2016, 4:47 p.m. 
Re-sent.

From: Burton, Ross [mailto:ross.burton@intel.com]

Sent: Monday, July 18, 2016 11:29 AM
To: Otavio Salvador <otavio.salvador@ossystems.com.br>
Cc: Tom Hochstein <tom.hochstein@nxp.com>; Otavio Salvador <otavio@ossystems.com.br>; Patches and discussions about the oe-core layer <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v3 3/3] weston-init: Fix weston-start to allow weston args without openvt args

I can only see 1/3 and 3/3, but no 2/3.

On 18 July 2016 at 16:13, Otavio Salvador <otavio.salvador@ossystems.com.br<mailto:otavio.salvador@ossystems.com.br>> wrote:
On Mon, Jul 18, 2016 at 11:43 AM, Tom Hochstein <tom.hochstein@nxp.com<mailto:tom.hochstein@nxp.com>> wrote:
> The parser didn't properly handle commands of the form

> weston-start -- <weston-options>.

>

> Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com<mailto:tom.hochstein@nxp.com>>




Acked-by: Otavio Salvador <otavio@ossystems.com.br<mailto:otavio@ossystems.com.br>>


--
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854<tel:%2B55%20%2853%29%209981-7854>            Mobile: +1 (347) 903-9750<tel:%2B1%20%28347%29%20903-9750>
--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org<mailto:Openembedded-core@lists.openembedded.org>
http://lists.openembedded.org/mailman/listinfo/openembedded-core