| Message ID | 20220813170156.4040589-1-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] rng-tools: Remove disabling DefaultDependencies | expand |
On Sat, 2022-08-13 at 10:01 -0700, Khem Raj wrote: > Delete dependency on dev-hwrng.device and systemd-udev-settle services > as they can be troublesome because difference devices may have different > devices to detect resulting in delayed boot. default dependencies would > add some delay that the race condition for creating the device by kernel > module and daemon using it is not seen often. > > do not run if included in a container image > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta/recipes-support/rng-tools/rng-tools/rng-tools.service | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/meta/recipes-support/rng-tools/rng-tools/rng-tools.service b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service > index 0f50890dcb1..c8b46aebab0 100644 > --- a/meta/recipes-support/rng-tools/rng-tools/rng-tools.service > +++ b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service > @@ -1,10 +1,7 @@ > [Unit] > Description=Hardware RNG Entropy Gatherer Daemon > -DefaultDependencies=no > -After=systemd-udev-settle.service > +ConditionVirtualization=!container > Before=sysinit.target shutdown.target > -Requires=dev-hwrng.device > -After=dev-hwrng.device > Conflicts=shutdown.target > > [Service] Fails in testing: https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/4496/steps/14/logs/stdio Cheers, Richard
diff --git a/meta/recipes-support/rng-tools/rng-tools/rng-tools.service b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service index 0f50890dcb1..c8b46aebab0 100644 --- a/meta/recipes-support/rng-tools/rng-tools/rng-tools.service +++ b/meta/recipes-support/rng-tools/rng-tools/rng-tools.service @@ -1,10 +1,7 @@ [Unit] Description=Hardware RNG Entropy Gatherer Daemon -DefaultDependencies=no -After=systemd-udev-settle.service +ConditionVirtualization=!container Before=sysinit.target shutdown.target -Requires=dev-hwrng.device -After=dev-hwrng.device Conflicts=shutdown.target [Service]
Delete dependency on dev-hwrng.device and systemd-udev-settle services as they can be troublesome because difference devices may have different devices to detect resulting in delayed boot. default dependencies would add some delay that the race condition for creating the device by kernel module and daemon using it is not seen often. do not run if included in a container image Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/recipes-support/rng-tools/rng-tools/rng-tools.service | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)