| Message ID | 20220811123513.1188060-1-peter.marko@siemens.com |
|---|---|
| State | Accepted, archived |
| Commit | e105befbe4ee0d85e94c2048a744f0373e2dbcdf |
| Headers | show |
| Series | create-spdx: handle links to inaccessible locations | expand |
diff --git a/meta/classes/create-spdx.bbclass b/meta/classes/create-spdx.bbclass index 10deba638f..26a77b12b1 100644 --- a/meta/classes/create-spdx.bbclass +++ b/meta/classes/create-spdx.bbclass @@ -216,7 +216,7 @@ def add_package_files(d, doc, spdx_pkg, topdir, get_spdxid, get_types, *, archiv filepath = Path(subdir) / file filename = str(filepath.relative_to(topdir)) - if filepath.is_file() and not filepath.is_symlink(): + if not filepath.is_symlink() and filepath.is_file(): spdx_file = oe.spdx.SPDXFile() spdx_file.SPDXID = get_spdxid(file_counter) for t in get_types(filepath):
When a link is pointing to location inaccessible to build user (e.g. "/root/something"), filepath.is_file() throws "PermissionError: [Errno 13] Permission denied". Fix this by first checking if it is a link. Signed-off-by: Peter Marko <peter.marko@siemens.com> --- meta/classes/create-spdx.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)