[CONSOLIDATED,PULL,16/32] gcc-4.6: Use --with-linker-hash-style configure option

Submitted by Saul Wold on Aug. 18, 2011, 8:55 p.m.

Details

Message ID 788258d226dc94004ce8284a62cf8524bcf4b010.1313700595.git.sgw@linux.intel.com
State New, archived
Headers show

Commit Message

Saul Wold Aug. 18, 2011, 8:55 p.m.
From: Khem Raj <raj.khem@gmail.com>

Depending upon what hash style is in use this uses
the right flag for setting the hash style type. This
fixes the QA errors about missing GNU hash style reported
in gcc-runtime build particularly libgcc

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-devtools/gcc/gcc-4.6.inc |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Patch hide | download patch | download mbox

diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
index 0a148b4..fffb779 100644
--- a/meta/recipes-devtools/gcc/gcc-4.6.inc
+++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
@@ -1,6 +1,6 @@ 
 require gcc-common.inc
 
-PR = "r7"
+PR = "r8"
 
 # Third digit in PV should be incremented after a minor release
 # happens from this branch on gcc e.g. currently its 4.6.0
@@ -90,6 +90,7 @@  EXTRA_OECONF_BASE = " --enable-lto \
 			--disable-bootstrap \
 			--disable-libgomp \
 			--disable-libmudflap \
+			--with-linker-hash-style=${LINKER_HASH_STYLE} \
 			--enable-cheaders=c_global "
 
 EXTRA_OECONF_INITIAL = "--disable-libmudflap \

Comments

Phil Blundell Aug. 19, 2011, 4:23 p.m.
On Thu, 2011-08-18 at 13:55 -0700, Saul Wold wrote:
>  # Third digit in PV should be incremented after a minor release
>  # happens from this branch on gcc e.g. currently its 4.6.0
> @@ -90,6 +90,7 @@ EXTRA_OECONF_BASE = " --enable-lto \
>  			--disable-bootstrap \
>  			--disable-libgomp \
>  			--disable-libmudflap \
> +			--with-linker-hash-style=${LINKER_HASH_STYLE} \
>  			--enable-cheaders=c_global "
>  
>  EXTRA_OECONF_INITIAL = "--disable-libmudflap \

Which gcc did you test this against?  As far as I can tell this patch
was only applied to the trunk (as of May this year) and not the 4.6
branch.  The corresponding configury certainly doesn't seem to exist in
the oe-core build tree that I happen to have lying around in front of
me, so it isn't apparent that this patch will have any useful effect. 

p.
Khem Raj Aug. 19, 2011, 6:29 p.m.
On Fri, Aug 19, 2011 at 9:23 AM, Phil Blundell <philb@gnu.org> wrote:
> On Thu, 2011-08-18 at 13:55 -0700, Saul Wold wrote:
>>  # Third digit in PV should be incremented after a minor release
>>  # happens from this branch on gcc e.g. currently its 4.6.0
>> @@ -90,6 +90,7 @@ EXTRA_OECONF_BASE = " --enable-lto \
>>                       --disable-bootstrap \
>>                       --disable-libgomp \
>>                       --disable-libmudflap \
>> +                     --with-linker-hash-style=${LINKER_HASH_STYLE} \
>>                       --enable-cheaders=c_global "
>>
>>  EXTRA_OECONF_INITIAL = "--disable-libmudflap \
>
> Which gcc did you test this against?  As far as I can tell this patch
> was only applied to the trunk (as of May this year) and not the 4.6
> branch.  The corresponding configury certainly doesn't seem to exist in
> the oe-core build tree that I happen to have lying around in front of
> me, so it isn't apparent that this patch will have any useful effect.
>

Yes that patch is missing
I noted it in mail to other thread. the patch was being applied
in meta-oe. I will redo these 2 patches and resend

> p.
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Khem Raj Aug. 19, 2011, 6:55 p.m.
On Fri, Aug 19, 2011 at 11:29 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On Fri, Aug 19, 2011 at 9:23 AM, Phil Blundell <philb@gnu.org> wrote:
>> On Thu, 2011-08-18 at 13:55 -0700, Saul Wold wrote:
>>>  # Third digit in PV should be incremented after a minor release
>>>  # happens from this branch on gcc e.g. currently its 4.6.0
>>> @@ -90,6 +90,7 @@ EXTRA_OECONF_BASE = " --enable-lto \
>>>                       --disable-bootstrap \
>>>                       --disable-libgomp \
>>>                       --disable-libmudflap \
>>> +                     --with-linker-hash-style=${LINKER_HASH_STYLE} \
>>>                       --enable-cheaders=c_global "
>>>
>>>  EXTRA_OECONF_INITIAL = "--disable-libmudflap \
>>
>> Which gcc did you test this against?  As far as I can tell this patch
>> was only applied to the trunk (as of May this year) and not the 4.6
>> branch.  The corresponding configury certainly doesn't seem to exist in
>> the oe-core build tree that I happen to have lying around in front of
>> me, so it isn't apparent that this patch will have any useful effect.
>>
>
> Yes that patch is missing
> I noted it in mail to other thread. the patch was being applied
> in meta-oe. I will redo these 2 patches and resend

I have pushed what I am testing again right now its here

http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=kraj/linker-hash-choice


>
>> p.
>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>