From patchwork Fri May 20 19:58:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Kiernan X-Patchwork-Id: 8329 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99176C433EF for ; Fri, 20 May 2022 19:58:19 +0000 (UTC) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by mx.groups.io with SMTP id smtpd.web11.1985.1653076696400877180 for ; Fri, 20 May 2022 12:58:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=C/nH2t7O; spf=pass (domain: gmail.com, ip: 209.85.208.48, mailfrom: alex.kiernan@gmail.com) Received: by mail-ed1-f48.google.com with SMTP id er5so12025283edb.12 for ; Fri, 20 May 2022 12:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+e/XqXDfjExDopXLGWD04KnJCyNhbfHNacVfHImYRvU=; b=C/nH2t7Ogb1kYh4B/PrWX0s4MrqsdgAcmzGr1bghtyPvLwHc8IOd5c3A6TeL/vJON0 vppTFXfWJjn2YH+Ax3WK6Dq6R/zHJ6nyjHFB+7LV6sj4TeWGSJ3d/r1wf2H6kBELUX1H rJ4eprzvfpXkZq7mDsXaLVvm6O/J+GcKSOxOU5TaJe9v1VxQhrTJXym8UTFyWsS/5JJf 7tKtZWEZIVHmDkc5ezLDdtKkeGYK3Q53xiICAlC9MlKvoENJtH9KjfOJahJ326ZqGN/n t73+HofOFrJCKVuWQgZbyVwk1ljTWJRG/fNcW6WLKPcibxaIrT0bT1Vo+/ikHejIjjrl F3oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+e/XqXDfjExDopXLGWD04KnJCyNhbfHNacVfHImYRvU=; b=wz4IVjeRub17iWc9lK8X7DQF8alT9ojDnEc8Iqq3bCIu7h6JIlApy8qMxBij1Cp8Ct AadKz2fRMABLqNviEut3ntXd+TpHIWTRVoiEuNxZVxoTHuKeL7LgddXUP/22smQ+Smx0 fNKOv7PsaJixTXu2woxZQQfG3U7CYAfugsMqTf3BMdrSkdiw7wcRqvCmDhBDEebg01rW e93SZafBf2BHMLAOXyrbO62Vppfiz5VUSEsrZjZOhBfV/+Lqv/dKs9IdkyLUkswmb7vX TDvbJUxJp7tjsjJWb5b/naiH9kpIa+ZBSFp+7f0GUBGmwkCcFlgeYxeAjOoCxM55mqeR zvmQ== X-Gm-Message-State: AOAM531tviLbmsa0ItbjD+bmvsvIrbTiurBwpcsPibaUvyA//HXltQuI zkIkto5gm4wb/Ut56On1Fs94B/gsmX8= X-Google-Smtp-Source: ABdhPJwkuLXgMTElsf/YuIvstfE5hjxbtWVWMRJYRTVBxON0gj/IpPgVJX9qa+rkvwfhh2hepqeLmQ== X-Received: by 2002:aa7:dbd0:0:b0:427:4e6e:d779 with SMTP id v16-20020aa7dbd0000000b004274e6ed779mr12624477edt.27.1653076694426; Fri, 20 May 2022 12:58:14 -0700 (PDT) Received: from localhost.localdomain (cust246-dsl91-135-6.idnet.net. [91.135.6.246]) by smtp.gmail.com with ESMTPSA id gx5-20020a1709068a4500b006f3ef214de6sm3448448ejc.76.2022.05.20.12.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 12:58:13 -0700 (PDT) From: Alex Kiernan To: openembedded-core@lists.openembedded.org Cc: Alex Kiernan , Alex Kiernan Subject: [OE-Core][PATCH v3 1/3] eudev: Convert dependencies to PACKAGECONFIG Date: Fri, 20 May 2022 20:58:07 +0100 Message-Id: <20220520195809.4855-1-alex.kiernan@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 20 May 2022 19:58:19 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/165950 GObject support was dropped in 252150e181c5 ("src/gudev: remove Gobject libudev support."), drop all g-i-r support which appears to be dead upstream. Fill out PACKAGECONFIG options. Signed-off-by: Alex Kiernan Signed-off-by: Alex Kiernan --- ...uild-Remove-dead-g-i-r-configuration.patch | 155 ++++++++++++++++++ meta/recipes-core/udev/eudev_3.2.11.bb | 8 +- 2 files changed, 161 insertions(+), 2 deletions(-) create mode 100644 meta/recipes-core/udev/eudev/0001-build-Remove-dead-g-i-r-configuration.patch diff --git a/meta/recipes-core/udev/eudev/0001-build-Remove-dead-g-i-r-configuration.patch b/meta/recipes-core/udev/eudev/0001-build-Remove-dead-g-i-r-configuration.patch new file mode 100644 index 000000000000..2836f30c3adf --- /dev/null +++ b/meta/recipes-core/udev/eudev/0001-build-Remove-dead-g-i-r-configuration.patch @@ -0,0 +1,155 @@ +From 520c4d451efc488573746f169d8e47d5a131afc2 Mon Sep 17 00:00:00 2001 +From: Alex Kiernan +Date: Fri, 20 May 2022 09:35:08 +0100 +Subject: [PATCH] build: Remove dead g-i-r configuration + +g-i-r support was removed in 2015 as part of removal of Gobject libudev +support, but the autoconf support wasn't removed but is dead. + +Fixes: 252150e181c5 ("src/gudev: remove Gobject libudev support.") +Upstream-Status: Submitted [https://github.com/eudev-project/eudev/pull/231] +Signed-off-by: Alex Kiernan +Signed-off-by: Alex Kiernan +--- + configure.ac | 12 ------ + m4/introspection.m4 | 96 --------------------------------------------- + 2 files changed, 108 deletions(-) + delete mode 100644 m4/introspection.m4 + +diff --git a/configure.ac b/configure.ac +index 85a524a618ae..987d5037ae77 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -183,17 +183,8 @@ AC_SUBST([udevrulesdir],[${udevlibexecdir}/rules.d]) + AC_SUBST([pkgconfiglibdir], [${libdir}/pkgconfig]) + AC_SUBST([sharepkgconfigdir],[${datadir}/pkgconfig]) + +-# introspection paths +-AC_SUBST([girdir], [${datadir}/gir-1.0]) +-AC_SUBST([typelibsdir], [${libdir}/girepository-1.0]) +- + AC_SUBST([rootrundir],[${with_rootrundir}]) + +-# ------------------------------------------------------------------------------ +- +-GOBJECT_INTROSPECTION_CHECK([1.31.1]) +-AM_CONDITIONAL([HAVE_INTROSPECTION], [test "$enable_introspection" = "yes"]) +- + # ------------------------------------------------------------------------------ + AC_ARG_ENABLE([programs], + AS_HELP_STRING([--disable-programs], [disable programs (udevd, udevadm and helpers)]), +@@ -349,9 +340,6 @@ AC_MSG_RESULT([ + + pkgconfiglibdir: ${libdir}/pkgconfig + sharepkgconfigdir ${datadir}/pkgconfig +- +- girdir ${datadir}/gir-1.0 +- typelibsdir ${libdir}/girepository-1.0 + ]) + + # ------------------------------------------------------------------------------ +diff --git a/m4/introspection.m4 b/m4/introspection.m4 +deleted file mode 100644 +index d89c3d907d9c..000000000000 +--- a/m4/introspection.m4 ++++ /dev/null +@@ -1,96 +0,0 @@ +-dnl -*- mode: autoconf -*- +-dnl Copyright 2009 Johan Dahlin +-dnl +-dnl This file is free software; the author(s) gives unlimited +-dnl permission to copy and/or distribute it, with or without +-dnl modifications, as long as this notice is preserved. +-dnl +- +-# serial 1 +- +-m4_define([_GOBJECT_INTROSPECTION_CHECK_INTERNAL], +-[ +- AC_BEFORE([AC_PROG_LIBTOOL],[$0])dnl setup libtool first +- AC_BEFORE([AM_PROG_LIBTOOL],[$0])dnl setup libtool first +- AC_BEFORE([LT_INIT],[$0])dnl setup libtool first +- +- dnl enable/disable introspection +- m4_if([$2], [require], +- [dnl +- enable_introspection=yes +- ],[dnl +- AC_ARG_ENABLE(introspection, +- AS_HELP_STRING([--enable-introspection[=@<:@no/auto/yes@:>@]], +- [Enable introspection for this build]),, +- [enable_introspection=auto]) +- ])dnl +- +- AC_MSG_CHECKING([for gobject-introspection]) +- +- dnl presence/version checking +- AS_CASE([$enable_introspection], +- [no], [dnl +- found_introspection="no (disabled, use --enable-introspection to enable)" +- ],dnl +- [yes],[dnl +- PKG_CHECK_EXISTS([gobject-introspection-1.0],, +- AC_MSG_ERROR([gobject-introspection-1.0 is not installed])) +- PKG_CHECK_EXISTS([gobject-introspection-1.0 >= $1], +- found_introspection=yes, +- AC_MSG_ERROR([You need to have gobject-introspection >= $1 installed to build AC_PACKAGE_NAME])) +- ],dnl +- [auto],[dnl +- PKG_CHECK_EXISTS([gobject-introspection-1.0 >= $1], found_introspection=yes, found_introspection=no) +- dnl Canonicalize enable_introspection +- enable_introspection=$found_introspection +- ],dnl +- [dnl +- AC_MSG_ERROR([invalid argument passed to --enable-introspection, should be one of @<:@no/auto/yes@:>@]) +- ])dnl +- +- AC_MSG_RESULT([$found_introspection]) +- +- INTROSPECTION_SCANNER= +- INTROSPECTION_COMPILER= +- INTROSPECTION_GENERATE= +- INTROSPECTION_GIRDIR= +- INTROSPECTION_TYPELIBDIR= +- if test "x$found_introspection" = "xyes"; then +- INTROSPECTION_SCANNER=`$PKG_CONFIG --variable=g_ir_scanner gobject-introspection-1.0` +- INTROSPECTION_COMPILER=`$PKG_CONFIG --variable=g_ir_compiler gobject-introspection-1.0` +- INTROSPECTION_GENERATE=`$PKG_CONFIG --variable=g_ir_generate gobject-introspection-1.0` +- INTROSPECTION_GIRDIR=`$PKG_CONFIG --variable=girdir gobject-introspection-1.0` +- INTROSPECTION_TYPELIBDIR="$($PKG_CONFIG --variable=typelibdir gobject-introspection-1.0)" +- INTROSPECTION_CFLAGS=`$PKG_CONFIG --cflags gobject-introspection-1.0` +- INTROSPECTION_LIBS=`$PKG_CONFIG --libs gobject-introspection-1.0` +- INTROSPECTION_MAKEFILE=`$PKG_CONFIG --variable=datadir gobject-introspection-1.0`/gobject-introspection-1.0/Makefile.introspection +- fi +- AC_SUBST(INTROSPECTION_SCANNER) +- AC_SUBST(INTROSPECTION_COMPILER) +- AC_SUBST(INTROSPECTION_GENERATE) +- AC_SUBST(INTROSPECTION_GIRDIR) +- AC_SUBST(INTROSPECTION_TYPELIBDIR) +- AC_SUBST(INTROSPECTION_CFLAGS) +- AC_SUBST(INTROSPECTION_LIBS) +- AC_SUBST(INTROSPECTION_MAKEFILE) +- +- AM_CONDITIONAL(HAVE_INTROSPECTION, test "x$found_introspection" = "xyes") +-]) +- +- +-dnl Usage: +-dnl GOBJECT_INTROSPECTION_CHECK([minimum-g-i-version]) +- +-AC_DEFUN([GOBJECT_INTROSPECTION_CHECK], +-[ +- _GOBJECT_INTROSPECTION_CHECK_INTERNAL([$1]) +-]) +- +-dnl Usage: +-dnl GOBJECT_INTROSPECTION_REQUIRE([minimum-g-i-version]) +- +- +-AC_DEFUN([GOBJECT_INTROSPECTION_REQUIRE], +-[ +- _GOBJECT_INTROSPECTION_CHECK_INTERNAL([$1], [require]) +-]) +-- +2.35.1 + diff --git a/meta/recipes-core/udev/eudev_3.2.11.bb b/meta/recipes-core/udev/eudev_3.2.11.bb index 841039f6d745..a841a6a86cc1 100644 --- a/meta/recipes-core/udev/eudev_3.2.11.bb +++ b/meta/recipes-core/udev/eudev_3.2.11.bb @@ -5,13 +5,14 @@ LICENSE = "GPL-2.0-or-later & LGPL-2.1-or-later" LICENSE:libudev = "LGPL-2.1-or-later" LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe" -DEPENDS = "glib-2.0 glib-2.0-native gperf-native kmod util-linux" +DEPENDS = "gperf-native" PROVIDES = "udev" SRC_URI = "https://github.com/eudev-project/${BPN}/releases/download/v${PV}/${BP}.tar.gz \ file://init \ file://local.rules \ + file://0001-build-Remove-dead-g-i-r-configuration.patch \ " SRC_URI[sha256sum] = "19847cafec67897da855fde56f9dc7d92e21c50e450aa79068a7e704ed44558b" @@ -30,11 +31,14 @@ EXTRA_OECONF = " \ --with-rootprefix= \ " -PACKAGECONFIG ?= "hwdb \ +PACKAGECONFIG ?= "blkid hwdb kmod \ ${@bb.utils.filter('DISTRO_FEATURES', 'selinux', d)} \ " +PACKAGECONFIG[blkid] = "--enable-blkid,--disable-blkid,util-linux" PACKAGECONFIG[hwdb] = "--enable-hwdb,--disable-hwdb" +PACKAGECONFIG[kmod] = "--enable-kmod,--disable-kmod,kmod" PACKAGECONFIG[manpages] = "--enable-manpages,--disable-manpages" +PACKAGECONFIG[rule-generator] = "--enable-rule-generator,--disable-rule-generator" PACKAGECONFIG[selinux] = "--enable-selinux,--disable-selinux,libselinux" do_install:append() { From patchwork Fri May 20 19:58:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Kiernan X-Patchwork-Id: 8328 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AFB7C4332F for ; Fri, 20 May 2022 19:58:19 +0000 (UTC) Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by mx.groups.io with SMTP id smtpd.web09.2050.1653076696595807999 for ; Fri, 20 May 2022 12:58:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=POHomfhr; spf=pass (domain: gmail.com, ip: 209.85.208.54, mailfrom: alex.kiernan@gmail.com) Received: by mail-ed1-f54.google.com with SMTP id fd25so12078795edb.3 for ; Fri, 20 May 2022 12:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=afY1I2OdGiy0oLu5Kmd8rXLY02ooDDy0xjLccwHgxqg=; b=POHomfhrg5gFcaD44fW4n7fFWXCurEU4S+eA1iRET1Wl0Vgi3oQwhe8VYEq4kMxIWh nAYqIneWbYPU2TR8wKOKgkOsyBsuO/N8dfo3ZYFte2TJp4atuDmNwlb7gUlz3oAnafOA fwVV31d4FkXpoP1/zDit+7WUN8jG5LYq0sJUGtx/AgKYMHYF9iJJC2nsX8u+f0us3MnV NK+VcKIYMoB0ryCxDRO2/bldcYa7WqKPMnopRn02+tabmBP4PKy2OvllXYwpNlVpzGMh SPS0DZ/7BFptUIKHhXViSaKyP03q4YSKLt6Wmz2DUPVeouT2sgR/r0kIZONiESnYudb8 sJmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=afY1I2OdGiy0oLu5Kmd8rXLY02ooDDy0xjLccwHgxqg=; b=kNER2Lc8Nl+rGWbpae2K9fsyFQywBKqGRo7xKj0FrUyV2Clxn2KM8FRmoQxq146Aw+ iH7ZkdCkWFs+/SDF0Eg7DBZ1SHT4xoojIHmQfdblXfCdDa8eBVYP1BHOGGqhRZ6pEHWS Z/NE+EwTAbUOtWAIvjSO8nIwIBeUZwxS3Hnsi3fG5ku2FmKBP2ur7gMlOSrgzQfeGfvX QLk2izdaLEFxRmWjQsl3sH4gklUBiFTLNxSSVO//HitgSMqyp4Jfr2e7k3hfbzlYKkGy n2SOVzHf/6wjodkPYcVCB/dBF86VxBXg8j/FXjPfdPL0no7WzD1nfVttLJc3psZ6RdOe Z1LA== X-Gm-Message-State: AOAM530DuBoGozxq01tvbBnEOnFJCnaHmoSs+I9nenT+xZG/LNhRYD7u 1XWaIAacWYUJzYJPXksEbvq2Ql8FjE0= X-Google-Smtp-Source: ABdhPJz9gcCcn+dDiNct8af+3dbRCrsXvXqrfBgH1Dz1DEEhy9Qwh4PeN8uJWZ2hWN2lfPAeg+ozIg== X-Received: by 2002:a05:6402:3219:b0:42a:e33e:54d with SMTP id g25-20020a056402321900b0042ae33e054dmr12529877eda.299.1653076695002; Fri, 20 May 2022 12:58:15 -0700 (PDT) Received: from localhost.localdomain (cust246-dsl91-135-6.idnet.net. [91.135.6.246]) by smtp.gmail.com with ESMTPSA id gx5-20020a1709068a4500b006f3ef214de6sm3448448ejc.76.2022.05.20.12.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 12:58:14 -0700 (PDT) From: Alex Kiernan To: openembedded-core@lists.openembedded.org Cc: Alex Kiernan , Alex Kiernan Subject: [OE-Core][PATCH v3 2/3] eudev: Cleanup redundant configuration Date: Fri, 20 May 2022 20:58:08 +0100 Message-Id: <20220520195809.4855-2-alex.kiernan@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220520195809.4855-1-alex.kiernan@gmail.com> References: <20220520195809.4855-1-alex.kiernan@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 20 May 2022 19:58:19 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/165951 hid2hci moved to bluez4 in 2011. The FILES changes for ${PN} and ${PN}-dev only added existing defaults into the set. Signed-off-by: Alex Kiernan Signed-off-by: Alex Kiernan --- meta/recipes-core/udev/eudev_3.2.11.bb | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/meta/recipes-core/udev/eudev_3.2.11.bb b/meta/recipes-core/udev/eudev_3.2.11.bb index a841a6a86cc1..1b6705ba3058 100644 --- a/meta/recipes-core/udev/eudev_3.2.11.bb +++ b/meta/recipes-core/udev/eudev_3.2.11.bb @@ -51,9 +51,6 @@ do_install:append() { # Use classic network interface naming scheme touch ${D}${sysconfdir}/udev/rules.d/80-net-name-slot.rules - - # hid2hci has moved to bluez4. removed in udev as of version 169 - rm -f ${D}${base_libdir}/udev/hid2hci } do_install:prepend:class-target () { @@ -68,11 +65,7 @@ INITSCRIPT_PARAMS = "start 04 S ." PACKAGES =+ "libudev" PACKAGES =+ "eudev-hwdb" -FILES:${PN} += "${libexecdir} ${nonarch_base_libdir}/udev ${bindir}/udevadm" -FILES:${PN}-dev = "${datadir}/pkgconfig/udev.pc \ - ${includedir}/libudev.h ${libdir}/libudev.so \ - ${includedir}/udev.h ${libdir}/libudev.la \ - ${libdir}/libudev.a ${libdir}/pkgconfig/libudev.pc" +FILES:${PN} += "${nonarch_base_libdir}/udev" FILES:libudev = "${base_libdir}/libudev.so.*" FILES:eudev-hwdb = "${sysconfdir}/udev/hwdb.d" From patchwork Fri May 20 19:58:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Kiernan X-Patchwork-Id: 8327 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E9FDC433FE for ; Fri, 20 May 2022 19:58:19 +0000 (UTC) Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by mx.groups.io with SMTP id smtpd.web10.1972.1653076697788613126 for ; Fri, 20 May 2022 12:58:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=B92pZhPP; spf=pass (domain: gmail.com, ip: 209.85.218.51, mailfrom: alex.kiernan@gmail.com) Received: by mail-ej1-f51.google.com with SMTP id gi33so9001509ejc.3 for ; Fri, 20 May 2022 12:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IAUzc5sUjXwMjAXWkxU/IJcs+b1Nv+583haoK36VOPI=; b=B92pZhPPbqqRcn9OALcxbuMgE7Yp+CqLlmNKVXNmSbJ7wABSoVA80fd7DOfA6odMcS Escgvw7w43YYgDDsZlisQEJpwDGNRtRCwKNE34SU7Xv3or86sF1y1mccNtcwZHAaqfKX 47em7OLdbIapVV12v9zV8u8T3UxuzTLXLG2NM5CEWpPqNLUPP29pfi4RjPzaEL6cFAOp dXiLGlWDM1HN8bZYGUvAqOuUT8+0iZxQF8ZZhtuDqDXhXWwmqGcsdlxskINAr7I2Z/EF vbu1yNlnSXvzHD38uNWGf29BIxnSSMp1jcUNk4FPxLOshXaf55h+Qq3Ehet0AA4IVW/w HahQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IAUzc5sUjXwMjAXWkxU/IJcs+b1Nv+583haoK36VOPI=; b=4C21OUl6e00IxBVhLEyrIhUnlKaXtqfC975ljNPnyRDJFWx0nBRyoGPCX/vnNkY1gN UYikajOjMi0HFCe/5eu9tZGCePTn3UPwsFXKtZ180hD9Obono0jv/VI3nWMjUnw9aatR FtphnSja89H4e7Q3JSMYuI0dLVL/CTs2C+7yenEHqBu3XrH2B58Q6zRyp3aGlQ2ia9+X anLUMYT7lzeSsHq+8Ylw/kWRFXdynNNINlEsY77mk9R3k9E1K87XgBwBurX7nYQRt/h+ hSW+DamsvEkUlp7OrjaVyfdAXbMKJmQPfVkTscSvlVSfkHvlK57EXtmn3eq20U4CsUOz UWbA== X-Gm-Message-State: AOAM531jM9qqfJPU6ynK01fLD1BAc0+fsWhKr9bmdrtKD4M7ypj962Vf qRtPTHhHUXofy0wSHRk7rEtS4PLRyJg= X-Google-Smtp-Source: ABdhPJwFH1+C1+SNXwFVx/kiXmx6QR3QANQY0ABa28tYAP5Y4AvQ87a5YhL3czewZfLiUj0dNiV7jg== X-Received: by 2002:a17:907:c0c:b0:6fe:af28:7304 with SMTP id ga12-20020a1709070c0c00b006feaf287304mr3965601ejc.242.1653076695923; Fri, 20 May 2022 12:58:15 -0700 (PDT) Received: from localhost.localdomain (cust246-dsl91-135-6.idnet.net. [91.135.6.246]) by smtp.gmail.com with ESMTPSA id gx5-20020a1709068a4500b006f3ef214de6sm3448448ejc.76.2022.05.20.12.58.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 May 2022 12:58:15 -0700 (PDT) From: Alex Kiernan To: openembedded-core@lists.openembedded.org Cc: Alex Kiernan , Alex Kiernan Subject: [OE-Core][PATCH v3 3/3] eudev: Use PACKAGE_BEFORE_PN/${PN}, clean up spaces Date: Fri, 20 May 2022 20:58:09 +0100 Message-Id: <20220520195809.4855-3-alex.kiernan@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220520195809.4855-1-alex.kiernan@gmail.com> References: <20220520195809.4855-1-alex.kiernan@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 20 May 2022 19:58:19 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/165952 Use PACKAGE_BEFORE_PN for packages which need to capture files early, switch to idiomatic ${PN} for additional packages. Swap spaces for tabs in shell functions. Signed-off-by: Alex Kiernan Signed-off-by: Alex Kiernan --- meta/recipes-core/udev/eudev_3.2.11.bb | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/meta/recipes-core/udev/eudev_3.2.11.bb b/meta/recipes-core/udev/eudev_3.2.11.bb index 1b6705ba3058..2d4c44b1dd7f 100644 --- a/meta/recipes-core/udev/eudev_3.2.11.bb +++ b/meta/recipes-core/udev/eudev_3.2.11.bb @@ -62,27 +62,26 @@ do_install:prepend:class-target () { INITSCRIPT_NAME = "udev" INITSCRIPT_PARAMS = "start 04 S ." -PACKAGES =+ "libudev" -PACKAGES =+ "eudev-hwdb" +PACKAGE_BEFORE_PN = "libudev ${PN}-hwdb" FILES:${PN} += "${nonarch_base_libdir}/udev" FILES:libudev = "${base_libdir}/libudev.so.*" -FILES:eudev-hwdb = "${sysconfdir}/udev/hwdb.d" +FILES:${PN}-hwdb = "${sysconfdir}/udev/hwdb.d" -RDEPENDS:eudev-hwdb += "eudev" +RDEPENDS:${PN}-hwdb += "${PN}" RPROVIDES:${PN} = "hotplug udev" -RPROVIDES:eudev-hwdb += "udev-hwdb" +RPROVIDES:${PN}-hwdb += "udev-hwdb" PACKAGE_WRITE_DEPS += "qemu-native" -pkg_postinst:eudev-hwdb () { - if test -n "$D"; then - $INTERCEPT_DIR/postinst_intercept update_udev_hwdb ${PKG} mlprefix=${MLPREFIX} binprefix=${MLPREFIX} - else - udevadm hwdb --update - fi +pkg_postinst:${PN}-hwdb () { + if test -n "$D"; then + $INTERCEPT_DIR/postinst_intercept update_udev_hwdb ${PKG} mlprefix=${MLPREFIX} binprefix=${MLPREFIX} + else + udevadm hwdb --update + fi } -pkg_prerm:eudev-hwdb () { - rm -f $D${sysconfdir}/udev/hwdb.bin +pkg_prerm:${PN}-hwdb () { + rm -f $D${sysconfdir}/udev/hwdb.bin }