From patchwork Wed Apr 20 13:21:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 6964 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7930C54EC4 for ; Thu, 21 Apr 2022 16:46:07 +0000 (UTC) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.groups.io with SMTP id smtpd.web12.7553.1650460929568080602 for ; Wed, 20 Apr 2022 06:22:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=aSpK+T6M; spf=pass (domain: linuxfoundation.org, ip: 209.85.221.49, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wr1-f49.google.com with SMTP id x18so2292945wrc.0 for ; Wed, 20 Apr 2022 06:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=cFZBQ9EZwvUIVW3U6Z6c5g9Jb1/X3JR5JDFv25fXGYA=; b=aSpK+T6MH0fhwHGS2upCzmqhgztziRc7vPdDtxfTnf1eMtt4r8vrqeEeIY7NOB15Z/ +rTCefMnWdI0KkucCDcRTZJxJZXlkjZTIfAuZnA31jM+ZM9mGIzs07NMDX2xZgcvhWYh xgaxyd+TFVHSY2/FDvwdl1a4p4vG34Z1X3USs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=cFZBQ9EZwvUIVW3U6Z6c5g9Jb1/X3JR5JDFv25fXGYA=; b=38ypFLCpwi5vWjFwv3f4lAFxlWmL8l0HwQA6alQuMwTqbApn7Lbr3OdqJivR6UAo7r zqc7GMrGBGC+ROE5PAzfH23BiMePwyQePc0kvr7FxCS1tq/QWi/7POPId3f7kJccNCO/ CatsLJQEu5cHa6i4N2wfdwzGkKFlmzcRt4OIV8KFBcERCOb6oqw+xTLTKlHGNPYxijTe 9Sm7g2XNb5oXb7KmOgTTdjwSwjMwGUVB1BoRm/mOwG1kK3ksmsx9rwtZ7fgHYMuI+4iT FezY8IWECUK9BjO+Ma5qm3tyHiZ7dr5f3P8gjAFF8wmJK2U+L0Cy1H2WothUI/9xvpml ELFA== X-Gm-Message-State: AOAM532BXTAVU/yq5yWxfHlD7E5uPElqAhxczUhspTxvCifNJtu8uxSd hg822N0RRH4pRH74V5Tj2YOVfXnz9H+r4w== X-Google-Smtp-Source: ABdhPJy2T9LX8di90QSUfV4CeBIOG0YTFt9gFlWK19upbKi3LntlMOwfLTkwoa5++IJJ+aESpV1sww== X-Received: by 2002:a05:6000:18c3:b0:206:1575:ec8f with SMTP id w3-20020a05600018c300b002061575ec8fmr15084579wrq.479.1650460927186; Wed, 20 Apr 2022 06:22:07 -0700 (PDT) Received: from hex.int.rpsys.net ([2001:8b0:aba:5f3c:9745:8b8f:81da:af07]) by smtp.gmail.com with ESMTPSA id a7-20020adffb87000000b00207982c7f4dsm15213265wrr.67.2022.04.20.06.22.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 06:22:06 -0700 (PDT) From: Richard Purdie To: bitbake-devel@lists.openembedded.org Subject: [PATCH 01/11] server/process: Drop unused import Date: Wed, 20 Apr 2022 14:21:55 +0100 Message-Id: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 21 Apr 2022 16:46:07 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/13643 Signed-off-by: Richard Purdie --- lib/bb/server/process.py | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/bb/server/process.py b/lib/bb/server/process.py index 19ef83980f..613956f30f 100644 --- a/lib/bb/server/process.py +++ b/lib/bb/server/process.py @@ -20,7 +20,6 @@ import os import sys import time import select -import signal import socket import subprocess import errno From patchwork Wed Apr 20 13:21:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 6963 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A0EC49EA4 for ; Thu, 21 Apr 2022 16:46:07 +0000 (UTC) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.groups.io with SMTP id smtpd.web09.7558.1650460929836573856 for ; Wed, 20 Apr 2022 06:22:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=Zrtm0Nd1; spf=pass (domain: linuxfoundation.org, ip: 209.85.128.53, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wm1-f53.google.com with SMTP id u17-20020a05600c211100b0038eaf4cdaaeso3679685wml.1 for ; Wed, 20 Apr 2022 06:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=2ESB2HDp2j/b40LRr7ps7flFyl/LRPaWi2mr+t8F9hk=; b=Zrtm0Nd13zhQC47RcO8UsTfM4x31+qR+KhranvumgbwBZ+VASVFqT3UpJjfAH3M6Gv RnOStIVdtjf0x7MbVgvLJ2PmUWLhz5Art/6uKviUr0C/H3f0mE/r9Y2MdlBfacdFMQ8e szMmHGdnvG0W02cXDcX5YQh1n2sweNewzc6lY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2ESB2HDp2j/b40LRr7ps7flFyl/LRPaWi2mr+t8F9hk=; b=1Xz4v1I6oufslLDQroLQBKYQTZTqoQSRB1E/Md+uIQ5k9EBIftmCSOShv/J0YVOXZT fdu3Ky+6QKNSlJA6j6fw9X+QGvulGx/Mcd6BmjjnE1hBrWXCnjd+/55sNjYyE9DrvyfA ZfxA5K8F7KF4YRtF3/a15RFEc+mLXjJNq7yS8vRxdmT78oKaKM7M/OqEqSpJLvi+io+a lKwqfl2ObpL4Rnbeajnc4USYZxrri6gDiV4vdFC8XFG1f2WaN9PSaJWt3uT1r6pWQaIn vU+esKtt/GrdeZl8eT4mJQi8MFNncExdyVIzttxaOP3TTpnYc4vRp0zjqsomPJyp3T5H byXw== X-Gm-Message-State: AOAM533HyTvhT30JhhkokXywHQt25kumAtUVZQMXrYDBLXIHGebLcrYM dQrrkJgSgMauhgpyaooIm7LISMWBILXrmQ== X-Google-Smtp-Source: ABdhPJy4CrF6qK0Ht1QIzSlOQqFRYAupOkvg3rcO/6yd1oSczjrDtGkV3V4izwvNCmYNOcWwsofFvQ== X-Received: by 2002:a05:600c:c8:b0:38e:cff5:4cf6 with SMTP id u8-20020a05600c00c800b0038ecff54cf6mr3679768wmm.162.1650460927993; Wed, 20 Apr 2022 06:22:07 -0700 (PDT) Received: from hex.int.rpsys.net ([2001:8b0:aba:5f3c:9745:8b8f:81da:af07]) by smtp.gmail.com with ESMTPSA id a7-20020adffb87000000b00207982c7f4dsm15213265wrr.67.2022.04.20.06.22.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 06:22:07 -0700 (PDT) From: Richard Purdie To: bitbake-devel@lists.openembedded.org Subject: [PATCH 02/11] ui/buildinfohelper: Drop unused import Date: Wed, 20 Apr 2022 14:21:56 +0100 Message-Id: <20220420132205.2530591-2-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> References: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 21 Apr 2022 16:46:07 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/13644 Signed-off-by: Richard Purdie --- lib/bb/ui/buildinfohelper.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bb/ui/buildinfohelper.py b/lib/bb/ui/buildinfohelper.py index 0761f73b3b..9c4215f9a2 100644 --- a/lib/bb/ui/buildinfohelper.py +++ b/lib/bb/ui/buildinfohelper.py @@ -45,7 +45,7 @@ from pprint import pformat import logging from datetime import datetime, timedelta -from django.db import transaction, connection +from django.db import transaction # pylint: disable=invalid-name From patchwork Wed Apr 20 13:21:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 6962 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7244C49ED8 for ; Thu, 21 Apr 2022 16:46:07 +0000 (UTC) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.groups.io with SMTP id smtpd.web10.7434.1650460931691626541 for ; Wed, 20 Apr 2022 06:22:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=H2SVKCXP; spf=pass (domain: linuxfoundation.org, ip: 209.85.221.54, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wr1-f54.google.com with SMTP id b19so2221836wrh.11 for ; Wed, 20 Apr 2022 06:22:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=TupQgpVzOFMI9lhugkyghWjKmh8CGqgiQiKaUOS1O2I=; b=H2SVKCXPNBTdQeupk8ZdrL5cuqSqMQWfAH3LXVB5OFCphM7/OpS01voRl3gkb9fpU3 1yzwla2f1gVBuCYG9TPIx49wQCTdTbWisgwCxE4w+hfYcfEf48k+QpaVwYvUYo14xKBU GIGRd3477XAZ5fL3Kb/LvrkPRoUXB2FWjGShM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TupQgpVzOFMI9lhugkyghWjKmh8CGqgiQiKaUOS1O2I=; b=tvsIfibRkjD4h2z+tIlC2hGLw8UgQaLZN0BIHYPufHViZMS+WUBxop7RsvAH/JV7xi e3TpxIh1oomKfiFzou7VUe+p7tKFFtaML5Js//ueGNW++l5BjWXD5MjzeNALW5H9na/x 9Mwf9JNWnVqhsCoWhLzSs3yTHwh64ED8N0/WFjUSn3iqj7Js5gZxG0CsJS/6rtS8Z/DC Z+cxrZ/4Ko4dbqSlza0D74cHAiq+ZOOfGgdgGVRe7r6PHPJ0WWNarxYfNOGn94ulY8Pt rvPctuvxL4vEiMfYK8Z70/rUgZaypWLSq8YTfIYQ8xtOLvwELdUoUeVRwA1JRKCadBGP fAnA== X-Gm-Message-State: AOAM533odJlbhm8XnsNd/v0eLjBpygy0bTMwo/r1Eqp5OFbHD9U2SI+d BVlWTFnU9DZsDh+gcwFnadcegJZzVgylKw== X-Google-Smtp-Source: ABdhPJxgxZgc4zWGUCx+1+nwyU838T08I+U1ijbWyRcC9TDnfRmq+hV2zdeZQeF4zNC7achKl9uJtQ== X-Received: by 2002:a05:6000:15c6:b0:20a:8f8b:d029 with SMTP id y6-20020a05600015c600b0020a8f8bd029mr13568291wry.319.1650460929803; Wed, 20 Apr 2022 06:22:09 -0700 (PDT) Received: from hex.int.rpsys.net ([2001:8b0:aba:5f3c:9745:8b8f:81da:af07]) by smtp.gmail.com with ESMTPSA id a7-20020adffb87000000b00207982c7f4dsm15213265wrr.67.2022.04.20.06.22.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 06:22:08 -0700 (PDT) From: Richard Purdie To: bitbake-devel@lists.openembedded.org Subject: [PATCH 03/11] cooker: Drop unused loop Date: Wed, 20 Apr 2022 14:21:57 +0100 Message-Id: <20220420132205.2530591-3-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> References: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 21 Apr 2022 16:46:07 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/13645 Signed-off-by: Richard Purdie --- lib/bb/cooker.py | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py index 7685db11f3..701e49339a 100644 --- a/lib/bb/cooker.py +++ b/lib/bb/cooker.py @@ -763,19 +763,18 @@ class BBCooker: taskdata[mc].add_unresolved(localdata[mc], self.recipecaches[mc]) mcdeps |= set(taskdata[mc].get_mcdepends()) new = False - for mc in self.multiconfigs: - for k in mcdeps: - if k in seen: - continue - l = k.split(':') - depmc = l[2] - if depmc not in self.multiconfigs: - bb.fatal("Multiconfig dependency %s depends on nonexistent multiconfig configuration named configuration %s" % (k,depmc)) - else: - logger.debug("Adding providers for multiconfig dependency %s" % l[3]) - taskdata[depmc].add_provider(localdata[depmc], self.recipecaches[depmc], l[3]) - seen.add(k) - new = True + for k in mcdeps: + if k in seen: + continue + l = k.split(':') + depmc = l[2] + if depmc not in self.multiconfigs: + bb.fatal("Multiconfig dependency %s depends on nonexistent multiconfig configuration named configuration %s" % (k,depmc)) + else: + logger.debug("Adding providers for multiconfig dependency %s" % l[3]) + taskdata[depmc].add_provider(localdata[depmc], self.recipecaches[depmc], l[3]) + seen.add(k) + new = True for mc in self.multiconfigs: taskdata[mc].add_unresolved(localdata[mc], self.recipecaches[mc]) From patchwork Wed Apr 20 13:21:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 6961 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1082C54EC5 for ; Thu, 21 Apr 2022 16:46:07 +0000 (UTC) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mx.groups.io with SMTP id smtpd.web08.7668.1650460934218327873 for ; Wed, 20 Apr 2022 06:22:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=RBXULpw8; spf=pass (domain: linuxfoundation.org, ip: 209.85.221.48, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wr1-f48.google.com with SMTP id c10so2275704wrb.1 for ; Wed, 20 Apr 2022 06:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=a0rYC266jhSdp9QOkdvRKMi0i0dQpgYSAKIXPIH98hA=; b=RBXULpw8vqJIIUgoCSNW4PGmODP6y/a+CoS6/FkKPJumlSvKnxj+0Baew2dDFDW4Cs qziLWXLkKA7sHTOoRy89UY/ClEt+2zR4gSbNaZlfC4ldCAQjH8Zi4t+bUcrODWfSFczg vH6I4YLYf39oh//Ssk+tlLGoz8tgKELbkfsuA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a0rYC266jhSdp9QOkdvRKMi0i0dQpgYSAKIXPIH98hA=; b=zlLhdmru4g9REHQkxNSFcELUAKvlRZthW3kF0gBidur9cHU4W13kX4fpW+obTGatEw MtHt2IkM9Q9MdKY7GjKzWnrE5CF5+BfvJax9RiMjM5UOj6puh+lB5OAEHun9c9MqJtnE 6tsI6KWX/bM+tB8jDvHmzdRN4fwwsRv86lAtYcEDXdgF4C2bk6BNaE/bN69WlH7ppW0l ZqSWX8Vf0ybP0M59muNg8HNLxfkcR2ojZaYewIX4ehRHPF/xPgdLrvrzY1JwAtUOT7mF GTTAK6SEOmKDhHDkckbJTjWJvhus6bFBfabuLjXM033SN7ptXmpCyaKvovxmyqoM4Rmi ObKQ== X-Gm-Message-State: AOAM531Bkmt632do3IuvkscAohYFmhkKaB31enuNycskS930jRWNazLE a69iD/matn8OxtAI+UhyUgAPMHah6Q1/IQ== X-Google-Smtp-Source: ABdhPJyqyl5lsgwUWXRlA/Al+P0bbxz7ivp7AJI/gtZUpIgmlf49vBfSyzzNnEKhSFYojkGaDfEOMA== X-Received: by 2002:a05:6000:18c9:b0:203:fb67:debe with SMTP id w9-20020a05600018c900b00203fb67debemr15542642wrq.494.1650460932198; Wed, 20 Apr 2022 06:22:12 -0700 (PDT) Received: from hex.int.rpsys.net ([2001:8b0:aba:5f3c:9745:8b8f:81da:af07]) by smtp.gmail.com with ESMTPSA id a7-20020adffb87000000b00207982c7f4dsm15213265wrr.67.2022.04.20.06.22.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 06:22:10 -0700 (PDT) From: Richard Purdie To: bitbake-devel@lists.openembedded.org Subject: [PATCH 04/11] msg: Drop unused local variable Date: Wed, 20 Apr 2022 14:21:58 +0100 Message-Id: <20220420132205.2530591-4-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> References: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 21 Apr 2022 16:46:07 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/13646 Signed-off-by: Richard Purdie --- lib/bb/msg.py | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/bb/msg.py b/lib/bb/msg.py index c95a874beb..93575d89c4 100644 --- a/lib/bb/msg.py +++ b/lib/bb/msg.py @@ -133,7 +133,6 @@ class LogFilterShowOnce(logging.Filter): self.seen_errors = set() def filter(self, record): - msg = record.msg if record.levelno == bb.msg.BBLogFormatter.WARNONCE: if record.msg in self.seen_warnings: return False From patchwork Wed Apr 20 13:21:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 6966 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1248C54EFD for ; Thu, 21 Apr 2022 16:46:07 +0000 (UTC) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mx.groups.io with SMTP id smtpd.web12.7557.1650460936460769471 for ; Wed, 20 Apr 2022 06:22:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=SSWR/V92; spf=pass (domain: linuxfoundation.org, ip: 209.85.128.42, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wm1-f42.google.com with SMTP id y21so1194954wmi.2 for ; Wed, 20 Apr 2022 06:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=DtP5hvd97d2Ceil/a80jbnVE7gYOnRA1kiOcqF+OLk0=; b=SSWR/V92TfUFex7oGsZclEXpyrS2AiCNAYFe8c2Ps6kwZ4D8tLRqacw6jgpwhQUCOI AJhzRlCtwWFBvK6Doujp8yXvCVpjLc92v1WoumBGmfsC+ozd463+fO/J2RmS1lqMQJ4S 0jI8Sc8S35CdhDFbg6MyaIpJMOkphCGI4PeOw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DtP5hvd97d2Ceil/a80jbnVE7gYOnRA1kiOcqF+OLk0=; b=EaHKBdpVh8YWFmpRLrYCbdhZqevnzZ/8FJob+NIvLAzefMODknH8uCO7aNx7IElK3K Ym5VNdOwxkxxibEF8rZ5fMOyFuyzvBCW+wqn46gjFjxq9/wOyjJowlpTcG0raVpnFRJ5 4NM+QZmoFT0DQHi3GVOlgRferBenvbcUcGMhF8+0VwPtoTm2sPjuUoyN5gGg24QjoSW6 J5hrSh9URNZt7xYs6iwdz1fDdpI7qRyc8GaDI6ZlNo6JBWFY+ET/QeK+c/J/z2idFec2 ALDvukcq+lir0hR+iAUELVZf+LWGZDKYemzZDAlitZ1D+RU6a8vwx2IYyoG2Uvi2smen +lWw== X-Gm-Message-State: AOAM5338/N6WHsu9qBhi4AP6GoOlqyL9PAAEpHqNY3VMZfCrQMx0Cwjk h5zDWOhE+cEi/Hm+Ip9GcGdgdB6HvxhymA== X-Google-Smtp-Source: ABdhPJyShx37z5clt/7ycyUyw+JrRco28BEaIZIX2sMwXo0Rj7KOdPFGCM+CPw4+TQvJVPtLxj/KDg== X-Received: by 2002:a05:600c:1e86:b0:391:62c4:fb72 with SMTP id be6-20020a05600c1e8600b0039162c4fb72mr3588534wmb.119.1650460934387; Wed, 20 Apr 2022 06:22:14 -0700 (PDT) Received: from hex.int.rpsys.net ([2001:8b0:aba:5f3c:9745:8b8f:81da:af07]) by smtp.gmail.com with ESMTPSA id a7-20020adffb87000000b00207982c7f4dsm15213265wrr.67.2022.04.20.06.22.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 06:22:12 -0700 (PDT) From: Richard Purdie To: bitbake-devel@lists.openembedded.org Subject: [PATCH 05/11] buildinfohelper: Drop unused function Date: Wed, 20 Apr 2022 14:21:59 +0100 Message-Id: <20220420132205.2530591-5-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> References: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 21 Apr 2022 16:46:07 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/13647 The function has a loop where the variable is never used which I was going to fix but the entire function never seems to be called so remove it entirely. Signed-off-by: Richard Purdie --- lib/bb/ui/buildinfohelper.py | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/lib/bb/ui/buildinfohelper.py b/lib/bb/ui/buildinfohelper.py index 9c4215f9a2..c4ca267783 100644 --- a/lib/bb/ui/buildinfohelper.py +++ b/lib/bb/ui/buildinfohelper.py @@ -1062,27 +1062,6 @@ class BuildInfoHelper(object): return recipe_info - def _get_path_information(self, task_object): - self._ensure_build() - - assert isinstance(task_object, Task) - build_stats_format = "{tmpdir}/buildstats/{buildname}/{package}/" - build_stats_path = [] - - for t in self.internal_state['targets']: - buildname = self.internal_state['build'].build_name - pe, pv = task_object.recipe.version.split(":",1) - if pe: - package = task_object.recipe.name + "-" + pe + "_" + pv - else: - package = task_object.recipe.name + "-" + pv - - build_stats_path.append(build_stats_format.format(tmpdir=self.tmp_dir, - buildname=buildname, - package=package)) - - return build_stats_path - ################################ ## external available methods to store information From patchwork Wed Apr 20 13:22:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 6965 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E74E9C49EA5 for ; Thu, 21 Apr 2022 16:46:07 +0000 (UTC) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by mx.groups.io with SMTP id smtpd.web09.7559.1650460937513311258 for ; Wed, 20 Apr 2022 06:22:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=Nv++LRQn; spf=pass (domain: linuxfoundation.org, ip: 209.85.221.48, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wr1-f48.google.com with SMTP id e21so2239160wrc.8 for ; Wed, 20 Apr 2022 06:22:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=irlB99RuN1rv1VVg5GuohtZv+h4kYg/zO75CUrxeu/0=; b=Nv++LRQntJptlvi0oVQV/Bbd83pjDAVG9Kg4rVFIp7NohPmsy8WcXKqOaUQ8E5uxa7 w1DVza7wIuB2bqcFQw3ZnwC5/U3DWTEjQDg5AddzqG7kzm4OXusYchMgxUSeWfMeemWy i5m2sdtkWo1IPn2kUL6R564CHncNgJqxMCR6s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=irlB99RuN1rv1VVg5GuohtZv+h4kYg/zO75CUrxeu/0=; b=fvinFkQgMW5s0P1OVGFFwhkQ4vf1HshNIBOLsuFOg4jzWl++bqKVC+xzGzkQ3VA5UK wHTKE2ScmGjYTkl5Rp0YZrQtO5AhupfyD33+N7yFhOCpl8o//5ZKj4JdkpQC/03SyCxE 0/y3dEgmrVhXhRKFsanKr7PZFYGGGRjnWElANcS+RYw4R1A9jBz3NDOvYQc1xUkHHDU0 SwbaobJl18F9UlFWcaEKX/sfXsf4vwuRVQi6MZeoxT8ZPHPlIOz6Nw1MYO8sFh/vYHnu 39E8TW0b6ic8gI1uSUvPSsSSEOZx8+FlTl/9rKIKmVmmXDVueuMkEQF5gEruUieOSha5 C5nA== X-Gm-Message-State: AOAM530tyMGebk/Ian+tnU7Mg8zv3Jll0hA9LGuxHyMbLIMV0nr91a3l Qi4wLapMAU8aPfaVwkRN688Vj/WJzDMcWg== X-Google-Smtp-Source: ABdhPJwzsFKciB2rlIWkvBfCVINRnpaZ9upUrOwHR7ol0X87eqtyK/1QYjQClN+OAfM1+tGsJxZGUQ== X-Received: by 2002:a05:6000:186c:b0:20a:806e:ad8a with SMTP id d12-20020a056000186c00b0020a806ead8amr16227514wri.207.1650460935489; Wed, 20 Apr 2022 06:22:15 -0700 (PDT) Received: from hex.int.rpsys.net ([2001:8b0:aba:5f3c:9745:8b8f:81da:af07]) by smtp.gmail.com with ESMTPSA id a7-20020adffb87000000b00207982c7f4dsm15213265wrr.67.2022.04.20.06.22.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 06:22:14 -0700 (PDT) From: Richard Purdie To: bitbake-devel@lists.openembedded.org Subject: [PATCH 06/11] fetch2/crate: Drop unused import Date: Wed, 20 Apr 2022 14:22:00 +0100 Message-Id: <20220420132205.2530591-6-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> References: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 21 Apr 2022 16:46:07 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/13648 Signed-off-by: Richard Purdie --- lib/bb/fetch2/crate.py | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/bb/fetch2/crate.py b/lib/bb/fetch2/crate.py index aac1221c87..f4ddc782a9 100644 --- a/lib/bb/fetch2/crate.py +++ b/lib/bb/fetch2/crate.py @@ -13,7 +13,6 @@ BitBake 'Fetch' implementation for crates.io import hashlib import json import os -import shutil import subprocess import bb from bb.fetch2 import logger, subprocess_setup, UnpackError From patchwork Wed Apr 20 13:22:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 6972 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE2FC54EFE for ; Thu, 21 Apr 2022 16:46:07 +0000 (UTC) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mx.groups.io with SMTP id smtpd.web09.7560.1650460939231133469 for ; Wed, 20 Apr 2022 06:22:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=dwkzv2Y/; spf=pass (domain: linuxfoundation.org, ip: 209.85.128.45, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wm1-f45.google.com with SMTP id v64-20020a1cac43000000b0038cfd1b3a6dso3661765wme.5 for ; Wed, 20 Apr 2022 06:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=cWwsacm422l5Pf/H7s9KB01hac7eP+1uQMl/d4y469A=; b=dwkzv2Y/+9EGMjx+vJic3Dz0yKOR1xmi6N+5/DZx3lEr3ajcSDSQEVqnz+0+vQ1lYY 5cr7LMe7tVmvhvTNFTzr851Ef96wNB4boTXCyaMogbCOgSf1aegTXSgPUbSypvH0C5/0 LpvwMjXYSLRqxCPeBHJFSjpj2zqI7Bi0J+fk0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cWwsacm422l5Pf/H7s9KB01hac7eP+1uQMl/d4y469A=; b=kVRUMCYza/6en+AE3n5TVp9mCmCLzyrJLlBiettNwI9oDy2lGI3DOYdPvuQArMQmPO tF1Umkxutl53Mf3O8d0FQhndbnx0QQrKmZfACPYTDVp5h1MBGNcWEsp/wy1Sz0z9NGiG ytJ1u77nKttBZsd1dpnzgl8PDWuDZlDg4aJ/v/F+8Jdzwcq+pa4cu1JxqMEetIKinrpg o2HTeBy0iRk/IBwhRvsGqgxYUN2U7cJedP0t0TiGw+h/v2oaFioCYre66Dilr0yn8bsP B2+tVd5Ub2g2fvF6q6DxD2qiKgmxCepMVNQJU8hYEBbbdyUOpyFkB0Pv2kzWezgDii5/ ZfmQ== X-Gm-Message-State: AOAM533TTt0uL1JViepH9VEyTBVb9a9LYpKt12UpUY6En80TVaHkOiE6 DQ4ockYF4gpAeEP95LuVZpadI2W2PoMLwA== X-Google-Smtp-Source: ABdhPJxR+NEKTx1yof4aEdPJ5CjPVYID7QphFmlUzQXcyap4t6o6Njz2AMRMjv9twpbdMmROmbK9FA== X-Received: by 2002:a1c:35c2:0:b0:38e:c75d:90a3 with SMTP id c185-20020a1c35c2000000b0038ec75d90a3mr3692973wma.98.1650460937302; Wed, 20 Apr 2022 06:22:17 -0700 (PDT) Received: from hex.int.rpsys.net ([2001:8b0:aba:5f3c:9745:8b8f:81da:af07]) by smtp.gmail.com with ESMTPSA id a7-20020adffb87000000b00207982c7f4dsm15213265wrr.67.2022.04.20.06.22.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 06:22:16 -0700 (PDT) From: Richard Purdie To: bitbake-devel@lists.openembedded.org Subject: [PATCH 07/11] siggen: Drop pointless break statement Date: Wed, 20 Apr 2022 14:22:01 +0100 Message-Id: <20220420132205.2530591-7-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> References: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 21 Apr 2022 16:46:07 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/13649 Signed-off-by: Richard Purdie --- lib/bb/siggen.py | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py index 130b38d8a7..9fa568f614 100644 --- a/lib/bb/siggen.py +++ b/lib/bb/siggen.py @@ -40,7 +40,6 @@ def init(d): for sg in siggens: if desired == sg.name: return sg(d) - break else: logger.error("Invalid signature generator '%s', using default 'noop'\n" "Available generators: %s", desired, From patchwork Wed Apr 20 13:22:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 6971 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF551C54F3B for ; Thu, 21 Apr 2022 16:46:07 +0000 (UTC) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.groups.io with SMTP id smtpd.web08.7669.1650460941067716561 for ; Wed, 20 Apr 2022 06:22:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=XUZurLKd; spf=pass (domain: linuxfoundation.org, ip: 209.85.221.41, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wr1-f41.google.com with SMTP id u3so2266026wrg.3 for ; Wed, 20 Apr 2022 06:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=rLpFsHpkQh9sdD3II14kz2ZGwVlMdiZBGb75Hr9cUGs=; b=XUZurLKd8IhI7KY+/eOk6XvW92rhvdHqBbBEgsMBeWbUjEmQUqeUErcc0r29JQMkui +aUtzBI57UkFxZ6xT9Qn1xql0jJux1mlgyJds1cJ2izpR3LXHtQszniMNBxDtjyb78sv BhsizCihPAgusa3u+6TQvP16QvGbeqXU5QkXo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rLpFsHpkQh9sdD3II14kz2ZGwVlMdiZBGb75Hr9cUGs=; b=DetPemxbbYFSW9yFMjtce06WCJa+UG2yXiPvXgrrAJ5FiCkgY1q2v0ys1iE6q6bN7O /bffH8S3jVeJYQlmkbDkYq6laOP1UyV6fwby6FP8z949Q+O14SPKVOMriUAtbAvUOSTe y2ZNGQd7oeyENTIfZMWjtzlYpiywTc0Rwgvtv74LAWPFC0yQ5Bq/1a9ORSuAQRwoPr6+ dwHYcfEQBt/PWMa682ig79GEW8VW2TufDVkcrk/s81sJJQhyzGXuVPrSVl2waubzIO9v taJutUVXPFz5jplydmy/Wn/YDELSROe2+cDHHr3gGWz9Gclr6RN/F2XPNb+qv0u89okk 93gA== X-Gm-Message-State: AOAM533GwijaRDCNu4LB1zPktZeujVSsDebSdxTs9pjw3CuFI2/gkLj1 cjEVkeIkB2m5Nk955gWdcRPvQ3f/QuIBtA== X-Google-Smtp-Source: ABdhPJwKW8gRppoVZi2K3fQMJEvx9wGLJ48lSG8vWbvQ4i7EMDbEWYyTURtJsQMi+mODpz7w/3U6kQ== X-Received: by 2002:a05:6000:188b:b0:20a:a7f4:2f8 with SMTP id a11-20020a056000188b00b0020aa7f402f8mr5700891wri.424.1650460939011; Wed, 20 Apr 2022 06:22:19 -0700 (PDT) Received: from hex.int.rpsys.net ([2001:8b0:aba:5f3c:9745:8b8f:81da:af07]) by smtp.gmail.com with ESMTPSA id a7-20020adffb87000000b00207982c7f4dsm15213265wrr.67.2022.04.20.06.22.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 06:22:18 -0700 (PDT) From: Richard Purdie To: bitbake-devel@lists.openembedded.org Subject: [PATCH 08/11] ui/knotty: Drop pointless pass statement Date: Wed, 20 Apr 2022 14:22:02 +0100 Message-Id: <20220420132205.2530591-8-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> References: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 21 Apr 2022 16:46:07 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/13650 Signed-off-by: Richard Purdie --- lib/bb/ui/knotty.py | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/bb/ui/knotty.py b/lib/bb/ui/knotty.py index 3f410fd525..61cf0a37f4 100644 --- a/lib/bb/ui/knotty.py +++ b/lib/bb/ui/knotty.py @@ -877,7 +877,6 @@ def main(server, eventHandler, params, tf = TerminalFilter): state_force_shutdown() main.shutdown = main.shutdown + 1 - pass except Exception as e: import traceback sys.stderr.write(traceback.format_exc()) From patchwork Wed Apr 20 13:22:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 6969 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00BFCC54F3E for ; Thu, 21 Apr 2022 16:46:08 +0000 (UTC) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.groups.io with SMTP id smtpd.web11.7587.1650460943012052541 for ; Wed, 20 Apr 2022 06:22:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=WZoRWk95; spf=pass (domain: linuxfoundation.org, ip: 209.85.221.50, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wr1-f50.google.com with SMTP id x18so2293812wrc.0 for ; Wed, 20 Apr 2022 06:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=mmq0SKSEnF3Ofzg2BsaQaxqx1kHDdsEwRPhe0rnUsks=; b=WZoRWk95g26E7kGWsPOa0Cgkng50zTJ5+sh3qnA3R8ewjZ87w4+9NAy2CBB80f/lH1 aM2GfAraY594leOoxiMsuxEag2piklFcNP4MWpXLRV3s27FWUs7W082dTdCyEgT8pDsp MjdJ8b4m+TUNUlo5HHDR1pNr+ovFlaibFPiK4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mmq0SKSEnF3Ofzg2BsaQaxqx1kHDdsEwRPhe0rnUsks=; b=dFVEGxIm0uRzlq8b8FC6hzpZzSeAsU5wKsi9AI9Awf3ANxq784QHf1fNUbeHOxD9f7 JIqMyOS/sUIFfEMuzoXM2Hth4tuAKi03LpgBgojoo4bMBrFW19EpTI8PDGm0F1s31Wvs Bi4kaKORp2M+97Bl0HWN0C9w4etb6Yiogiqb31FPIkwyHIPzTv7k7f1SnbSkeQu7INi0 Sn3+vIP/0xa9nkyg0utF+AMF3GNeRL6btAZhP2Hv7dmBDzoT5qKrpjK/EZWOpX1//Anp zqQDI6Hc4EIxW3uUuxgd7v64bPV91JuSOtaR4hvEci4VPi75/QGfjYe/HtCIAJkRwOUO Ahxw== X-Gm-Message-State: AOAM531FSOi1NXVwW9h29JYHz4khSYvtbbznRUVdLDpRhKXrcB4Zl1Gn 4uFlbQlEcDlLa6wMeFk+AMbaIHVQG/SCgA== X-Google-Smtp-Source: ABdhPJyxJ1cL1NhsAJUeLr5kmBhUWDDTCE52siiXg5LEW31IWjQFTpdkwsdoAL27SL55fqdPzh7LEQ== X-Received: by 2002:adf:ef01:0:b0:20a:8068:ca5e with SMTP id e1-20020adfef01000000b0020a8068ca5emr15465746wro.661.1650460941000; Wed, 20 Apr 2022 06:22:21 -0700 (PDT) Received: from hex.int.rpsys.net ([2001:8b0:aba:5f3c:9745:8b8f:81da:af07]) by smtp.gmail.com with ESMTPSA id a7-20020adffb87000000b00207982c7f4dsm15213265wrr.67.2022.04.20.06.22.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 06:22:19 -0700 (PDT) From: Richard Purdie To: bitbake-devel@lists.openembedded.org Subject: [PATCH 09/11] persist_data: Use a valid exception for missing implementation Date: Wed, 20 Apr 2022 14:22:03 +0100 Message-Id: <20220420132205.2530591-9-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> References: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 21 Apr 2022 16:46:07 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/13651 Signed-off-by: Richard Purdie --- lib/bb/persist_data.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bb/persist_data.py b/lib/bb/persist_data.py index 9e20a837a4..ce84a15825 100644 --- a/lib/bb/persist_data.py +++ b/lib/bb/persist_data.py @@ -208,7 +208,7 @@ class SQLTable(collections.abc.MutableMapping): def __lt__(self, other): if not isinstance(other, Mapping): - raise NotImplemented + raise NotImplementedError() return len(self) < len(other) From patchwork Wed Apr 20 13:22:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 6970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 059DAC54F3D for ; Thu, 21 Apr 2022 16:46:08 +0000 (UTC) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.groups.io with SMTP id smtpd.web12.7559.1650460944513547156 for ; Wed, 20 Apr 2022 06:22:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=C2cIVLav; spf=pass (domain: linuxfoundation.org, ip: 209.85.221.42, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wr1-f42.google.com with SMTP id i20so2222982wrb.13 for ; Wed, 20 Apr 2022 06:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=JLynCYJlUkdO+NxDVBbLTENpwfD/FtQA2myc4RLQJqc=; b=C2cIVLavWDQ1h/+MqEXuXBA+A9NQFuD8VVwOQrN87N/KY4hoG86gEC72cSWUUiOxpP xeB01I9V20k1qP2okhh+rjmSwI4fft3oUXRchGd+UoXz3ARQll5inWwYhqjRozuNZ7Jh y4AYgvTl1mP67JWsN92zFMRb6J8N6vDiIlijI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JLynCYJlUkdO+NxDVBbLTENpwfD/FtQA2myc4RLQJqc=; b=0WY9qLVIcLGdIb9GUykOS33IiXo3V+mbYzFBjLZuOWyA0wBWrI6Ai1Mcz4kJtbPN4B QWVEDpt4YBJPEcgrBPtXLLRObCF0uMm2VaBiBHIHP0EEsMbphuLV1sKM3AigjsSiF/W0 JB/i93nLrp6r8uZSOg8/tZw/30yZaHmKm3kWLREvaQbD6Fw+YJoHzzu5pa8SyiuI8rfW w1FEkywgikLtuaf0C/FJEOWVtZdpeE+EdRXy0hu/Xh1t6bCFjKs+zXjqul+eKveVTnUg G/OczpSA2tAKa0gjKLrJtoND3RT9S6uXd5xmqQ6hsfAzRHUbhdMedMsiTn/GOqQhINta jKyg== X-Gm-Message-State: AOAM533EIzpIvJ805AgdijjyTJTStzt/2IWnSGn1vxkJ4qYKK1LJjflf F7wG8mV4l39ui8UGuls8CSd2fkMzLOVSnQ== X-Google-Smtp-Source: ABdhPJxumPfvWpLcmvflekZySwDBb9JhuBNvKr0sCtjC4DjJpBug39gAvLtDvuZUEgtfzOBgOoiFDw== X-Received: by 2002:adf:f2cb:0:b0:20a:77c2:3958 with SMTP id d11-20020adff2cb000000b0020a77c23958mr15222028wrp.589.1650460942696; Wed, 20 Apr 2022 06:22:22 -0700 (PDT) Received: from hex.int.rpsys.net ([2001:8b0:aba:5f3c:9745:8b8f:81da:af07]) by smtp.gmail.com with ESMTPSA id a7-20020adffb87000000b00207982c7f4dsm15213265wrr.67.2022.04.20.06.22.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 06:22:22 -0700 (PDT) From: Richard Purdie To: bitbake-devel@lists.openembedded.org Subject: [PATCH 10/11] runqueue: Drop pointless variable assignment Date: Wed, 20 Apr 2022 14:22:04 +0100 Message-Id: <20220420132205.2530591-10-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> References: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 21 Apr 2022 16:46:08 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/13652 This is set at the start of the loop anyway so it does nothing. Drop the pointless code. Signed-off-by: Richard Purdie --- lib/bb/runqueue.py | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py index a7a84630d7..a4e82f375c 100644 --- a/lib/bb/runqueue.py +++ b/lib/bb/runqueue.py @@ -2664,7 +2664,6 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq): sq_revdeps_squash[point] = set() if point in rqdata.runq_setscene_tids: sq_revdeps_squash[point] = tasks - tasks = set() continue for dep in rqdata.runtaskentries[point].depends: if point in sq_revdeps[dep]: From patchwork Wed Apr 20 13:22:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Purdie X-Patchwork-Id: 6968 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06A3EC54F46 for ; Thu, 21 Apr 2022 16:46:08 +0000 (UTC) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mx.groups.io with SMTP id smtpd.web10.7439.1650460946168808984 for ; Wed, 20 Apr 2022 06:22:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=QMQ/FDwL; spf=pass (domain: linuxfoundation.org, ip: 209.85.221.47, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wr1-f47.google.com with SMTP id c10so2276420wrb.1 for ; Wed, 20 Apr 2022 06:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=G1flh5HXMK62lZGkrqe57PczKhRCq7n0oKGcHLpbzu0=; b=QMQ/FDwLYO2PBjor2LTFqCCp0LUxKcCZK/GtNIVe6dzqhq/rJwzGq2p+6FltsqzJ7h KCGqMcO+cCleiaY1mHOx40hY+y8tmmkYXB0ure/KHUR3ND4YbHJoKjAtF6ehTCTCk09Q JpsDDj+QXHUseu2xbmW6a6zWFXIDJpR7llqV0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G1flh5HXMK62lZGkrqe57PczKhRCq7n0oKGcHLpbzu0=; b=IhmP8253vf3XR7hbw+eZNVcTobUwgIHHUiWO1C0LcdiGymX+FGkMnzTL6lgZSHLv01 ph92MA5gZ5nAc5K4+VutrgR6cGsHDm6tcIDfgT4sxhU7tphyJ2e3nANsC+J1XIdJwYyb BRC5b6tR1R8Xv3yEx0frZ7cfVUZ7FOP4pyt2KDws6E00d0hicoyMOWd8i9sobBB3CfcC xi3mtMoLeIAn5gUhx82iNWSZm/BNusPe+q2kZfrGPhF+rBzvgk1t8wH+3xVAE+fMlKMt 8R0x/tUMwVq9cWd6R8yQSdWgDgfPziHuye/oksA6FRu4+Gqx5OC0ja96/JSrq9wz99Lq fd5w== X-Gm-Message-State: AOAM533sHdWz/waz/C3Q96mg36Id7YjlYEz5JvqlyTK0GM+hyFU5gHrY vtibNviyDi5Dia4ob1NLgEDXkFZaMHWoCw== X-Google-Smtp-Source: ABdhPJwi+BPkpyw2nMEaVq5AVFhYlJB5TqPFDuAP02kMKrQ17R69E+b51+xqmGVUusP4G5ItjDbAIg== X-Received: by 2002:a5d:4085:0:b0:207:b13e:e8dd with SMTP id o5-20020a5d4085000000b00207b13ee8ddmr15527910wrp.557.1650460944265; Wed, 20 Apr 2022 06:22:24 -0700 (PDT) Received: from hex.int.rpsys.net ([2001:8b0:aba:5f3c:9745:8b8f:81da:af07]) by smtp.gmail.com with ESMTPSA id a7-20020adffb87000000b00207982c7f4dsm15213265wrr.67.2022.04.20.06.22.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 06:22:23 -0700 (PDT) From: Richard Purdie To: bitbake-devel@lists.openembedded.org Subject: [PATCH 11/11] buildinfohelper: Drop unused variables Date: Wed, 20 Apr 2022 14:22:05 +0100 Message-Id: <20220420132205.2530591-11-richard.purdie@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> References: <20220420132205.2530591-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 21 Apr 2022 16:46:08 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/13653 Signed-off-by: Richard Purdie --- lib/bb/ui/buildinfohelper.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/bb/ui/buildinfohelper.py b/lib/bb/ui/buildinfohelper.py index c4ca267783..129bb329c3 100644 --- a/lib/bb/ui/buildinfohelper.py +++ b/lib/bb/ui/buildinfohelper.py @@ -496,7 +496,7 @@ class ORMWrapper(object): if not parent_path: parent_path = "/" parent_obj = self._cached_get(Target_File, target = target_obj, path = parent_path, inodetype = Target_File.ITYPE_DIRECTORY) - tf_obj = Target_File.objects.create( + Target_File.objects.create( target = target_obj, path = path, size = size, @@ -561,7 +561,7 @@ class ORMWrapper(object): parent_obj = Target_File.objects.get(target = target_obj, path = parent_path, inodetype = Target_File.ITYPE_DIRECTORY) - tf_obj = Target_File.objects.create( + Target_File.objects.create( target = target_obj, path = path, size = size,