From patchwork Mon Mar 28 07:53:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Khem Raj X-Patchwork-Id: 5905 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0D82C433F5 for ; Mon, 28 Mar 2022 07:53:06 +0000 (UTC) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mx.groups.io with SMTP id smtpd.web08.8418.1648453986398981063 for ; Mon, 28 Mar 2022 00:53:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Wlr0KP5w; spf=pass (domain: gmail.com, ip: 209.85.214.181, mailfrom: raj.khem@gmail.com) Received: by mail-pl1-f181.google.com with SMTP id c23so14135805plo.0 for ; Mon, 28 Mar 2022 00:53:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vZ0XHFnz0+JESVy1fLRx3/vmd790dIznTp5i1zEaXO8=; b=Wlr0KP5w2vVRTch/gfHibqy0oqSbjeIQcaDL3XFbDXwTJGVvNGUYXnwpPwX+YOcnLd JTRTqWEFCROn36+W2bGOhfzaCkN+PFmAS6f+QkyhD8tlXKgTBL9zUSOERPrjk4YqQDyU ScuZp6ehVsxwD6+N1Ml15QzYUEpzEBl6N6XtcKC1c06I15XhfiqXia05c7wdUwZcU8b4 E/DDLBI0m1LOEu/hzkKv1C7nrpNWntBijvrl8sz/yH+KL2Fm5M2wV5sSQppOwpDFZ6bL bJqydzLuKmRtpk2kkqH/RQwK7vTqOWXUMpCxkcLrPvaa87CAqFivi7ZUCSMngeLpIK+C 9X9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vZ0XHFnz0+JESVy1fLRx3/vmd790dIznTp5i1zEaXO8=; b=NpHw1nPZUTUL+sVRkPZpsLgZj80WBYpIzABzEQUBt2C8yWndVYon/ZMDPauLIfX/r6 zCxIA2DbGOMyW8JqrXoMHJWtSF0E9iGWkNzQPFZMXTskC6G10WFKom62oR1XGZjiGP8r dRxEVYLJm04cjHhjtP0XNYklH2mY9sGEtF8UaMwNRp5VD55drZFJzY4jRFvida0UuDIN a1pg1vLRrJvhMBA6Vn3hCyp2QADE7ozpyzwtcqgs4940ujTHkOD9dywBtsjNCa82gJ8N hwpxF6EEeiPEKhB15nS9a9daU8i91IhKTbgIMqC1M/yEVjHSe35FFvleK5tX5VjNNx0n NrmQ== X-Gm-Message-State: AOAM5319gTROBR3y7iDNBhy5Tacpo8bvo0KsRj151ybJi+fXBRJb2y92 hZJA3D043CszgmkrHcAxvVKuq4qAwQ4= X-Google-Smtp-Source: ABdhPJzW/UFpYoBoxeJlsaeQ9vdgqSPrDUIThQ+2HEZY+PTXnhNsy/ZRjHRM1UO98EKHD1YDxyCj5A== X-Received: by 2002:a17:90a:4749:b0:1be:ea64:4348 with SMTP id y9-20020a17090a474900b001beea644348mr39649395pjg.231.1648453985347; Mon, 28 Mar 2022 00:53:05 -0700 (PDT) Received: from apollo.hsd1.ca.comcast.net ([2601:646:9200:a0f0::781b]) by smtp.gmail.com with ESMTPSA id y3-20020a056a00190300b004fa2411bb92sm15275081pfi.93.2022.03.28.00.53.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 00:53:05 -0700 (PDT) From: Khem Raj To: openembedded-core@lists.openembedded.org Cc: Khem Raj Subject: [PATCH 1/2] go: Drop GOBUILDMODE Date: Mon, 28 Mar 2022 00:53:01 -0700 Message-Id: <20220328075303.1519482-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 28 Mar 2022 07:53:06 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/163683 This is local invention which is no longer needed, pie-mode works good now a days to build go for target Signed-off-by: Khem Raj --- meta/recipes-devtools/go/go-1.18.inc | 1 - ...008-use-GOBUILDMODE-to-set-buildmode.patch | 42 ------------------- meta/recipes-devtools/go/go_1.18.bb | 1 - 3 files changed, 44 deletions(-) delete mode 100644 meta/recipes-devtools/go/go-1.18/0008-use-GOBUILDMODE-to-set-buildmode.patch diff --git a/meta/recipes-devtools/go/go-1.18.inc b/meta/recipes-devtools/go/go-1.18.inc index c8cc2796ea9..da61e93b1db 100644 --- a/meta/recipes-devtools/go/go-1.18.inc +++ b/meta/recipes-devtools/go/go-1.18.inc @@ -10,7 +10,6 @@ SRC_URI += "\ file://0005-make.bash-override-CC-when-building-dist-and-go_boot.patch \ file://0006-cmd-dist-separate-host-and-target-builds.patch \ file://0007-cmd-go-make-GOROOT-precious-by-default.patch \ - file://0008-use-GOBUILDMODE-to-set-buildmode.patch \ file://0001-exec.go-do-not-write-linker-flags-into-buildids.patch \ file://0001-src-cmd-dist-buildgo.go-do-not-hardcode-host-compile.patch \ " diff --git a/meta/recipes-devtools/go/go-1.18/0008-use-GOBUILDMODE-to-set-buildmode.patch b/meta/recipes-devtools/go/go-1.18/0008-use-GOBUILDMODE-to-set-buildmode.patch deleted file mode 100644 index 0ede623af97..00000000000 --- a/meta/recipes-devtools/go/go-1.18/0008-use-GOBUILDMODE-to-set-buildmode.patch +++ /dev/null @@ -1,42 +0,0 @@ -From 971b5626339ce0c4d57f9721c9a81af566c5a044 Mon Sep 17 00:00:00 2001 -From: Alex Kube -Date: Wed, 23 Oct 2019 21:19:26 +0430 -Subject: [PATCH 8/9] cmd/go: Use GOBUILDMODE to set buildmode - -Upstream-Status: Denied [upstream choose antoher solution: `17a256b -cmd/go: -buildmode=pie for android/arm'] - -While building go itself, the go build system does not support -to set `-buildmode=pie' from environment. - -Add GOBUILDMODE to support it which make PIE executables the default -build mode, as PIE executables are required as of Yocto - -Refers: https://groups.google.com/forum/#!topic/golang-dev/gRCe5URKewI - -Adapted to Go 1.13 from patches originally submitted to -the meta/recipes-devtools/go tree by -Hongxu Jia - -Signed-off-by: Alexander J Kube ---- - src/cmd/go/internal/work/build.go | 8 +++++++- - 1 file changed, 7 insertions(+), 1 deletion(-) - ---- a/src/cmd/go/internal/work/build.go -+++ b/src/cmd/go/internal/work/build.go -@@ -283,7 +283,13 @@ func AddBuildFlags(cmd *base.Command, ma - - cmd.Flag.Var(&load.BuildAsmflags, "asmflags", "") - cmd.Flag.Var(buildCompiler{}, "compiler", "") -- cmd.Flag.StringVar(&cfg.BuildBuildmode, "buildmode", "default", "") -+ -+ if bm := os.Getenv("GOBUILDMODE"); bm != "" { -+ cmd.Flag.StringVar(&cfg.BuildBuildmode, "buildmode", bm, "") -+ } else { -+ cmd.Flag.StringVar(&cfg.BuildBuildmode, "buildmode", "default", "") -+ } -+ - cmd.Flag.Var(&load.BuildGcflags, "gcflags", "") - cmd.Flag.Var(&load.BuildGccgoflags, "gccgoflags", "") - if mask&OmitModFlag == 0 { diff --git a/meta/recipes-devtools/go/go_1.18.bb b/meta/recipes-devtools/go/go_1.18.bb index 34dc89bb0cc..a492d7e64a1 100644 --- a/meta/recipes-devtools/go/go_1.18.bb +++ b/meta/recipes-devtools/go/go_1.18.bb @@ -3,7 +3,6 @@ require go-target.inc inherit linuxloader -export GOBUILDMODE="" export GO_LDSO = "${@get_linuxloader(d)}" export CC_FOR_TARGET = "gcc" export CXX_FOR_TARGET = "g++" From patchwork Mon Mar 28 07:53:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Khem Raj X-Patchwork-Id: 5906 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0E39C433EF for ; Mon, 28 Mar 2022 07:53:07 +0000 (UTC) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mx.groups.io with SMTP id smtpd.web08.8419.1648453986712569696 for ; Mon, 28 Mar 2022 00:53:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=b03MoUVV; spf=pass (domain: gmail.com, ip: 209.85.214.171, mailfrom: raj.khem@gmail.com) Received: by mail-pl1-f171.google.com with SMTP id i11so2817191plg.12 for ; Mon, 28 Mar 2022 00:53:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TvwQqElRiM3abY1umKoCWnKC5J1cL0J2YX/zw5aeFiI=; b=b03MoUVVqgxNG5vsHOGsMv93LpQlk8Hzlgh7jZ5BmBfIkx/DU9KljMYygmRZqe8+Vi D9ZyQY48CAWW+ylnQ222/rpQZlWsDm/7Odh8SGeGJEk65Fy13JlRDCUjJpq7TD9845Eg wG+TFU7/6MyNedBXXvLT3eYyul5LjmM9Qoo6KsufT2s0tkiCLhRPDiL1L22be9BDVQgJ n+MH+O55LxmJVpXcQQrPZPj832/1qgCzgPcyk4JHhjBe6OTVL5gNlSJ2GDQ/VXHQc2l7 1e38LhfJKmxVSsDym0BGEDoyeoJtfrYHnxWcUyIiO3B/DQnxedX7Z7fYKk9oj7b4U49D Fcgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TvwQqElRiM3abY1umKoCWnKC5J1cL0J2YX/zw5aeFiI=; b=K8fouguRAGpVdoxqy3sau0gr9WXE5sTf7e/57gusGdDtPxma/EzluHB9f8meX+9pX1 h8i/hy1nOeqytPlbsnjEt6RZsWqgh3Qs84K9apRRWQ5FczbqERhLap0XSMck4yH3Az0v CviO2OKnvFw733+FXzSUY2vnYiLyMt7nmLTWifJRYgojTMj1f257JMrETZfg4hRUmY2j /35f4iz5Wpm0N/B0kDxVJWjB9lFtV0x/M6Sj8i95lJo2IaJAsTxU22zAQjDuUR2rKEBq iqt9JYcVNL3bOea9nwOTu/y0FTmtGzNg9o5kF257i0BHSqLX/Gq7IDrjJgkRpB4lEOKm CHCg== X-Gm-Message-State: AOAM531KmVY7477okv4fF8F0NB5O5qhiwEwtlofMan2wzloh7tTrT8nJ wg939dX1nALVCgHguE3zVV8PFCCBY+Q= X-Google-Smtp-Source: ABdhPJwY+SgjJb4tRDleeBWhwPTvcd23SaSyIImts1MH92spAhRI6J6KQubIcVrFtZf3toJBTixOnw== X-Received: by 2002:a17:90a:fcc:b0:1c6:62b5:45c0 with SMTP id 70-20020a17090a0fcc00b001c662b545c0mr27415482pjz.133.1648453986033; Mon, 28 Mar 2022 00:53:06 -0700 (PDT) Received: from apollo.hsd1.ca.comcast.net ([2601:646:9200:a0f0::781b]) by smtp.gmail.com with ESMTPSA id y3-20020a056a00190300b004fa2411bb92sm15275081pfi.93.2022.03.28.00.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Mar 2022 00:53:05 -0700 (PDT) From: Khem Raj To: openembedded-core@lists.openembedded.org Cc: Khem Raj Subject: [PATCH 2/2] go: Disable pie in cgo for mips Date: Mon, 28 Mar 2022 00:53:02 -0700 Message-Id: <20220328075303.1519482-2-raj.khem@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220328075303.1519482-1-raj.khem@gmail.com> References: <20220328075303.1519482-1-raj.khem@gmail.com> MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 28 Mar 2022 07:53:07 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/163684 This overcomes the linking errors e.g. | /usr/lib/go/src/cmd/go/internal/base/base.go:110:(.text+0x60fef8): relocation R_MIPS_26 against `a local symbol' cannot be used when making a shared object; recompile with -fPIC | /usr/lib/go/src/cmd/go/internal/base/base.go:110:(.text+0x60ff0c): relocation R_MIPS_HI16 against `a local symbol' cannot be used when making a shared object; recompile with -fPIC Signed-off-by: Khem Raj --- meta/recipes-devtools/go/go_1.18.bb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meta/recipes-devtools/go/go_1.18.bb b/meta/recipes-devtools/go/go_1.18.bb index a492d7e64a1..98977673ee4 100644 --- a/meta/recipes-devtools/go/go_1.18.bb +++ b/meta/recipes-devtools/go/go_1.18.bb @@ -3,6 +3,8 @@ require go-target.inc inherit linuxloader +CGO_LDFLAGS:append:mips = " -no-pie" + export GO_LDSO = "${@get_linuxloader(d)}" export CC_FOR_TARGET = "gcc" export CXX_FOR_TARGET = "g++"