From patchwork Mon Jun 19 04:35:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ChenQi X-Patchwork-Id: 25919 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11824EB64DC for ; Mon, 19 Jun 2023 04:36:21 +0000 (UTC) Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by mx.groups.io with SMTP id smtpd.web10.1165.1687149377842709590 for ; Sun, 18 Jun 2023 21:36:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@windriver.com header.s=pps06212021 header.b=at1fYUTx; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: windriver.com, ip: 205.220.166.238, mailfrom: prvs=55343858d1=qi.chen@windriver.com) Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35J4SA2d003726 for ; Sun, 18 Jun 2023 21:36:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from : to : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=PPS06212021; bh=hfzQApyivAHoSX3Fulg/QWgu2guKe6NzlcqjL+WUW9g=; b=at1fYUTxvwxNNWZC7Z3R4J0KZOigUZDPMYnqJjR5afqfXr9DAGuf/y5gATWw5Yg8/VIh BO9KuJh7xpMlvQZeR6FVDeT883CC2EW5m2LDgtiteGrGrPWpqDZ4YMqOEYVq5VKvnV5D vjFkInmB+aLmh30jzaQkVu0fcJBXNsERYM6Zi68E7DNZEsh8vSZkuAaCgizjWWWFNboo fi3kZoqP7c3/helKUDwcwGdbtx9SfA1WvKVn6EyTAq/X0E8srmMaavvzvOrpP6odAoEV et+j6BYUrU0Q6ocAgzfn5Sj/WrTsxmkUQm7Xg1tOVxiT4hlluJuY+9bsUB90/P7um9x+ uQ== Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2106.outbound.protection.outlook.com [104.47.58.106]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3r9842s4f1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 18 Jun 2023 21:36:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CtJLW+4ogoozqtzEoOff1H4Q6BuG3RrVO3Xv9TtOyShGE4UO2hCGdQ+V/30HBt+YkhC3OZ3ULy0NDGjSFWqpMVh2xB7EroPh9gaWwfJP6zs4cNYFwiAc6y+CLYgwNDybmwKlY0tc5aydVhNSsCy82K5UERVMbM5a0AF+zoMHZCHZQccc1gCXJOUq+USbxFVGXUK8qt7rjdScATrI2roXiX5WTaODGFTwELGeDgev3Oxml/GiOdR4khFVImUDKW3C2J5TDjlQ2NMKhpPq62nAr3pNoZAKXnjaYi8Vh8pqE9jHzYdy2S6MwfLdEZ0StRir/beTPlH/hV4z77UjSPmyZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hfzQApyivAHoSX3Fulg/QWgu2guKe6NzlcqjL+WUW9g=; b=K73cCY6UoXyZApYt3pAR/mbUDAw3JIVytoitZkM25yDwh415uktUr2jVxt80P/fzegQhnK8Xzd49oEzEQcJBbzogbpjUF5j1lDBq7Yn0UBauYvsXLbjDPWnnDGXNT7Q0zMpispA9XFhmiZfKAyMXPrVOqT4GYIFGbXSz6iWGBF+J7+MAltGvnp/jmshyQuJSn0jTtWj1F8oRVM6buEuDnq3M3gdD77Kwjtl/PdfizOKRieT9vgYabB0EqS0FbqGIOi6VB0LwbYn9dp4NorLRCPq7c28+Uu7bfB8hw7RDlvEw0ToW2D3q7KEhzGqMufWvsB+q06z03XOdCxaOV0ktBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from CO6PR11MB5602.namprd11.prod.outlook.com (2603:10b6:303:13a::5) by PH0PR11MB4984.namprd11.prod.outlook.com (2603:10b6:510:34::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.36; Mon, 19 Jun 2023 04:36:11 +0000 Received: from CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::b504:c7a0:9ce8:6f17]) by CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::b504:c7a0:9ce8:6f17%3]) with mapi id 15.20.6500.036; Mon, 19 Jun 2023 04:36:11 +0000 From: Qi.Chen@windriver.com To: openembedded-core@lists.openembedded.org Subject: [OE-core][PATCH 1/4] zip: fix configure check by using _Static_assert Date: Mon, 19 Jun 2023 12:35:53 +0800 Message-Id: <20230619043556.3432048-1-Qi.Chen@windriver.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: TYCPR01CA0005.jpnprd01.prod.outlook.com (2603:1096:405::17) To CO6PR11MB5602.namprd11.prod.outlook.com (2603:10b6:303:13a::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO6PR11MB5602:EE_|PH0PR11MB4984:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f390dda-15c0-4c7a-8372-08db707eb51d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0AsdP2zMUfuGnl8XCN2toALdNhWVQjJ8RJudN6zTWwZoYfZiFzzrqzZNL4Rb23x7P7k5JiqmdcSQz9bUPZSE26T9rbq7INwmFym6TJEuYxVBWeXxou08tLJCDAOc9IKXwwdYnxr7ll4Ums90SYnPPESre7QbeBW63A3Nk4uiWDXTi0NUL+xMRgD24i1mlxP4r0qyCrehq5RdMOBlP+YG4cDL0tWPBnFfqXofKXoOrUgUXgiRdrj6+Ea/SSjc2VPdsn4Ji+/KgPT2kKgNiniqJiSLGzRvoJyOj6BO045Hoo4FGHgRgAAXynm1LswIfMj8JA/tWKsQvBJLAJQ3uP7VCGx+rT8IfameEKvrfhWvXcfxQ/L3QiqZTWhAFEAZv9JsD1khK8MtT3kqKU+/jvrug4dpAhguN/zau1Pq1wchndtPZ7ECrOIvoK+cTNraeY23QahVZK6DW0cN88bsFjRcThsilBfJD1BIme4GZSEiiduTW30W/1bVSJuoQjN9PBjtVugxGRBzdnDrbqElqb71Xt4aOdpdH1snSHtlhV+HFxqCQW4s6h+sbBUXGES3PhnJzPjtBppwFea2VdRig0sbQJBxGV4u2QHiMhwx5K2s4MkdbpsLFMZwI8c4+bGrSGQX X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO6PR11MB5602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(39840400004)(366004)(396003)(136003)(376002)(451199021)(186003)(6512007)(26005)(9686003)(1076003)(6506007)(2616005)(83380400001)(38350700002)(38100700002)(478600001)(41300700001)(66556008)(66476007)(6916009)(66946007)(36756003)(8676002)(316002)(8936002)(52116002)(6486002)(86362001)(6666004)(2906002)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NRGY0esPZwaEbJlW+bYOkXEMphG9UAoWfSYkiGfGAmY6HrndY1Ize+Ikd5iJR29WyLo/pt47ysF9Wk0rphADdZ2W5Y281oUiOEV8QkrioJZOKVKtOWw1xfiIKm6AFmfB+5uUrhd1ZUkUnQ272Uuey7MnvDObVSrkwDYsy1NmQcj57Sxa3NsMUalTyDnVJ9AfG49Ad1DUxpPPjdrMA3g63Q9Zrg99dvTpLKzUqyBng5He0fYOQuYS3Bo8SBRK5Im8aTAVUSauNM4XlDn56AuRIZSDiaf1oxd59SGfVZ8EgDPPn6jiACpWReXqE+eu9Mo8IaVOkDObaXFThgBcDN4FgNmJpxs4QcH9HvK+mQDp/j7Zedr/8LkKfOQQl7k8cfh7cPrtOBhoki9AHwdBWhxYmkp0G0idYxl6SNQSLQbjjwvnP46tAiXby5PuwT7SwwrYODq8qOOXlJcxWpZmtMIp7egHJduVud3I232iF0L9352MfJrZS/T+yr7dwaacBr1pV2wQlErvKwca8h6POcPVjvUz3zubPkdKlTgxB7YOe/hKv0th5APLq/QCjBoazFLSiV4TGi2ityGBfcc+EN1v3M0ykY0n3azKGN1Ygn7LJtYUtTABeXI4sdZ+KS7Zs4MndZgVKQuz7+7G9mFZLkCFiLhF0lGtzHpIKpTxFmt4dHKuhjrLZ8ewbAuWnpurCsPA1u8SAoCHgTQVNV0qkHXyFyc9x+4zebyLY+4EWf9RMOQNgRcBrl256uSiwj6bCdVfaOsyJB5xfFXFB81HUZHaZLzQJ+79idlDDdP2G8jK3vAvJjQTqA8T5JVxQRFo1CJEg1FByRfnRnYyraFR4Sm2OahXID4pk/JhT22AVI8E2o5ETwfQFzb5dYXBr9E+A2iE+nJd/7yOtuKVswfoWr+YY/UuOnJD/lNBvmdA/kWsioFWjplFbaVXVLlpEUD740QTK5bPP3wgkDHpgScwRn2NFagFrWb9vgSb+JsfEmtPlz0v45/pD+dluKTuPMRnyDeaAbfgfo/nwqIxnvRj776KKUSHPrXoeXm/G0Mi3iQsbNDeizxCMSCUdVoAGh8W9VpsA1eGBoaC+TuSbsyyCB+ZKLIx6BOH6b4PrWJxawli+UoAGz6sDulyj5VPk4cy8cieR7FpM7ANQBShaNUK/ucbn7U9o4nwAsWBFBuiWcq749aXSS0K0j0+HOCCVRj+02I90A6AQq+Ha5sIAgpzVwYdW3oywETfFyawakaI97bxPItxB1ORkiwgoGAWJYzjnXaEfgdKd2hIK/yozLx2qaDgwGsOLprALhYFUlglDpldjWS2OBkT1HgAniwSbFNABN7g5o7+SPA5EUIlm3Z1EZAo3zvqnukF5xOxR4sedhBg4O4dFP7VLPYed43VNpkeF/ShnTjbeo6+IFUVJ5fuhzI3dproHA5siEQaf0LZCBd3gfjBJuDRApknPS+dAHeeLsi1iPiGSxBhC4mgW+ToviWY7E5Is/dnGvUcMdWL5pwCmhVPvWnieVQ6buxptims4vq6HCDPuvhK++HHdB9tWGCKI5vSnmLvl9k1+Dok4W7ZCx7lqEAcKODBocDxu3DsXRdV X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f390dda-15c0-4c7a-8372-08db707eb51d X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 04:36:11.1872 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OpY+aMAWaluxo1Yud5LxhJj1jBpOi4Nmi0I4KkQ8hEuwBAtkbAC8IcYQi8uidEqs/KD0q2aDOz4S/q9gE6FZEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4984 X-Proofpoint-ORIG-GUID: u6jiPtG95AS_FmBK0tqVZNX4uHXb7EHl X-Proofpoint-GUID: u6jiPtG95AS_FmBK0tqVZNX4uHXb7EHl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-19_02,2023-06-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 adultscore=0 clxscore=1015 impostorscore=0 phishscore=0 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0 mlxlogscore=813 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306190041 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 19 Jun 2023 04:36:21 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/183088 From: Chen Qi It's incorrect to run a cross-compiled program on build machine to check if some feature is available or not. As these two checks in zip are basically just checking the size, we can use _Static_assert and sizeof to do such check at compile time. Signed-off-by: Chen Qi --- ...se-_Static_assert-to-do-correct-dete.patch | 96 +++++++++++++++++++ meta/recipes-extended/zip/zip_3.0.bb | 1 + 2 files changed, 97 insertions(+) create mode 100644 meta/recipes-extended/zip/zip-3.0/0001-unix-configure-use-_Static_assert-to-do-correct-dete.patch diff --git a/meta/recipes-extended/zip/zip-3.0/0001-unix-configure-use-_Static_assert-to-do-correct-dete.patch b/meta/recipes-extended/zip/zip-3.0/0001-unix-configure-use-_Static_assert-to-do-correct-dete.patch new file mode 100644 index 0000000000..106f246a7c --- /dev/null +++ b/meta/recipes-extended/zip/zip-3.0/0001-unix-configure-use-_Static_assert-to-do-correct-dete.patch @@ -0,0 +1,96 @@ +From 9916fc6f1f93f3e092e3c6937c30dc8137c26d34 Mon Sep 17 00:00:00 2001 +From: Chen Qi +Date: Thu, 15 Jun 2023 18:31:26 +0800 +Subject: [PATCH] unix/configure: use _Static_assert to do correct detection + +We're doing cross compilation, running a cross-compiled problem +on host to detemine feature is not correct. Use _Static_assert +to do the detection correctly. + +Upstream-Status: Inactive-Upstream + +Signed-off-by: Chen Qi +--- + unix/configure | 42 ++++++++++++------------------------------ + 1 file changed, 12 insertions(+), 30 deletions(-) + +diff --git a/unix/configure b/unix/configure +index f2b3d02..f917086 100644 +--- a/unix/configure ++++ b/unix/configure +@@ -361,6 +361,10 @@ cat > conftest.c << _EOF_ + #include + #include + #include ++ ++_Static_assert(sizeof((struct stat){0}.st_uid) == 2, "sizeof st_uid is not 16 bit"); ++_Static_assert(sizeof((struct stat){0}.st_gid) == 2, "sizeof st_gid is not 16 bit"); ++ + int main() + { + struct stat s; +@@ -385,21 +389,7 @@ if [ $? -ne 0 ]; then + echo -- UID/GID test failed on compile - disabling old 16-bit UID/GID support + CFLAGS="${CFLAGS} -DUIDGID_NOT_16BIT" + else +-# run it +- ./conftest +- r=$? +- if [ $r -eq 1 ]; then +- echo -- UID not 2 bytes - disabling old 16-bit UID/GID support +- CFLAGS="${CFLAGS} -DUIDGID_NOT_16BIT" +- elif [ $r -eq 2 ]; then +- echo -- GID not 2 bytes - disabling old 16-bit UID/GID support +- CFLAGS="${CFLAGS} -DUIDGID_NOT_16BIT" +- elif [ $r -eq 3 ]; then +- echo -- 16-bit UIDs and GIDs - keeping old 16-bit UID/GID support +- else +- echo -- test failed - conftest returned $r - disabling old 16-bit UID/GID support +- CFLAGS="${CFLAGS} -DUIDGID_NOT_16BIT" +- fi ++ echo -- 16-bit UIDs and GIDs - keeping old 16-bit UID/GID support + fi + + +@@ -417,6 +407,10 @@ cat > conftest.c << _EOF_ + #include + #include + #include ++ ++_Static_assert(sizeof(off_t) < 8, "sizeof off_t < 8 failed"); ++_Static_assert(sizeof((struct stat){0}.st_size) < 8, "sizeof st_size < 8 failed"); ++ + int main() + { + off_t offset; +@@ -436,24 +430,12 @@ _EOF_ + # compile it + $CC -o conftest conftest.c >/dev/null 2>/dev/null + if [ $? -ne 0 ]; then +- echo -- no Large File Support ++ echo -- yes we have Large File Support! ++ CFLAGS="${CFLAGS} -DLARGE_FILE_SUPPORT" + else +-# run it +- ./conftest +- r=$? +- if [ $r -eq 1 ]; then +- echo -- no Large File Support - no 64-bit off_t +- elif [ $r -eq 2 ]; then +- echo -- no Large File Support - no 64-bit stat +- elif [ $r -eq 3 ]; then +- echo -- yes we have Large File Support! +- CFLAGS="${CFLAGS} -DLARGE_FILE_SUPPORT" +- else +- echo -- no Large File Support - conftest returned $r +- fi ++ echo -- no Large File Support + fi + +- + # Check for wide char for Unicode support + # Added 11/24/2005 EG + +-- +2.34.1 + diff --git a/meta/recipes-extended/zip/zip_3.0.bb b/meta/recipes-extended/zip/zip_3.0.bb index 1930a40140..802877285f 100644 --- a/meta/recipes-extended/zip/zip_3.0.bb +++ b/meta/recipes-extended/zip/zip_3.0.bb @@ -19,6 +19,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/infozip/Zip%203.x%20%28latest%29/3.0/zip30.tar. file://0001-configure-Use-CFLAGS-and-LDFLAGS-when-doing-link-tes.patch \ file://0001-configure-Specify-correct-function-signatures-and-de.patch \ file://0002-unix.c-Do-not-redefine-DIR-as-FILE.patch \ + file://0001-unix-configure-use-_Static_assert-to-do-correct-dete.patch \ " UPSTREAM_VERSION_UNKNOWN = "1" From patchwork Mon Jun 19 04:35:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ChenQi X-Patchwork-Id: 25918 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF95EB64DB for ; Mon, 19 Jun 2023 04:36:21 +0000 (UTC) Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by mx.groups.io with SMTP id smtpd.web11.1181.1687149375831366082 for ; Sun, 18 Jun 2023 21:36:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@windriver.com header.s=pps06212021 header.b=kDKjCpPz; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: windriver.com, ip: 205.220.166.238, mailfrom: prvs=55343858d1=qi.chen@windriver.com) Received: from pps.filterd (m0250809.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35J40fA0016441 for ; Sun, 18 Jun 2023 21:36:15 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from : to : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=PPS06212021; bh=u+6tn3tV6S339YT1nhO39A2xRxE7B9PEoiz7fecfSO4=; b=kDKjCpPzwr1kvvatDI5fvGQpUsgf+q04iur5Q54btt3W6n9VLRk0QnFKxuKo905bq0+T wuLo+e1TVpbavDkYtqSXib/0fj76u8dKcSKNwpHmxwyX+gvusLtgmeFaYEk61+T8xK48 RHO9aN4TSTGt2olfc4hXOoyLOJEOZSFSeIPTOKiPeAUWC0qFhnkC1MVdn3rDn1t0XP5Y qzlJV9SGcO+IczGR25FAhwAIGZvgO87kr93fL8VhfMSVStmCNnTZqZEJw+YckWBdJswD zj4iUOZ7pNPW1ERlDe1kh4F3wMcPukjsHJLV9zvBjrc9qcRt32VvfoEy+uSByuJYn7cR Eg== Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2109.outbound.protection.outlook.com [104.47.58.109]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3r9cbhs0ph-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 18 Jun 2023 21:36:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZL3qbrT3in6nGjcvF1qkyfBW8nXgE38rcElbjQ7V/rF07aHZqTcHrLQYHqRlA2JahE+fy2e9+ujwkSi/P+MV4HRqG2teRrOsw4P6iYqFgZxiVsnj1gADbRRGLpvJu8sxeSgbhNOtp9yR9LXCeqVoW7H6RLT+vQ9mJ+RRatjhzpEO2Cs69LGWy8UPblRkZkCVLUCZp5I+h+cJ3576gSdAfJpQc6aVi9KRv590KG2zvDhGM6SmVuM1zmbMDbBISxeLMK6RAsLn7H8kQPbo8jkHlUZ49M1/V8FXwxWtVkvL71kZkdIolQjmD/J1k/LIh6ZczOROajeYu7wtrsZ6cp9R7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u+6tn3tV6S339YT1nhO39A2xRxE7B9PEoiz7fecfSO4=; b=W4fyopOEaTus04qZReaTXf9isrpTvBoMuoV9wshGQ9DG92FPqmCeHRZoi1FJIC9L7SvKx57M2g7/FEGYyC9dWfMsNX5KGDFzatYQI+eMgTl8Z7iHmc/Piov+Ze9elUhxtJnYWTfBqVNnTGrKT8Ak+yXK/CvmuEcbXCPclKLyEMTkUFbHTERAcR93kjZWW7vQLBvNlp+dyBKM1uZOcUILEPJJfZaQFLQvsvf4mme0zYjlRdKRzImz3T8Ss4a9FSK/NGHxMIXwfM3lDxuC6fBHtXvi60nimwUqLad5ikhVKa1xIYsSJ7B38gjl0wpU2vVHNvEHL+Jfvm/ydskP2mJjSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from CO6PR11MB5602.namprd11.prod.outlook.com (2603:10b6:303:13a::5) by PH0PR11MB4984.namprd11.prod.outlook.com (2603:10b6:510:34::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.36; Mon, 19 Jun 2023 04:36:12 +0000 Received: from CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::b504:c7a0:9ce8:6f17]) by CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::b504:c7a0:9ce8:6f17%3]) with mapi id 15.20.6500.036; Mon, 19 Jun 2023 04:36:12 +0000 From: Qi.Chen@windriver.com To: openembedded-core@lists.openembedded.org Subject: [OE-core][PATCH 2/4] zip: remove unnecessary LARGE_FILE_SUPPORT CLFAGS Date: Mon, 19 Jun 2023 12:35:54 +0800 Message-Id: <20230619043556.3432048-2-Qi.Chen@windriver.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230619043556.3432048-1-Qi.Chen@windriver.com> References: <20230619043556.3432048-1-Qi.Chen@windriver.com> X-ClientProxiedBy: TYCPR01CA0005.jpnprd01.prod.outlook.com (2603:1096:405::17) To CO6PR11MB5602.namprd11.prod.outlook.com (2603:10b6:303:13a::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO6PR11MB5602:EE_|PH0PR11MB4984:EE_ X-MS-Office365-Filtering-Correlation-Id: 62a48e8d-820f-4565-12d9-08db707eb5b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6bsOC6jOP/qwy1LUsR/zwy/4MKrm+Xwyo2E/k3TjjFvnea91BtGPnRVc6MpiiNMpSUuV9V9dFU2+qy6lhKE8fqaq++lScXNRM+HRQCNflDRJmJJSAH1T5HasfY8TaB4e+vjug2uBrq+/XoA/sO5FgEhOHUnDGHBdZ+Wg9Gudz2r1ngGhK1Sn42I9ELpIXskBq6sf2d/LoHfGFCJOBiIVQtId3o3PR3g4wpxy/QVQw3rPTQUGcDpcK6hCzvItu8vLOJyhK9yYx7BuKgJuo3+G/FWsGIOJqzPUcA5R/jLpYsOY5KT5G0DXoKhdfOA7ed/ppJxX2vs8WnXyubpakyS6sg0bmSRad0VYv9NO3qlzDIuwpmTQUE9YG4Yjgbvf0tlfPVBIZcP2Xh3gRMiftsOnXGZH9wRxVVgtSpPcdxnKoLqs9Doc4ZOCpOUqGtWF0z6zKXJtmvcuQG3OleQilguQa0Nkl3GmGINfc8I96E/hc4hqC5PE/DXm5A7iXrNDf7G+IHLrI9/u2kgSmaXyY4UwYqMdqZ2bk5pCWv7wxc/rQu5+i2qM6hVZFdATHp3tqqMP1yXSSViFbfpHM9hzgj58T5zP1ZUh+f6tf0GLglf9S+1SBZe1KCeKLY47gmdun7Mw X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO6PR11MB5602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(39840400004)(366004)(396003)(136003)(376002)(451199021)(186003)(6512007)(26005)(9686003)(1076003)(6506007)(2616005)(83380400001)(38350700002)(38100700002)(478600001)(41300700001)(66556008)(66476007)(6916009)(66946007)(36756003)(8676002)(316002)(8936002)(4744005)(52116002)(6486002)(86362001)(6666004)(2906002)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TuQTObwAH6K+CNYZvyCDRzA/ItnoENmLOXFQ0rFaai0jHi5+ZixfnQoeRgsL9gfjiyOAMhzI1vWyDoCoRsnqGr6raBugJYBSU/D6RqYoe1x7P4tufa6m5Qo/SHQ03ulo4hmqUOV/Xp0E3yyYHGWhZpeMt77c0BJWPy6hgN0m0Xs3NiE/X4twYpFHkHuRKNGu19oSIPWsuSW24/MVQQBF/XSvwV32LLd9M/03qL3bUMD79K+q1mUWhA0VK872rJm4lOk8Kvd1GBn6+h2H7g/91ORn3Zks8RUigFk+nPx+46v/FrnI36x+YRRc1YVNLrXXuuZkzpc0SBn1CX4P5rpn/JTKtEqJAGukS0MpTAdm6pabwt07PbEq/R5yeI0oTGDSGJLns41c7vmdLRXaQuMBy9LDU882I9LLdcwxipUf81PaotVQ3umKL3rKI6Qigg5i+Oy/ZG1SGyjBQykELMg7mMCpYv7QO1AV9yuoEGShzXCLKurQCgdmRF3uCYzEE8GdeGibPrU12xdNsFOB5gJAKxdgcsxInGO2Sx+MVRrdD0rfOsri76snLeQRsWO1f5p2RonBMwkumSj+ig5Z4ZWVi0CaQ41Mv4aPa2Hr5FF1LD6SZ8WJkidMcNXJjxwq5kv6vybFa30fSBwO/kQ2sW9iTXtI2hNrWSwH/6jqVGFKAuoyAWg1U/lcSMBWA/LlwNaZlUhYS7h3CPbp42cN8ZefdAnqrfcb2VZA9wU5+X7rl9K8k5qdtD04TQKZsfTcCMANPb6e8l1pH80DUQLwhT7/H26BlCOyC4cRVjkMime4nmTCleELP/575h6R+m38uRrNEkr7z6aKFY17PhasqgfdDDeyExUsDDF6Jyqh/Z6DNDonPij9I0BAbmQ/F8r0WgiYV9DX/zkpNKK4jq5X8MhnBwi+nNJjgNiBgBZIsuydTcuWd2zZxUC5aUzKpDgWCUeuVDcOH8rhxxFJfGgsoRM+Qlu/lzjW4eiH6VVJrv2Z+s7APS+cYWi9hgpjzbXFiGIGzQKIrvZTf95mRPsq2mnYz9DiBR0lOOIluXU+SzY6bLgJF3JvF2QtB4caTZQ5jokR5BdBbI1PvedAT0xTFEWH8FDYpR2lD3S/oBoeLFS4qsvp4gddfDb1uts2+YoHO+DftffKGzqYhUw6wxvmSUxcaQ/WhpTAA5owuFVJcRGUKIzvSKkHCjwvJ1WyY9DJmiA8eL0I4xmUSkuMrO5cQVUYYBQrfUXuD4zRf+BEedrr3pe+XzYen4KwXvEJTJrZiWIDyJf9QIf9JI0kdL0M8LnsfQ+OEIat2YrSBrVuUtZ3QXmutejVnbpHfKtbXccO70gr6MLCzKxWJ78/vYu7+6o857Awgn430fFvzxVtIXdSSSCuMRVzBK4pTbMxHA1I4y5KEOXu9F0TKcEc6kgmZvnVC3T9R9IHumJNu9J/J8s+JAd560Ey4kjPKTqbfy7LNkrwiKlo+rf1jScFBh5MG2fspheF4P7WtdetBvce2OwADgpFrlGfh23Ck0Kyvpa3q8ZBre4cqCw90AMVMTayuRzSsM1hiXy2apc6IKw0duXZ4lYnTJ0JZOFcNPP6de3IDjdB X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62a48e8d-820f-4565-12d9-08db707eb5b6 X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 04:36:12.2362 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zuF4nHmN554TFgYJrrkOYheg/m7MCH63xAZMveOklLYul2t9jiYDij5dgyBOOpCuem/jRiaW6SZY1U0AxU1KEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4984 X-Proofpoint-ORIG-GUID: ZAPrEw8kvTmnsMrItYuDaLYa6pmHbyry X-Proofpoint-GUID: ZAPrEw8kvTmnsMrItYuDaLYa6pmHbyry X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-19_02,2023-06-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 adultscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=956 suspectscore=0 phishscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306190041 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 19 Jun 2023 04:36:21 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/183086 From: Chen Qi As the zip's configure has been updated to use compile-time check, it now can do the check correctly, thus no need to pass LARGE_FILE_SUPPORT to CFLAGS. Signed-off-by: Chen Qi --- meta/recipes-extended/zip/zip_3.0.bb | 3 --- 1 file changed, 3 deletions(-) diff --git a/meta/recipes-extended/zip/zip_3.0.bb b/meta/recipes-extended/zip/zip_3.0.bb index 802877285f..82153131b4 100644 --- a/meta/recipes-extended/zip/zip_3.0.bb +++ b/meta/recipes-extended/zip/zip_3.0.bb @@ -32,9 +32,6 @@ CVE_CHECK_IGNORE += "CVE-2018-13410" # Not for zip but for smart contract implementation for it CVE_CHECK_IGNORE += "CVE-2018-13684" -# Enable largefile support -CFLAGS += "-DLARGE_FILE_SUPPORT" - # zip.inc sets CFLAGS, but what Makefile actually uses is # CFLAGS_NOOPT. It will also force -O3 optimization, overriding # whatever we set. From patchwork Mon Jun 19 04:35:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ChenQi X-Patchwork-Id: 25921 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C83BEB64D9 for ; Mon, 19 Jun 2023 04:36:21 +0000 (UTC) Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by mx.groups.io with SMTP id smtpd.web10.1166.1687149378342979987 for ; Sun, 18 Jun 2023 21:36:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@windriver.com header.s=pps06212021 header.b=PuHqSSiV; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: windriver.com, ip: 205.220.166.238, mailfrom: prvs=55343858d1=qi.chen@windriver.com) Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35J4SA2f003726 for ; Sun, 18 Jun 2023 21:36:18 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from : to : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=PPS06212021; bh=7RghpuxazdWbWBdDNju33hcYbeWWkKQktHb/kjY5/s0=; b=PuHqSSiVx3KMyEWv77NOCWHm0ZEKGLdIJefxLCxDI76ssHDgambLK+YHKy76sEEi2nmi GvZ5vPIo6nu2g/T4pv17Tf+HbW5FgZQMssYYPlX5yLdc2hLPmBU5qqBPz7sp2/ekzDvq AGB04IinGKlg5HQGClaKmSfTM8AeOkSR3nkAcqA7G49HbiDXNYrtG+J9+VtFiQFJVgfS BubmsnbSzwNe3FbjVRuCIMv4GEMy9e30SQqdef3CbkMu+p12iW+YOPTRQNje6r8E69dq mNa2XAaVyvqHuulD+QZPenO81BvMxh2itTWMC5NVtwfZi3CowOTwtxeYJbvJXGKDaXN1 pQ== Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2106.outbound.protection.outlook.com [104.47.58.106]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3r9842s4f1-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 18 Jun 2023 21:36:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W6qlUZqG6gqEbCoZruUrxoPW8rE4mxsPp8HPIpWmTqFNWMDkp7Sc5afmDAH+W5r66qIFbc0GMPSxd+MiwVRKRLHI7Q9Q1cX/CKPuZs4+0ck53y30zpuNwofxJhLCEgcbn3jAHvRxndxOZjpelfF0j/biyXP2ofSmJDM5kqjV2xiCdt/DPfO57M+S207fdMqkencTOmWCExIWWn7gswI0Sa6iwWeGLbL34kOWyLXZSXWetjuvXAhFTg31vj+55AEfe95acnpcCJeURtSZGcAuu3yKVaZEGqEkLcbd6WrTlraxXWxhBPf0Tch7LvNTRhVxi+npnOQHW1iCOhIraQM3Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7RghpuxazdWbWBdDNju33hcYbeWWkKQktHb/kjY5/s0=; b=Q1hb6v7tYkaqeKt8Yyi8RM5Aft7ja+pWX+65NaBfMqk+JsRPauiCiCq6KlpPSWOFlcYMCCKCpyaIE6YKVbsy+1ZKUI0Y/KZzP7IpulVTyfRBv66EBJxBABr2yYRWe8WS90IA8+WTIhwkgNKS0L4l4lnoiM1YGz0+AqwKwSztZlgjJZqTZ0dZLvFPAHlr6Qea7Istk0chzzU9egMcaxGechSMMNJC34YeBFIByFtVle5YKZ6L26s3duHqqPSYcXyeP53pojZExuO2U+KFt6yQZIsUUeVYVEHN1EwafxqZ0BwkXZThYUtaHp1uRhRelPIVhTZlc6t4K4cBhgc7cxvOyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from CO6PR11MB5602.namprd11.prod.outlook.com (2603:10b6:303:13a::5) by PH0PR11MB4984.namprd11.prod.outlook.com (2603:10b6:510:34::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.36; Mon, 19 Jun 2023 04:36:13 +0000 Received: from CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::b504:c7a0:9ce8:6f17]) by CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::b504:c7a0:9ce8:6f17%3]) with mapi id 15.20.6500.036; Mon, 19 Jun 2023 04:36:13 +0000 From: Qi.Chen@windriver.com To: openembedded-core@lists.openembedded.org Subject: [OE-core][PATCH 3/4] unzip: fix configure check for cross compilation Date: Mon, 19 Jun 2023 12:35:55 +0800 Message-Id: <20230619043556.3432048-3-Qi.Chen@windriver.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230619043556.3432048-1-Qi.Chen@windriver.com> References: <20230619043556.3432048-1-Qi.Chen@windriver.com> X-ClientProxiedBy: TYCPR01CA0005.jpnprd01.prod.outlook.com (2603:1096:405::17) To CO6PR11MB5602.namprd11.prod.outlook.com (2603:10b6:303:13a::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO6PR11MB5602:EE_|PH0PR11MB4984:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c458ec9-4dcb-4fe7-68f9-08db707eb653 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NQBbk+QCNbkwR289KVZxSThIDTPf2QXr/V991otvv9uN5+cvETpg5Ewh3b+4Vce1S56z44t1m9zf9ynVVcgC2EQX2tuGHF3R2pW49dDqUZmiCVk3EsD1rvQX/2lKh2j2z4LiqVYKnWwUgafFoVgwd0XEvYlJDmfFHSq71rz0i6twAaP5a68fm1PaNOf6Nm6Eb47ovN1hxo+vAOjk7qWps1grhoq1ouWBLQUNn5Iqdrs4ge9B5YgzQ8BBhVwIqvpHEzUE7LCVou7BLHrtWk0BcdRgVbWgBWVqbcXUmKzbexcjBC8xwj/qVdsfBoqYASXgXpL3mrMwf/aIHZWlldaU0iEF958FtAam3L5mC7n7J+sFICCIXVIxq0tNVN1O8iBGmrQV41LDti9ositH4WHwhsMI8An2xS67vK6T1J3TeJ9sZgAPMVRx+Ybd4snF5c0kZcLhmx4IeXg7UxsDszVoRi6h4ieLRFhPqiSeNv86ShtqQBx/AchaTnyI0yFqyCAOOYOpQ31Vw90phGBpPIaEAUjwzIc7JVKkLLLkRjR7s9hKL4cXuwcOyGt1MLU/gz11CSeThDRjtSTmGki06LWkIJXznl2Gs+9r8uLSnf+hulfWZQs4UEsP88nsIT2Mh0AH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO6PR11MB5602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(39840400004)(366004)(396003)(136003)(376002)(451199021)(186003)(6512007)(26005)(9686003)(1076003)(6506007)(2616005)(83380400001)(38350700002)(38100700002)(478600001)(41300700001)(66556008)(66476007)(6916009)(66946007)(36756003)(8676002)(316002)(8936002)(52116002)(6486002)(86362001)(6666004)(2906002)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oklM2HIbnKbuKYajiZXPHx6XbTD5s/YBBaOvI+vu4AwdRglNIbzJYwlN9upByZ0eIPlVO8ea1+WDYVJO/EFhf/ECFn5ZhmbK2FrMomNynZWfeYrwd6i7Je1WkxVDgtDG3gTlWHY6vqg9PJMEG4kmOGcq87R/MpqUyknHkSj6iBtHP7ziZDhSp3KEswSjYIPsdYX/+uU9kU0UixEp7bouv0QEX/3mTaH552GVIJiYzefPBuelUCtngDUsN+C+EYlmM8ajYHP3l6tE+ACmp+UvH5H6KcNq4QJ97yUJtlm4ldCbjZdYmJID60hjlVEiltOXCeuOfoc2ZTFHfBvjtXgcTu7YE1iUV6ErPZdJqEAhpp9bJOTxhJDxWQ7LtoOhMGcxO/tlpVnusDBVNhhLJVpxF2wfT1PsLkbsMtDoVWmFdN0RlSWLZZsyUwPPMnmoLHcWAwK19+r2Dx1ZQYAKev3jbkCkPUJtNWgzRF1gEO3tXx/fIIH5/NvCxihC4CntcRFxl/kTkyu62tfGLNw842SsIUs6xPEwiLWIn1JPk9vM/5KU+jIxnE/2oV7+ZBjqTSNAHTpSMI1zXtekGO2UbjlndAIS5oCxiTPU893oCv1AzcQBSNSGUZDBN+UUT9LD/z3PBB4B9bAhxypWejUtb5nYiba5EWej2bviLLxQTHoIro7Cy4fMRNBm3ylCcAlr0AkTNfqiXdDkOlggWbNy1sDlYalLSov6fxh3R1sc0vFWRrZfIn+yqOS7OSK4iJGFGF+k8QPNX4HWUF6avVGv2Raxww5q0sq+xDJ8oWBKFkSBtnxuv12Z+UNyRluMLxLzVBXXqHXMRAB7aTYXTkkq0m33AHeGfpP3W7WHs/MGSuZXGd+ZeAGnBB1pXFTdANBhxi9WYvFDDwJqeUFegQisK0tjBuy5S1HoHfPCKTHAyK1sMISx9Rz+b7qO51FURm80f/tYJBn/RJUjEkfTd3VLijhJCCJUcwbGaf5MzWEqnSEWT2yTJ/aX+BEIF2K/K0Z3+epBD9WCH+TiPBaF63PB7+Bt8SxDf4FWjPWS4/YPO+uOHyjr62HHOEPWiweyZX230+D5XiHSeXU0rwsqkzmRmoRfQrDDL/Gi3pCLKXla8nx5Vcjz10n8Mg2TxZtNRUoZj1Nsrdg5wirdtx0NTFRro+BnFBzw51RgvY9NBbARsG8XgjMZRU59gOUoyTGX6W7OxC01aYCXpFOc0i34YKqxLA+mU5YtoyQbmmZwGMYVthAf4q/Y1WqJ5r+/Pm1JK3GtdDpwnSWN894p0abAqcaLh9EoOds4AzKTx/ScH3d1jhj06uynd1GFZJoATJLGbnx7mTQRh2LmjoTsH+ncj+R1ow9kUGxJzMiFP8NZtcnoZMNmRmulvOznRjfgYQSNH12AUodx/ZQc/7cSCrR5+hqOd8CubO3dqt/7P8FNkLeeUtiLZbi43XULGqTjjG0iFgAw9EWRP2p3f51tKNuBFsoaFAB/C/UeyzmZ+haZI+2r5F+n1L1OCX5jPpYr994VkYEh1OHBArSpgOhpKJ/w9HBh5Gp/5UEgeGttC5f6suYeuEZU1m6pqnnMvQWTFmboYu9ypTL3 X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c458ec9-4dcb-4fe7-68f9-08db707eb653 X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 04:36:13.1834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nJ9oalXZJTLBySVLPhL3CVchE+DWyGPyJLv8AKnJhbIhv0tlaSNrIELI1M8mJjm5YmJODIcvIYtnUiBKpvsPVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4984 X-Proofpoint-ORIG-GUID: IuJXFI3PN2P2VyCavN6TmUVzhL3SW_Xx X-Proofpoint-GUID: IuJXFI3PN2P2VyCavN6TmUVzhL3SW_Xx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-19_02,2023-06-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 adultscore=0 clxscore=1015 impostorscore=0 phishscore=0 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306190041 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 19 Jun 2023 04:36:21 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/183089 From: Chen Qi The original configure runs a generated binary to determine features. This is not correct for cross compilation. So change the runtime tests into compile-time tests to fix the issue. Signed-off-by: Chen Qi --- ...-fix-detection-for-cross-compilation.patch | 103 ++++++++++++++++++ meta/recipes-extended/unzip/unzip_6.0.bb | 1 + 2 files changed, 104 insertions(+) create mode 100644 meta/recipes-extended/unzip/unzip/0001-unix-configure-fix-detection-for-cross-compilation.patch diff --git a/meta/recipes-extended/unzip/unzip/0001-unix-configure-fix-detection-for-cross-compilation.patch b/meta/recipes-extended/unzip/unzip/0001-unix-configure-fix-detection-for-cross-compilation.patch new file mode 100644 index 0000000000..2fa7f481b7 --- /dev/null +++ b/meta/recipes-extended/unzip/unzip/0001-unix-configure-fix-detection-for-cross-compilation.patch @@ -0,0 +1,103 @@ +From 5cbf901b5c3b6a7d1d0ed91b6df4194bb6d25a40 Mon Sep 17 00:00:00 2001 +From: Chen Qi +Date: Thu, 15 Jun 2023 07:14:17 -0700 +Subject: [PATCH] unix/configure: fix detection for cross compilation + +We're doing cross compilation, running a cross-compiled problem +on host to detemine feature is not correct. So we change runtime +check into compile-time check to detect the features. + +Upstream-Status: Inactive-Upstream + +Signed-off-by: Chen Qi +--- + unix/configure | 44 +++++++++++++++----------------------------- + 1 file changed, 15 insertions(+), 29 deletions(-) + +diff --git a/unix/configure b/unix/configure +index 8fd82dd..68dee98 100755 +--- a/unix/configure ++++ b/unix/configure +@@ -259,6 +259,10 @@ cat > conftest.c << _EOF_ + #include + #include + #include ++ ++_Static_assert(sizeof(off_t) < 8, "sizeof off_t < 8 failed"); ++_Static_assert(sizeof((struct stat){0}.st_size) < 8, "sizeof st_size < 8 failed"); ++ + int main() + { + off_t offset; +@@ -278,21 +282,10 @@ _EOF_ + # compile it + $CC $CFLAGS $LDFLAGS -o conftest conftest.c >/dev/null 2>/dev/null + if [ $? -ne 0 ]; then +- echo -- no Large File Support ++ echo -- yes we have Large File Support! ++ CFLAGSR="${CFLAGSR} -DLARGE_FILE_SUPPORT" + else +-# run it +- ./conftest +- r=$? +- if [ $r -eq 1 ]; then +- echo -- no Large File Support - no 64-bit off_t +- elif [ $r -eq 2 ]; then +- echo -- no Large File Support - no 64-bit stat +- elif [ $r -eq 3 ]; then +- echo -- yes we have Large File Support! +- CFLAGSR="${CFLAGSR} -DLARGE_FILE_SUPPORT" +- else +- echo -- no Large File Support - conftest returned $r +- fi ++ echo -- no Large File Support + fi + + # Added 11/24/2005 EG +@@ -302,6 +295,11 @@ cat > conftest.c << _EOF_ + #include + #include + #include ++ ++#ifndef __STDC_ISO_10646__ ++#error "__STDC_ISO_10646__ not defined ++#endif ++ + int main() + { + size_t wsize; +@@ -327,19 +325,8 @@ if [ $? -ne 0 ]; then + echo "-- no Unicode (wchar_t) support" + else + # have wide char support +-# run it +- ./conftest +- r=$? +- if [ $r -eq 0 ]; then +- echo -- no Unicode wchar_t support - wchar_t allocation error +- elif [ $r -eq 1 ]; then +- echo -- no Unicode support - wchar_t encoding unspecified +- elif [ $r -eq 2 ]; then +- echo -- have wchar_t with known UCS encoding - enabling Unicode support! +- CFLAGSR="${CFLAGSR} -DUNICODE_SUPPORT -DUNICODE_WCHAR" +- else +- echo "-- no Unicode (wchar_t) support - conftest returned $r" +- fi ++ echo -- have wchar_t with known UCS encoding - enabling Unicode support! ++ CFLAGSR="${CFLAGSR} -DUNICODE_SUPPORT -DUNICODE_WCHAR" + fi + + echo "Check for setlocale support (needed for UNICODE Native check)" +@@ -418,8 +405,7 @@ temp_link="link_$$" + echo "int main() { lchmod(\"${temp_file}\", 0666); }" \ + ) > conftest.c + ln -s "${temp_link}" "${temp_file}" && \ +- $CC $BFLAG $LDFLAGS -o conftest conftest.c >/dev/null 2>/dev/null && \ +- ./conftest ++ $CC -Werror=implicit-function-declaration $BFLAG $LDFLAGS -o conftest conftest.c >/dev/null + [ $? -ne 0 ] && CFLAGSR="${CFLAGSR} -DNO_LCHMOD" + rm -f "${temp_file}" + +-- +2.34.1 + diff --git a/meta/recipes-extended/unzip/unzip_6.0.bb b/meta/recipes-extended/unzip/unzip_6.0.bb index a4d10c30aa..391e5cd22a 100644 --- a/meta/recipes-extended/unzip/unzip_6.0.bb +++ b/meta/recipes-extended/unzip/unzip_6.0.bb @@ -32,6 +32,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/infozip/UnZip%206.x%20%28latest%29/UnZip%206.0/ file://CVE-2022-0529.patch \ file://CVE-2022-0530.patch \ file://0001-configure-Add-correct-system-headers-and-prototypes-.patch \ + file://0001-unix-configure-fix-detection-for-cross-compilation.patch \ " UPSTREAM_VERSION_UNKNOWN = "1" From patchwork Mon Jun 19 04:35:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ChenQi X-Patchwork-Id: 25920 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A8BEB64DA for ; Mon, 19 Jun 2023 04:36:21 +0000 (UTC) Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) by mx.groups.io with SMTP id smtpd.web11.1183.1687149377809617233 for ; Sun, 18 Jun 2023 21:36:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@windriver.com header.s=pps06212021 header.b=olv2bSfi; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: windriver.com, ip: 205.220.166.238, mailfrom: prvs=55343858d1=qi.chen@windriver.com) Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35J4SA2e003726 for ; Sun, 18 Jun 2023 21:36:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=from : to : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=PPS06212021; bh=tzj/zDIiGr2Gw6qMpiYyh3t277oRYQNYnNPfz0vkz2o=; b=olv2bSfiMqo8g7GMMjcKpu5GN/ENmSuYlkSstVxD66ZMtEraaKstluQOhX3QH859J65R picbrGpvXf8tamM+HZBLqLMdL0g/phskspf7nvku3Mi2zSCPMrV2dbhCTiHcXTYuxwXp 7iAnd9jBDnJ0QFCox1G+2IqAuLiOs+7/eMdoST33Myjd2FnoFUu383KvE2iMcOSRu9+0 B7g6vClMJkAdCcmmA06ScTNVUzWKZP6XinEzpNS03uM4ufOlMfubjnTrL+vXKYEX+kby KKBmMakY6Nb2z3qfmUwqJ4rIViELPrg8mKhRYDXIuhaF8HB1wFxXo46XJNfYgACjoPB0 3A== Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2106.outbound.protection.outlook.com [104.47.58.106]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 3r9842s4f1-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 18 Jun 2023 21:36:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E8NCV/FutDOzWHJe8khJ3iXWc/m+MjC2h0qX8MZiJ0SQBDSbExafxaOWC+vXTk7pzxR5oQz9FGkPtinWlvwqFrY0IodJdLez6ye0TRrPrG/k8/UPdYE6mjnsPJTiLNkhE9W5mjItcGCd/StX4lqlmIJpOKxE41U21HbrRnHBPuHqNVhoJGCg5it256AYQedsfsVx8yKAAX8vi/L+NBP+ES+cCsPwbICiBOT4W9YCCX++2ewjZ0HYpcrk6pXQxAdkLmcwDscI2NvAOCDzjaJorfYTzcHKvBHa2GAz5vaZjFaCwzb9RVDpelHudC7NMvzbu39B2ILbF9RoJA94TnPXgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tzj/zDIiGr2Gw6qMpiYyh3t277oRYQNYnNPfz0vkz2o=; b=lwtd/xZ0T5UZVFl7HcsiKDHxQ1L2ixD6eW3cItA2TGocUyukSwzERwO6xjyMUXkX8OxH8Fh93cBgZOlhUC7YjafG9Q8feeRugpBRN7t7fACDurfQrK0dEml+bh+5G8A77rdaw0/QxHA9FQpeKUn9ZSZmQT5DCGEjCPEigVzbllp+ZbzlIFY59FiVA4P+HhRknwmJXhefDljhtK5kdad2UD+ILt+s5PDfz7GHpbMDNW82vx2fV2/2k2X1AR77j3Xiw2Cn2VeH4EAFk/hN/XMbubNUqJPUgwlrIrFp++SyhslJy08Mj+u7VbQzfKVjHCecYzkS91YYflSg92SAKp+tGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from CO6PR11MB5602.namprd11.prod.outlook.com (2603:10b6:303:13a::5) by PH0PR11MB4984.namprd11.prod.outlook.com (2603:10b6:510:34::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.36; Mon, 19 Jun 2023 04:36:14 +0000 Received: from CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::b504:c7a0:9ce8:6f17]) by CO6PR11MB5602.namprd11.prod.outlook.com ([fe80::b504:c7a0:9ce8:6f17%3]) with mapi id 15.20.6500.036; Mon, 19 Jun 2023 04:36:14 +0000 From: Qi.Chen@windriver.com To: openembedded-core@lists.openembedded.org Subject: [OE-core][PATCH 4/4] unzip: remove hardcoded LARGE_FILE_SUPPORT Date: Mon, 19 Jun 2023 12:35:56 +0800 Message-Id: <20230619043556.3432048-4-Qi.Chen@windriver.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230619043556.3432048-1-Qi.Chen@windriver.com> References: <20230619043556.3432048-1-Qi.Chen@windriver.com> X-ClientProxiedBy: TYCPR01CA0005.jpnprd01.prod.outlook.com (2603:1096:405::17) To CO6PR11MB5602.namprd11.prod.outlook.com (2603:10b6:303:13a::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO6PR11MB5602:EE_|PH0PR11MB4984:EE_ X-MS-Office365-Filtering-Correlation-Id: 291b8fea-d4a7-4fd3-0c89-08db707eb6e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NPAvhV6SdWuNrDXFMVNVKnMp3H3rx8ajuVqmVrC0WP/3abQP01ZRIgiqUSCmOp097IRerZCwnwpTDLpePIt21FLv1yxOcTJoPz5Mv5ZVeNnDcm0nF+CMLefBdhz/vQgi+kCkwr/RaAat8NWAbeaoOWzWF/WTASGfn767WMUCT+ieDhaTWNmzf+1ZLAfj3RVLG84lYSlQUGKsqNmauakqwqWYL3lhF8kt+AXpBKvJuMYm/C3Vw3xWuouZtsEwc+RRUOIQBeony87yJ1LwYxq2hopKVcpmA8xu9+8h2WitSHPJ8C1q93gFEeQX0nbogY+6PqYUff9YYa/v53T7LDVtzDHLzVpC8lCSsR0+SAGus846DUiCtbKXqNtzKn5IFuBaL//LT6DqeFSFnrfEK3jtz608BS/Q2+ecqbZv3i+yaW0uk+/BlYRMxHmolEsLsCNZlDaMM2rF0zz7zFgVXL//MMXpmjd4SK2987OfXeVxoHQLkpElQicDXKrRPMMa8sgSf3oamkzM1VmRVgj+3qixoTUS5GuoAPFwwau/2fecHn7dTCPNFROPbCg/D2qcqtKdOec9EfxpODIbLOa+/YeaA/bcyNBMavqYq1DCdys24ZfzuMWdnyofNUNtFgnHSQu5 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO6PR11MB5602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(39840400004)(366004)(396003)(136003)(376002)(451199021)(186003)(6512007)(26005)(9686003)(1076003)(6506007)(2616005)(83380400001)(38350700002)(38100700002)(478600001)(41300700001)(66556008)(66476007)(6916009)(66946007)(36756003)(8676002)(316002)(8936002)(4744005)(52116002)(6486002)(86362001)(6666004)(2906002)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: eupAKbmy5NkrglPavlOzT0s4wCLkRu3ACJUxSo42mJvGJKBefVnKu5RyeoQevx4gizgJB8nDL7y7ZFtn69h9zm+Av6DoFIylCxIvxqvFg1YAsEjKDZ7+yYpPq/CvRDJH3dt7Nf3/tswifX5ZKFZT4kcu0u35QZ+YLMjpB+Ikb0xwWrxotMjxuZon0EDE2P4WNvnwFtKli6PBC1bRhqNtdhsl4UkRGFmD4ZCdItXn8Jaip+5S0v5ZmHwP2f60rzSp7atZL/5MVEAo1gSiYhOrhDja3/DlGcfnqLAPPcu+pyCt0ENwpp6n+K12zbIqjHyUfE69fVpIHbkDldqwfoomUvd39jZ6F6b0s+biSesKu+rkJxOPrSUk4N46bRHq6VB/YoaLGrM1Qghx8vbyObNBvmwFGaE79SaOzNB3b+gIiySy8/qYEAEMPWu70F+uyRhMfbENYpSokMbUOXbInIOpAMy3qAnTPDioKqe/Dn8J4cS28/Qwu69StcbnGscJgIqdKEfuJoLF7YYXUHugIq4sKrP0sBBRdz5jaG6dP4mNtQkhi4V/q+pltlOyyXUP3TV1XjWXjiDSiTUfj+SGeTdtlNXcIheCDUUXt95h6yU/UL9X2kFAY1oP5ynL1iUq9g2Owj5l7BZYDK/yZv0nQYzuKwaYBernMXUgKzY8O9kybCGJWw8CjDn9lbxGB8wqO0zJy1zKfHlWQJoi4yAOQnQmLFUo1R1n5yHEIPfG5PMihglHMVCbCKfqRhRyIdTnQv4xXGEsrHwIZoyogV9npp8QOEaLauIUwD7+HWCt1njZkXz7L1w3c/6wJQgqQQqW3ZWDa/vi2Rr/k5z6aMGRituZ6py4KN556e42va3f5+ZlPe8pyL6g1QBRzTqkB5sFqvKGnm38VwPdX8LyLxoZ0UFowHUGBKeXQqpEDfIRBnm7k1ZNTCWWz9t6q52DjBPBrFQ4/5KPKtUJw03DlYe+Dcd3omqxEMJO6oMVzuOcll1JttwGuyRclL57QHSphuWVpdispYOlfRUP1KlsrW7Pfhec9jIlTE89BGkRaML/dDJQwvv8vJm26Cs8Gvag8vw/YBTrd1RfPnh8n3Aqp/XhGQKw9YJRR6YbLqWkqcl8dVRxuK+6BSDqDbWQUYNN9lNMFE82ug8hLTHFpVlQhaNe9315xddXijKGvK1mQmsSrWdKTblan+h5uiSsBPGaxq9AvW6rT6KYqOd8JIXsDIve9HXJnzgmTJ0muxBDAiC7jKjkxmtcc4OSIeYbJWjyXW83gs0ccpCHa3mDBt1RkPJH7n6AwHCbY42HAmR+zo4ewD3b7c7lrwZ9c3K5VWpEXnbCQlySSPCWXkAQNJlcFLKyAXOeARJYui6dUB1UyqnExu7yEVvEuthJV4uQPrvY6HqHbgKiY4KcxzzOjVctOtgbBGZrimArvU+9uGse/P+LaEuT4QQH50/CABBzzGCWGvU6vbtB95z9WAvH8U+f3qjVbxzC9Ypqxn4/SRNRwrUCeH3axdwYV9jHtutEaK9pRuyxHoH2eRfOcND7RgQNTHPuo3dyaAhKA3GAszxqi7eb6tuq+wzyBNSf9KXTdG7NTdeKWCE2 X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 291b8fea-d4a7-4fd3-0c89-08db707eb6e0 X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 04:36:14.1669 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Typkucn6yuskSBXL9gG5HvoJSwDoql0MUOWpdwe81WR1pjG0I2UHOcwQy/gZXNLQsG+7o9HfqAulX7XG9absMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4984 X-Proofpoint-ORIG-GUID: UQh9rhOrCByUk7bSl_WNOGaPjZ2TXYux X-Proofpoint-GUID: UQh9rhOrCByUk7bSl_WNOGaPjZ2TXYux X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-19_02,2023-06-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 adultscore=0 clxscore=1015 impostorscore=0 phishscore=0 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0 mlxlogscore=897 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306190041 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 19 Jun 2023 04:36:21 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-core/message/183087 From: Chen Qi Now that unzip's configure can correctly do the detection even in case of cross compilation, there's no need to use this hardcoded LARGE_FILE_SUPPORT flag. Signed-off-by: Chen Qi --- meta/recipes-extended/unzip/unzip_6.0.bb | 3 --- 1 file changed, 3 deletions(-) diff --git a/meta/recipes-extended/unzip/unzip_6.0.bb b/meta/recipes-extended/unzip/unzip_6.0.bb index 391e5cd22a..3051e9b5bc 100644 --- a/meta/recipes-extended/unzip/unzip_6.0.bb +++ b/meta/recipes-extended/unzip/unzip_6.0.bb @@ -47,9 +47,6 @@ UPSTREAM_CHECK_REGEX = "unzip(?P(?!552).+)\.tgz" S = "${WORKDIR}/unzip60" -# Enable largefile support -CFLAGS += "-DLARGE_FILE_SUPPORT" - # Makefile uses CF_NOOPT instead of CFLAGS. We lifted the values from # Makefile and add CFLAGS. Optimization will be overriden by unzip # configure to be -O3.