[v2,2/2] manuals: SYSTEMD_SERVICE overrides depend on SYSTEMD_PACKAGES

Message ID 20220607084254.2694011-2-ptsneves@gmail.com
State Accepted, archived
Delegated to: Armin Kuster
Headers show
Series [v2,1/2] manuals: SYSTEMD_SERVICE allows multiple services | expand

Commit Message

Paulo Neves June 7, 2022, 8:42 a.m. UTC
Add detail that package overrides are only available if
specified in SYSTEMD_PACKAGES.

Signed-off-by: Paulo Neves <ptsneves@gmail.com>
---
 documentation/ref-manual/variables.rst | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Michael Opdenacker June 7, 2022, 8:53 a.m. UTC | #1
Hi Paulo

On 6/7/22 10:42, Paulo Neves wrote:
> Add detail that package overrides are only available if
> specified in SYSTEMD_PACKAGES.
>
> Signed-off-by: Paulo Neves <ptsneves@gmail.com>
> ---
>  documentation/ref-manual/variables.rst | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
> index 42178d556..e31f0ed88 100644
> --- a/documentation/ref-manual/variables.rst
> +++ b/documentation/ref-manual/variables.rst
> @@ -7664,6 +7664,10 @@ system and gives an overview of their function and contents.
>  
>           SYSTEMD_SERVICE:${PN} = "connman.service"
>  
> +      The package overrides that can be specified are directly related to the value of
> +      term:`SYSTEMD_PACKAGES`. Overrides not included in term:`SYSTEMD_PACKAGES`
> +      will be silently ignored.
> +
>     :term:`SYSVINIT_ENABLED_GETTYS`
>        When using
>        :ref:`SysVinit <dev-manual/common-tasks:enabling system services>`,

Thanks for the patch. Merged into yocto-docs' master-next

Don't forget to copy the docs@lists.yoctoproject.org mailing list next time.

Thanks again

Michael.
Paulo Neves June 7, 2022, 8:54 a.m. UTC | #2
Hi Michael,

My sincere apologies. Will try to improve next time

Paulo Neves

On 6/7/22 10:53, Michael Opdenacker wrote:
> Hi Paulo
>
> On 6/7/22 10:42, Paulo Neves wrote:
>> Add detail that package overrides are only available if
>> specified in SYSTEMD_PACKAGES.
>>
>> Signed-off-by: Paulo Neves <ptsneves@gmail.com>
>> ---
>>   documentation/ref-manual/variables.rst | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
>> index 42178d556..e31f0ed88 100644
>> --- a/documentation/ref-manual/variables.rst
>> +++ b/documentation/ref-manual/variables.rst
>> @@ -7664,6 +7664,10 @@ system and gives an overview of their function and contents.
>>   
>>            SYSTEMD_SERVICE:${PN} = "connman.service"
>>   
>> +      The package overrides that can be specified are directly related to the value of
>> +      term:`SYSTEMD_PACKAGES`. Overrides not included in term:`SYSTEMD_PACKAGES`
>> +      will be silently ignored.
>> +
>>      :term:`SYSVINIT_ENABLED_GETTYS`
>>         When using
>>         :ref:`SysVinit <dev-manual/common-tasks:enabling system services>`,
> Thanks for the patch. Merged into yocto-docs' master-next
>
> Don't forget to copy the docs@lists.yoctoproject.org mailing list next time.
>
> Thanks again
>
> Michael.
>

Patch

diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst
index 42178d556..e31f0ed88 100644
--- a/documentation/ref-manual/variables.rst
+++ b/documentation/ref-manual/variables.rst
@@ -7664,6 +7664,10 @@  system and gives an overview of their function and contents.
 
          SYSTEMD_SERVICE:${PN} = "connman.service"
 
+      The package overrides that can be specified are directly related to the value of
+      term:`SYSTEMD_PACKAGES`. Overrides not included in term:`SYSTEMD_PACKAGES`
+      will be silently ignored.
+
    :term:`SYSVINIT_ENABLED_GETTYS`
       When using
       :ref:`SysVinit <dev-manual/common-tasks:enabling system services>`,