| Message ID | 20230207141217.33892-1-alexis.lothore@bootlin.com |
|---|---|
| Headers | show |
| Series | ease send-qa-email usage with older history | expand |
On Tue, 2023-02-07 at 15:12 +0100, Alexis Lothoré via lists.yoctoproject.org wrote: > Hello, > this minor patch series bring minor fixes into send-qa-email to ease > development/debugging in it: > - fetching current build test results works well in CI builds because we are > sure that the build results will be in the 5 upper commits of testsresults > repository shallow clone (because it has been pushed just before preparing the > regression report). It is not true when trying to run send-qa-email offline on > older revisions (for development, debugging or improvement of scripting), so > we need to force-fetch the target revision as it is done currently for the > base revision. As a consequence, this new behaviour allows to make even more > "shallow" clones of testresults since all needed data will be force-fetched > - When downloading a test regression report on official release webserver, we do > not have information about what base have been used or what is the exact > tested revision (at least, without checking the corresponding build logs on > autobuilder). So I propose to add this information at the top of each > regression report, making it look like this: > > ========================== Regression report ============================== > => Target: master (5e249ec855517765f4b99e8039cb888ffa09c211) > => Base: 4.2_M1 (4d19594b8bdacde6d809d3f2a25cff7c5a42295e) > =========================================================================== > > Match: oeselftest_almalinux-9.1_qemux86-64_20221208113119 > oeselftest_centos-8_qemux86-64_20230126230327 > Match: oeselftest_debian-11_qemux86-64_20221208033325 > oeselftest_debian-11_qemux86-64_20230126150229 > [...] > > I assumed that no tool is currently trying to parse the regression reports, so > I chose arbitrarily the metadata format. The reports have never been useful enough to parse so that should be fine. > @Richard : on a side note, the broken From field in my previous emails was probably > due to an accent in my name, it should be fixed now. Please let me know if you > still have issues with this, in this case I will force the --from field. It still shows incorrectly for me. It is an issue with the bootlin mail setup and DNS, not to do with the character encoding. My changing the accent, it is now duplicating the signed off by lines so I'd avoid doing that! Cheers, Richard
Hello Richard, On 2/7/23 15:42, Richard Purdie wrote: > On Tue, 2023-02-07 at 15:12 +0100, Alexis Lothoré via > lists.yoctoproject.org wrote: >> I assumed that no tool is currently trying to parse the regression reports, so >> I chose arbitrarily the metadata format. > > The reports have never been useful enough to parse so that should be > fine. Good >> @Richard : on a side note, the broken From field in my previous emails was probably >> due to an accent in my name, it should be fixed now. Please let me know if you >> still have issues with this, in this case I will force the --from field. > > It still shows incorrectly for me. It is an issue with the bootlin mail > setup and DNS, not to do with the character encoding. My changing the > accent, it is now duplicating the signed off by lines so I'd avoid > doing that! Well, that's a shame, sorry for the annoyance. Once the patches are approved or lead to a v2, I will resend with "From:" forced, except if you want me to re-send it right now.
On Tue, 2023-02-07 at 15:52 +0100, Alexis Lothoré wrote: > Hello Richard, > > On 2/7/23 15:42, Richard Purdie wrote: > > On Tue, 2023-02-07 at 15:12 +0100, Alexis Lothoré via > > lists.yoctoproject.org wrote: > > > I assumed that no tool is currently trying to parse the regression reports, so > > > I chose arbitrarily the metadata format. > > > > The reports have never been useful enough to parse so that should be > > fine. > > Good > > > > @Richard : on a side note, the broken From field in my previous emails was probably > > > due to an accent in my name, it should be fixed now. Please let me know if you > > > still have issues with this, in this case I will force the --from field. > > > > It still shows incorrectly for me. It is an issue with the bootlin mail > > setup and DNS, not to do with the character encoding. My changing the > > accent, it is now duplicating the signed off by lines so I'd avoid > > doing that! > Well, that's a shame, sorry for the annoyance. Once the patches are approved or > lead to a v2, I will resend with "From:" forced, except if you want me to > re-send it right now. Patches look otherwise ok to me so please resend! Cheers, Richard
Hello, this minor patch series bring minor fixes into send-qa-email to ease development/debugging in it: - fetching current build test results works well in CI builds because we are sure that the build results will be in the 5 upper commits of testsresults repository shallow clone (because it has been pushed just before preparing the regression report). It is not true when trying to run send-qa-email offline on older revisions (for development, debugging or improvement of scripting), so we need to force-fetch the target revision as it is done currently for the base revision. As a consequence, this new behaviour allows to make even more "shallow" clones of testresults since all needed data will be force-fetched - When downloading a test regression report on official release webserver, we do not have information about what base have been used or what is the exact tested revision (at least, without checking the corresponding build logs on autobuilder). So I propose to add this information at the top of each regression report, making it look like this: ========================== Regression report ============================== => Target: master (5e249ec855517765f4b99e8039cb888ffa09c211) => Base: 4.2_M1 (4d19594b8bdacde6d809d3f2a25cff7c5a42295e) =========================================================================== Match: oeselftest_almalinux-9.1_qemux86-64_20221208113119 oeselftest_centos-8_qemux86-64_20230126230327 Match: oeselftest_debian-11_qemux86-64_20221208033325 oeselftest_debian-11_qemux86-64_20230126150229 [...] I assumed that no tool is currently trying to parse the regression reports, so I chose arbitrarily the metadata format. @Richard : on a side note, the broken From field in my previous emails was probably due to an accent in my name, it should be fixed now. Please let me know if you still have issues with this, in this case I will force the --from field. Alexis Lothore (3): scripts/send-qa-email: force current revision fetch scripts/send-qa-email: reduce testresults shallow clone depth scripts/send-qa-email: add target and base revisions in regression report scripts/send_qa_email.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)