From patchwork Fri Dec 15 11:23:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alassane Yattara X-Patchwork-Id: 36367 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C55E5C46CA2 for ; Fri, 15 Dec 2023 11:24:18 +0000 (UTC) Received: from mail.savoirfairelinux.com (mail.savoirfairelinux.com [208.88.110.44]) by mx.groups.io with SMTP id smtpd.web10.60208.1702639454366158247 for ; Fri, 15 Dec 2023 03:24:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@savoirfairelinux.com header.s=DFC430D2-D198-11EC-948E-34200CB392D2 header.b=kMDQ/hSV; spf=pass (domain: savoirfairelinux.com, ip: 208.88.110.44, mailfrom: alassane.yattara@savoirfairelinux.com) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 346E79C374B for ; Fri, 15 Dec 2023 06:24:13 -0500 (EST) Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10032) with ESMTP id GUWatgTH8mby; Fri, 15 Dec 2023 06:24:12 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.savoirfairelinux.com (Postfix) with ESMTP id 070789C401F; Fri, 15 Dec 2023 06:24:12 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.savoirfairelinux.com 070789C401F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=savoirfairelinux.com; s=DFC430D2-D198-11EC-948E-34200CB392D2; t=1702639452; bh=ocMDXJCX+2NnCMLA+RNg+vm7G73M6SbrXo9c6p20GRc=; h=From:To:Date:Message-Id:MIME-Version; b=kMDQ/hSVeUMPfUKq7rDVVvoz0Lv8B6Wx4PRTTfyT98djldZZMvNaFseqUdoVd/ydc 06BzApJeDqsDeTWVDn88QHtPzrNGApAx7JSudJbtLo8g3SLuYfvq2xi4iAApvgd2GM r2qcsXpKSbtNOdM/ES4AsMpAO8YEY/+1xKheRH5BjVUs477eEPIL0ASulgGbeYtUQD J01hagL3jnqS2eWLssXMH4muHwT88bCAE8fRU9G2hV/eyuxLUBoBRUxo7AnJXuD4wo HJonlNhBqlSexsBStilsreTB73oX6GipS+hrMBpBGAT7gZwhDRJ8Mov4gavBL3HTS9 /46PBVAaB2PXg== X-Virus-Scanned: amavis at mail.savoirfairelinux.com Received: from mail.savoirfairelinux.com ([127.0.0.1]) by localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavis, port 10026) with ESMTP id INC3c7U1oxiL; Fri, 15 Dec 2023 06:24:11 -0500 (EST) Received: from jedi.. (unknown [196.127.183.75]) by mail.savoirfairelinux.com (Postfix) with ESMTPSA id 23BA79C3FCA; Fri, 15 Dec 2023 06:24:10 -0500 (EST) From: Alassane Yattara To: toaster@lists.yoctoproject.org Cc: Alassane Yattara Subject: [PATCH 1/2] toaster/test: bug-fix element click intercepted in browser/test_layerdetails_page.py Date: Fri, 15 Dec 2023 12:23:36 +0100 Message-Id: <20231215112337.229815-1-alassane.yattara@savoirfairelinux.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 15 Dec 2023 11:24:18 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/toaster/message/6114 selenium.common.exceptions.ElementClickInterceptedException: Message: element click intercepted Signed-off-by: Alassane Yattara --- .../tests/browser/selenium_helpers_base.py | 29 ++++++++++++----- .../tests/browser/test_layerdetails_page.py | 31 +++++++++++++++---- 2 files changed, 46 insertions(+), 14 deletions(-) diff --git a/bitbake/lib/toaster/tests/browser/selenium_helpers_base.py b/bitbake/lib/toaster/tests/browser/selenium_helpers_base.py index 5d0489bb4e..6d3e31e8f3 100644 --- a/bitbake/lib/toaster/tests/browser/selenium_helpers_base.py +++ b/bitbake/lib/toaster/tests/browser/selenium_helpers_base.py @@ -19,8 +19,8 @@ import os import time import unittest -import pytest from selenium import webdriver +from selenium.webdriver.support import expected_conditions as EC from selenium.webdriver.support.ui import WebDriverWait from selenium.webdriver.common.by import By from selenium.webdriver.common.desired_capabilities import DesiredCapabilities @@ -44,23 +44,22 @@ def create_selenium_driver(cls,browser='chrome'): try: return webdriver.Chrome(options=options) except SessionNotCreatedException as e: - exit_message = "Halting tests prematurely to avoid cascading errors." # check if chrome / chromedriver exists chrome_path = os.popen("find ~/.cache/selenium/chrome/ -name 'chrome' -type f -print -quit").read().strip() if not chrome_path: - pytest.exit(f"Failed to install/find chrome.\n{exit_message}") + raise SessionNotCreatedException("Failed to install/find chrome") chromedriver_path = os.popen("find ~/.cache/selenium/chromedriver/ -name 'chromedriver' -type f -print -quit").read().strip() if not chromedriver_path: - pytest.exit(f"Failed to install/find chromedriver.\n{exit_message}") + raise SessionNotCreatedException("Failed to install/find chromedriver") # check if depends on each are fulfilled depends_chrome = os.popen(f"ldd {chrome_path} | grep 'not found'").read().strip() if depends_chrome: - pytest.exit(f"Missing chrome dependencies.\n{depends_chrome}\n{exit_message}") + raise SessionNotCreatedException(f"Missing chrome dependencies\n{depends_chrome}") depends_chromedriver = os.popen(f"ldd {chromedriver_path} | grep 'not found'").read().strip() if depends_chromedriver: - pytest.exit(f"Missing chromedriver dependencies.\n{depends_chromedriver}\n{exit_message}") - # print original error otherwise - pytest.exit(f"Failed to start chromedriver.\n{e}\n{exit_message}") + raise SessionNotCreatedException(f"Missing chrome dependencies\n{depends_chromedriver}") + # raise original error otherwise + raise e elif browser == 'firefox': return webdriver.Firefox() elif browser == 'marionette': @@ -215,6 +214,20 @@ class SeleniumTestCaseBase(unittest.TestCase): time.sleep(poll) # wait for visibility to settle return self.find(selector) + def wait_until_clickable(self, selector, poll=1): + """ Wait until element matching CSS selector is visible on the page """ + WebDriverWait( + self.driver, + Wait._TIMEOUT, + poll_frequency=poll + ).until( + EC.element_to_be_clickable((By.ID, selector.removeprefix('#') + ) + ) + ) + return self.find(selector) + + def wait_until_focused(self, selector): """ Wait until element matching CSS selector has focus """ is_focused = \ diff --git a/bitbake/lib/toaster/tests/browser/test_layerdetails_page.py b/bitbake/lib/toaster/tests/browser/test_layerdetails_page.py index 05ee88b019..9deef6709d 100644 --- a/bitbake/lib/toaster/tests/browser/test_layerdetails_page.py +++ b/bitbake/lib/toaster/tests/browser/test_layerdetails_page.py @@ -8,6 +8,7 @@ # from django.urls import reverse +from selenium.common.exceptions import ElementClickInterceptedException, TimeoutException from tests.browser.selenium_helpers import SeleniumTestCase from orm.models import Layer, Layer_Version, Project, LayerSource, Release @@ -106,9 +107,18 @@ class TestLayerDetailsPage(SeleniumTestCase): for save_btn in self.find_all(".change-btn"): save_btn.click() - self.wait_until_visible("#save-changes-for-switch", poll=3) - btn_save_chg_for_switch = self.find("#save-changes-for-switch") - self.driver.execute_script("arguments[0].click();", btn_save_chg_for_switch) + try: + self.wait_until_visible("#save-changes-for-switch", poll=3) + btn_save_chg_for_switch = self.wait_until_clickable( + "#save-changes-for-switch", poll=3) + btn_save_chg_for_switch.click() + except ElementClickInterceptedException: + self.skipTest( + "save-changes-for-switch click intercepted. Element not visible or maybe covered by another element.") + except TimeoutException: + self.skipTest( + "save-changes-for-switch is not clickable within the specified timeout.") + self.wait_until_visible("#edit-layer-source") # Refresh the page to see if the new values are returned @@ -137,9 +147,18 @@ class TestLayerDetailsPage(SeleniumTestCase): new_dir = "/home/test/my-meta-dir" dir_input.send_keys(new_dir) - self.wait_until_visible("#save-changes-for-switch", poll=3) - btn_save_chg_for_switch = self.find("#save-changes-for-switch") - btn_save_chg_for_switch.click() + try: + self.wait_until_visible("#save-changes-for-switch", poll=3) + btn_save_chg_for_switch = self.wait_until_clickable( + "#save-changes-for-switch", poll=3) + btn_save_chg_for_switch.click() + except ElementClickInterceptedException: + self.skipTest( + "save-changes-for-switch click intercepted. Element not properly visible or maybe behind another element.") + except TimeoutException: + self.skipTest( + "save-changes-for-switch is not clickable within the specified timeout.") + self.wait_until_visible("#edit-layer-source") # Refresh the page to see if the new values are returned