diff mbox series

[meta-oe] signing.bbclass: fix wrong function name

Message ID 20240223084544.1793722-1-sha@pengutronix.de
State Accepted
Headers show
Series [meta-oe] signing.bbclass: fix wrong function name | expand

Commit Message

Sascha Hauer Feb. 23, 2024, 8:45 a.m. UTC 
The function signing_import_pubkey_from_pem is defined twice, one of
them should really be named signing_import_pubkey_from_der. Fix this and
while at it fix some argument names in the comments above the functions
as well.

Reported-by: Miklos Toth <Miklos.Toth@knorr-bremse.com>
Fixes: 4a6ac691f ("add signing.bbclass as infrastructure for build artifact signing")
Signed-off-by: Sascha Hauer <sha@pengutronix.de>
---
 meta-oe/classes/signing.bbclass | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/meta-oe/classes/signing.bbclass b/meta-oe/classes/signing.bbclass
index 553d74e28..ec076d968 100644
--- a/meta-oe/classes/signing.bbclass
+++ b/meta-oe/classes/signing.bbclass
@@ -142,10 +142,10 @@  signing_import_cert_from_pem() {
     signing_pkcs11_tool --type cert --write-object /proc/self/fd/0 --label "${role}"
 }
 
-# signing_import_pubkey_from_der <role> <pem>
+# signing_import_pubkey_from_der <role> <der>
 #
 # Import a public key from DER file to a role. To be used with SoftHSM.
-signing_import_pubkey_from_pem() {
+signing_import_pubkey_from_der() {
     local role="${1}"
     local der="${2}"
 
@@ -171,7 +171,7 @@  signing_import_pubkey_from_pem() {
     signing_pkcs11_tool --type pubkey --write-object /proc/self/fd/0 --label "${role}"
 }
 
-# signing_import_privkey_from_der <role> <pem>
+# signing_import_privkey_from_der <role> <der>
 #
 # Import a private key from DER file to a role. To be used with SoftHSM.
 signing_import_privkey_from_der() {