diff mbox series

[OE-core,master] android-tools: Enable position-independent executable

Message ID 20240222125551.66224-1-badganchipv@gmail.com
State Not Applicable
Headers show
Series [OE-core,master] android-tools: Enable position-independent executable | expand

Commit Message

Pawan Badganchi Feb. 22, 2024, 12:55 p.m. UTC 
Enable position-independent executable security flag for adb
and fastboot. Verified that flag is enabled by using checksec.py

Upstream-Status: Pending

Signed-off-by: Pawan <badganchipv@gmail.com>
---
 .../recipes-devtool/android-tools/android-tools_29.0.6.r14.bb   | 2 ++
 1 file changed, 2 insertions(+)

Comments

Pawan Badganchi Feb. 22, 2024, 1:02 p.m. UTC | #1 
Please ignore this patch.
Martin Jansa Feb. 22, 2024, 1:11 p.m. UTC | #2 
[OE-core] tag doesn't belong to subject for meta-oe patches, use [meta-oe]
instead.

Upstream-Status belongs to .patch files in the metadata, not to commit
message of metadata changes.

On Thu, Feb 22, 2024 at 1:56 PM Pawan Badganchi <badganchipv@gmail.com>
wrote:

> Enable position-independent executable security flag for adb
> and fastboot. Verified that flag is enabled by using checksec.py
>
> Upstream-Status: Pending
>
> Signed-off-by: Pawan <badganchipv@gmail.com>
> ---
>  .../recipes-devtool/android-tools/android-tools_29.0.6.r14.bb   | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/
> android-tools_29.0.6.r14.bb
> b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/
> android-tools_29.0.6.r14.bb
> index fbad5e136..6ec90c2f5 100644
> --- a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/
> android-tools_29.0.6.r14.bb
> +++ b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/
> android-tools_29.0.6.r14.bb
> @@ -77,6 +77,8 @@ PREREQUISITE_core = "liblog libbase libsparse liblog
> libcutils"
>  TOOLS_TO_BUILD = "libcrypto_utils libadb libziparchive fastboot adb
> img2simg simg2img libbacktrace"
>  TOOLS_TO_BUILD:append:class-target = " adbd"
>
> +SECURITY_CFLAGS:append:aarch64 = " -pie -fPIE"
> +
>  do_compile() {
>
>      case "${HOST_ARCH}" in
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#108983):
> https://lists.openembedded.org/g/openembedded-devel/message/108983
> Mute This Topic: https://lists.openembedded.org/mt/104507422/3617156
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> martin.jansa@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Pawan Badganchi Feb. 22, 2024, 1:13 p.m. UTC | #3 
Thank you, but ignore this patch
diff mbox series

Patch

diff --git a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools_29.0.6.r14.bb b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools_29.0.6.r14.bb
index fbad5e136..6ec90c2f5 100644
--- a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools_29.0.6.r14.bb
+++ b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools_29.0.6.r14.bb
@@ -77,6 +77,8 @@  PREREQUISITE_core = "liblog libbase libsparse liblog libcutils"
 TOOLS_TO_BUILD = "libcrypto_utils libadb libziparchive fastboot adb img2simg simg2img libbacktrace"
 TOOLS_TO_BUILD:append:class-target = " adbd"
 
+SECURITY_CFLAGS:append:aarch64 = " -pie -fPIE"
+
 do_compile() {
 
     case "${HOST_ARCH}" in