diff mbox series

[meta-java] xml-commons: xom: Update github entry

Message ID 20240209181917.1941840-1-festevam@gmail.com
State Rejected, archived
Delegated to: Tim Orling
Headers show
Series [meta-java] xml-commons: xom: Update github entry | expand

Commit Message

Fabio Estevam Feb. 9, 2024, 6:19 p.m. UTC
From: Fabio Estevam <festevam@denx.de>

Switch to using https, pass protocol and the branch name to fix
the following warnings:

WARNING: .../meta-java/recipes-core/xml-commons/xom_1.2.10.bb: URL: git://github.com/codehaus/jaxen;name=jaxen uses git protocol which is no longer supported by github. Please change to ;protocol=https in the url.
WARNING: .../meta-java/recipes-core/xml-commons/xom_1.2.10.bb: URL: git://github.com/codehaus/jaxen;name=jaxen does not set any branch parameter. The future default branch used by tools and repositories is uncertain and we will therefore soon require this is set in all git urls.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 recipes-core/xml-commons/xom_1.2.10.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tim Orling Feb. 9, 2024, 7:42 p.m. UTC | #1
On Fri, Feb 9, 2024 at 10:19 AM Fabio Estevam <festevam@gmail.com> wrote:

> From: Fabio Estevam <festevam@denx.de>
>
> Switch to using https, pass protocol and the branch name to fix
> the following warnings:
>
> WARNING: .../meta-java/recipes-core/xml-commons/xom_1.2.10.bb: URL: git://
> github.com/codehaus/jaxen;name=jaxen uses git protocol which is no longer
> supported by github. Please change to ;protocol=https in the url.
> WARNING: .../meta-java/recipes-core/xml-commons/xom_1.2.10.bb: URL: git://
> github.com/codehaus/jaxen;name=jaxen does not set any branch parameter.
> The future default branch used by tools and repositories is uncertain and
> we will therefore soon require this is set in all git urls.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  recipes-core/xml-commons/xom_1.2.10.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-core/xml-commons/xom_1.2.10.bb
> b/recipes-core/xml-commons/xom_1.2.10.bb
> index 42ad957..2eed0fe 100644
> --- a/recipes-core/xml-commons/xom_1.2.10.bb
> +++ b/recipes-core/xml-commons/xom_1.2.10.bb
> @@ -14,7 +14,7 @@ PV_jaxen = "1.1.6"
>
>  SRC_URI = "\
>         http://www.cafeconleche.org/XOM/${P}-src.tar.gz;name=archive \
> -       git://github.com/codehaus/${SRCNAME_jaxen};name=jaxen
> <http://github.com/codehaus/$%7BSRCNAME_jaxen%7D;name=jaxen> \
> +
> https://github.com/codehaus/${SRCNAME_jaxen};protocol=https;branch=master
> \
>

You should not drop the name=jaxen, pretty sure that is required for the
SRCREV_jaxen to work?

We should also drop the archive.md5sum... we haven't used md5sum in quite
some time.

        file://04_remove_sun_import.patch \
>  "
>  SRC_URI[archive.md5sum] = "9f3a2ae827a9f6826fe76e4b7b0c22b3"
> --
> 2.37.3
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#108690):
> https://lists.openembedded.org/g/openembedded-devel/message/108690
> Mute This Topic: https://lists.openembedded.org/mt/104264377/924729
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> ticotimo@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Tim Orling March 22, 2024, 2:01 p.m. UTC | #2
On Fri, Feb 9, 2024 at 11:43 AM Tim Orling via lists.openembedded.org
<ticotimo=gmail.com@lists.openembedded.org> wrote:

>
>
> On Fri, Feb 9, 2024 at 10:19 AM Fabio Estevam <festevam@gmail.com> wrote:
>
>> From: Fabio Estevam <festevam@denx.de>
>>
>> Switch to using https, pass protocol and the branch name to fix
>> the following warnings:
>>
>> WARNING: .../meta-java/recipes-core/xml-commons/xom_1.2.10.bb: URL:
>> git://github.com/codehaus/jaxen;name=jaxen uses git protocol which is no
>> longer supported by github. Please change to ;protocol=https in the url.
>> WARNING: .../meta-java/recipes-core/xml-commons/xom_1.2.10.bb: URL:
>> git://github.com/codehaus/jaxen;name=jaxen does not set any branch
>> parameter. The future default branch used by tools and repositories is
>> uncertain and we will therefore soon require this is set in all git urls.
>>
>> Signed-off-by: Fabio Estevam <festevam@denx.de>
>> ---
>>  recipes-core/xml-commons/xom_1.2.10.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-core/xml-commons/xom_1.2.10.bb
>> b/recipes-core/xml-commons/xom_1.2.10.bb
>> index 42ad957..2eed0fe 100644
>> --- a/recipes-core/xml-commons/xom_1.2.10.bb
>> +++ b/recipes-core/xml-commons/xom_1.2.10.bb
>> @@ -14,7 +14,7 @@ PV_jaxen = "1.1.6"
>>
>>  SRC_URI = "\
>>         http://www.cafeconleche.org/XOM/${P}-src.tar.gz;name=archive \
>> -       git://github.com/codehaus/${SRCNAME_jaxen};name=jaxen
>> <http://github.com/codehaus/$%7BSRCNAME_jaxen%7D;name=jaxen> \
>> +
>> https://github.com/codehaus/${SRCNAME_jaxen};protocol=https;branch=master
>> \
>>
> This is incorrect. You needed to add the `protocol=https;` but leave
`git://` as the fetcher. These are not
URIs like you would type for wget or curl.


>
> You should not drop the name=jaxen, pretty sure that is required for the
> SRCREV_jaxen to work?
>
> We should also drop the archive.md5sum... we haven't used md5sum in quite
> some time.
>
>         file://04_remove_sun_import.patch \
>>  "
>>  SRC_URI[archive.md5sum] = "9f3a2ae827a9f6826fe76e4b7b0c22b3"
>> --
>> 2.37.3
>>
>>
>>
>>
>>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#108691):
> https://lists.openembedded.org/g/openembedded-devel/message/108691
> Mute This Topic: https://lists.openembedded.org/mt/104264377/924729
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> ticotimo@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
diff mbox series

Patch

diff --git a/recipes-core/xml-commons/xom_1.2.10.bb b/recipes-core/xml-commons/xom_1.2.10.bb
index 42ad957..2eed0fe 100644
--- a/recipes-core/xml-commons/xom_1.2.10.bb
+++ b/recipes-core/xml-commons/xom_1.2.10.bb
@@ -14,7 +14,7 @@  PV_jaxen = "1.1.6"
 
 SRC_URI = "\
 	http://www.cafeconleche.org/XOM/${P}-src.tar.gz;name=archive \
-	git://github.com/codehaus/${SRCNAME_jaxen};name=jaxen \
+	https://github.com/codehaus/${SRCNAME_jaxen};protocol=https;branch=master \
 	file://04_remove_sun_import.patch \
 "
 SRC_URI[archive.md5sum] = "9f3a2ae827a9f6826fe76e4b7b0c22b3"