diff mbox series

[meta-python,kirkstone,1/2] python3-cson: fix DEPENDS on python3-native

Message ID 20231117091824.450741-1-yoann.congal@smile.fr
State New
Headers show
Series [meta-python,kirkstone,1/2] python3-cson: fix DEPENDS on python3-native | expand

Commit Message

Yoann Congal Nov. 17, 2023, 9:18 a.m. UTC
python-native is not provided by meta-python anymore and this is clearly
a python3 recipe.

Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
---
 meta-python/recipes-extended/python-cson/python3-cson_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yoann Congal Nov. 17, 2023, 11:07 p.m. UTC | #1
Le 17/11/2023 à 10:18, Yoann Congal a écrit :
> python-native is not provided by meta-python anymore and this is clearly
> a python3 recipe.
> 
> Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
> ---
>  meta-python/recipes-extended/python-cson/python3-cson_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-python/recipes-extended/python-cson/python3-cson_git.bb b/meta-python/recipes-extended/python-cson/python3-cson_git.bb
> index c4fcc61ec..da174ad55 100644
> --- a/meta-python/recipes-extended/python-cson/python3-cson_git.bb
> +++ b/meta-python/recipes-extended/python-cson/python3-cson_git.bb
> @@ -13,7 +13,7 @@ SRC_URI = "git://github.com/gt3389b/python-cson.git;branch=master;protocol=https
>  S = "${WORKDIR}/git"
>  
>  RDEPENDS:${PN}:class-native = ""
> -DEPENDS:append:class-native = " python-native "
> +DEPENDS:append:class-native = " python3-native "
>  
>  inherit setuptools3
>  

It would be better to backport https://git.openembedded.org/meta-openembedded/commit/?id=40b4cf5a83098a5f1be873be5c29f26380bc7993 instead of this patch
In the current state :
root@qemux86-64:~# python-cson
Traceback (most recent call last):
  File "/usr/bin/python-cson", line 5, in <module>
    from cson import main
  File "/usr/lib/python3.10/site-packages/cson.py", line 11, in <module>
    import argparse, copy, json, sys
ModuleNotFoundError: No module named 'json'

I'll send the backport.
Yoann Congal Nov. 17, 2023, 11:18 p.m. UTC | #2
Le 18/11/2023 à 00:07, Yoann Congal a écrit :
> Le 17/11/2023 à 10:18, Yoann Congal a écrit :
>> python-native is not provided by meta-python anymore and this is clearly
>> a python3 recipe.
>>
>> Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
>> ---
>>  meta-python/recipes-extended/python-cson/python3-cson_git.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-python/recipes-extended/python-cson/python3-cson_git.bb b/meta-python/recipes-extended/python-cson/python3-cson_git.bb
>> index c4fcc61ec..da174ad55 100644
>> --- a/meta-python/recipes-extended/python-cson/python3-cson_git.bb
>> +++ b/meta-python/recipes-extended/python-cson/python3-cson_git.bb
>> @@ -13,7 +13,7 @@ SRC_URI = "git://github.com/gt3389b/python-cson.git;branch=master;protocol=https
>>  S = "${WORKDIR}/git"
>>  
>>  RDEPENDS:${PN}:class-native = ""
>> -DEPENDS:append:class-native = " python-native "
>> +DEPENDS:append:class-native = " python3-native "
>>  
>>  inherit setuptools3
>>  
> 
> It would be better to backport https://git.openembedded.org/meta-openembedded/commit/?id=40b4cf5a83098a5f1be873be5c29f26380bc7993 instead of this patch
> In the current state :
> root@qemux86-64:~# python-cson
> Traceback (most recent call last):
>   File "/usr/bin/python-cson", line 5, in <module>
>     from cson import main
>   File "/usr/lib/python3.10/site-packages/cson.py", line 11, in <module>
>     import argparse, copy, json, sys
> ModuleNotFoundError: No module named 'json'
> 
> I'll send the backport.
Here it is :
[meta-python][kirkstone][PATCH] python3-cson: fix run-time dependencies
https://lists.openembedded.org/g/openembedded-devel/message/106881

With the backport the python-cson tool does start so this patch should definitely be dropped in favor of the backport.
root@qemux86-64:~# python-cson 
usage: python-cson [-h] -f OUTPUT_FILE [-v] input_file
python-cson: error: the following arguments are required: -f/--file, input_file

Regards,
akuster808 Nov. 18, 2023, 3:03 p.m. UTC | #3
Hello Yoann,

thanks for the followup.  I believe I got series sorted out.

-Armin

On 11/17/23 6:18 PM, Yoann Congal wrote:
> Le 18/11/2023 à 00:07, Yoann Congal a écrit :
>> Le 17/11/2023 à 10:18, Yoann Congal a écrit :
>>> python-native is not provided by meta-python anymore and this is clearly
>>> a python3 recipe.
>>>
>>> Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
>>> ---
>>>   meta-python/recipes-extended/python-cson/python3-cson_git.bb | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta-python/recipes-extended/python-cson/python3-cson_git.bb b/meta-python/recipes-extended/python-cson/python3-cson_git.bb
>>> index c4fcc61ec..da174ad55 100644
>>> --- a/meta-python/recipes-extended/python-cson/python3-cson_git.bb
>>> +++ b/meta-python/recipes-extended/python-cson/python3-cson_git.bb
>>> @@ -13,7 +13,7 @@ SRC_URI = "git://github.com/gt3389b/python-cson.git;branch=master;protocol=https
>>>   S = "${WORKDIR}/git"
>>>   
>>>   RDEPENDS:${PN}:class-native = ""
>>> -DEPENDS:append:class-native = " python-native "
>>> +DEPENDS:append:class-native = " python3-native "
>>>   
>>>   inherit setuptools3
>>>   
>> It would be better to backport https://git.openembedded.org/meta-openembedded/commit/?id=40b4cf5a83098a5f1be873be5c29f26380bc7993 instead of this patch
>> In the current state :
>> root@qemux86-64:~# python-cson
>> Traceback (most recent call last):
>>    File "/usr/bin/python-cson", line 5, in <module>
>>      from cson import main
>>    File "/usr/lib/python3.10/site-packages/cson.py", line 11, in <module>
>>      import argparse, copy, json, sys
>> ModuleNotFoundError: No module named 'json'
>>
>> I'll send the backport.
> Here it is :
> [meta-python][kirkstone][PATCH] python3-cson: fix run-time dependencies
> https://lists.openembedded.org/g/openembedded-devel/message/106881
>
> With the backport the python-cson tool does start so this patch should definitely be dropped in favor of the backport.
> root@qemux86-64:~# python-cson
> usage: python-cson [-h] -f OUTPUT_FILE [-v] input_file
> python-cson: error: the following arguments are required: -f/--file, input_file
>
> Regards,
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#106882): https://lists.openembedded.org/g/openembedded-devel/message/106882
> Mute This Topic: https://lists.openembedded.org/mt/102644490/3616698
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [akuster808@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta-python/recipes-extended/python-cson/python3-cson_git.bb b/meta-python/recipes-extended/python-cson/python3-cson_git.bb
index c4fcc61ec..da174ad55 100644
--- a/meta-python/recipes-extended/python-cson/python3-cson_git.bb
+++ b/meta-python/recipes-extended/python-cson/python3-cson_git.bb
@@ -13,7 +13,7 @@  SRC_URI = "git://github.com/gt3389b/python-cson.git;branch=master;protocol=https
 S = "${WORKDIR}/git"
 
 RDEPENDS:${PN}:class-native = ""
-DEPENDS:append:class-native = " python-native "
+DEPENDS:append:class-native = " python3-native "
 
 inherit setuptools3