| Message ID | 20231102032939.3447809-1-mingli.yu@windriver.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-oe,v2] vboxguestdrivers: Remove the buildpath | expand |
On Thu, 2023-11-02 at 11:29 +0800, Yu, Mingli wrote: > From: Mingli Yu <mingli.yu@windriver.com> > > Fixes: > WARNING: vboxguestdrivers-7.0.10-r0 do_package_qa: QA Issue: File > /usr/lib/modules/6.1.51-yocto-standard/kernel/misc/vboxsf.ko in > package kernel-module-vboxsf-6.1.51-yocto-standard contains reference > to TMPDIR [buildpaths] > WARNING: vboxguestdrivers-7.0.10-r0 do_package_qa: QA Issue: File > /usr/lib/modules/6.1.51-yocto-standard/kernel/misc/vboxguest.ko in > package kernel-module-vboxguest-6.1.51-yocto-standard contains > reference to TMPDIR [buildpaths] > WARNING: vboxguestdrivers-7.0.10-r0 do_package_qa: QA Issue: File > /usr/lib/modules/6.1.51-yocto-standard/kernel/misc/vboxvideo.ko in > package kernel-module-vboxvideo-6.1.51-yocto-standard contains > reference to TMPDIR [buildpaths] > > Signed-off-by: Mingli Yu <mingli.yu@windriver.com> > --- > .../vboxguestdrivers/vboxguestdrivers_7.0.10.bb | 3 > ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta-oe/recipes- > support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb b/meta- > oe/recipes-support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb > index 8e9013824..847458645 100644 > --- a/meta-oe/recipes- > support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb > +++ b/meta-oe/recipes- > support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb > @@ -24,7 +24,8 @@ S:task-patch = "${WORKDIR}/${VBOX_NAME}" > export VBOX_KBUILD_TARGET_ARCH="${ARCH}" > export VBOX_KBUILD_TARGET_ARCH:x86-64="amd64" > > -EXTRA_OEMAKE += "KERN_DIR='${WORKDIR}/${KERNEL_VERSION}/build' > KBUILD_VERBOSE=1" > +EXTRA_OEMAKE += "KERN_DIR='${WORKDIR}/${KERNEL_VERSION}/build' > KBUILD_VERBOSE=1 CC='${CC} ${DEBUG_PREFIX_MAP} -fdebug-prefix- > map=${STAGING_KERNEL_DIR}=${KERNEL_SRC_PATH} -fdebug-prefix- > map=${STAGING_KERNEL_BUILDDIR}=${KERNEL_SRC_PATH}'" > +TOOLCHAIN = "gcc" > Why is this required? This isn't mentioned in the commit message. Thanks, Anuj
Hi Anuj, On 11/2/23 11:33, Mittal, Anuj wrote: > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender and know the content is safe. > > On Thu, 2023-11-02 at 11:29 +0800, Yu, Mingli wrote: >> From: Mingli Yu <mingli.yu@windriver.com> >> >> Fixes: >> WARNING: vboxguestdrivers-7.0.10-r0 do_package_qa: QA Issue: File >> /usr/lib/modules/6.1.51-yocto-standard/kernel/misc/vboxsf.ko in >> package kernel-module-vboxsf-6.1.51-yocto-standard contains reference >> to TMPDIR [buildpaths] >> WARNING: vboxguestdrivers-7.0.10-r0 do_package_qa: QA Issue: File >> /usr/lib/modules/6.1.51-yocto-standard/kernel/misc/vboxguest.ko in >> package kernel-module-vboxguest-6.1.51-yocto-standard contains >> reference to TMPDIR [buildpaths] >> WARNING: vboxguestdrivers-7.0.10-r0 do_package_qa: QA Issue: File >> /usr/lib/modules/6.1.51-yocto-standard/kernel/misc/vboxvideo.ko in >> package kernel-module-vboxvideo-6.1.51-yocto-standard contains >> reference to TMPDIR [buildpaths] >> >> Signed-off-by: Mingli Yu <mingli.yu@windriver.com> >> --- >> .../vboxguestdrivers/vboxguestdrivers_7.0.10.bb | 3 >> ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/meta-oe/recipes- >> support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb b/meta- >> oe/recipes-support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb >> index 8e9013824..847458645 100644 >> --- a/meta-oe/recipes- >> support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb >> +++ b/meta-oe/recipes- >> support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb >> @@ -24,7 +24,8 @@ S:task-patch = "${WORKDIR}/${VBOX_NAME}" >> export VBOX_KBUILD_TARGET_ARCH="${ARCH}" >> export VBOX_KBUILD_TARGET_ARCH:x86-64="amd64" >> >> -EXTRA_OEMAKE += "KERN_DIR='${WORKDIR}/${KERNEL_VERSION}/build' >> KBUILD_VERBOSE=1" >> +EXTRA_OEMAKE += "KERN_DIR='${WORKDIR}/${KERNEL_VERSION}/build' >> KBUILD_VERBOSE=1 CC='${CC} ${DEBUG_PREFIX_MAP} -fdebug-prefix- >> map=${STAGING_KERNEL_DIR}=${KERNEL_SRC_PATH} -fdebug-prefix- >> map=${STAGING_KERNEL_BUILDDIR}=${KERNEL_SRC_PATH}'" >> +TOOLCHAIN = "gcc" >> > > Why is this required? This isn't mentioned in the commit message. Without this patch, we can observe it still use gcc to compile in log.do_compile even we set TOOLCHAIN = "clang" in local.conf. So we explicitly set TOOLCHAIN = "gcc" to narrow down the toolchain support to avoid the build error when build with clang. And we can remove the line if someone adds the support for clang in the future. Thanks, > > Thanks, > > Anuj >
On Wed, Nov 1, 2023 at 8:29 PM Yu, Mingli <mingli.yu@eng.windriver.com> wrote: > > From: Mingli Yu <mingli.yu@windriver.com> > > Fixes: > WARNING: vboxguestdrivers-7.0.10-r0 do_package_qa: QA Issue: File /usr/lib/modules/6.1.51-yocto-standard/kernel/misc/vboxsf.ko in package kernel-module-vboxsf-6.1.51-yocto-standard contains reference to TMPDIR [buildpaths] > WARNING: vboxguestdrivers-7.0.10-r0 do_package_qa: QA Issue: File /usr/lib/modules/6.1.51-yocto-standard/kernel/misc/vboxguest.ko in package kernel-module-vboxguest-6.1.51-yocto-standard contains reference to TMPDIR [buildpaths] > WARNING: vboxguestdrivers-7.0.10-r0 do_package_qa: QA Issue: File /usr/lib/modules/6.1.51-yocto-standard/kernel/misc/vboxvideo.ko in package kernel-module-vboxvideo-6.1.51-yocto-standard contains reference to TMPDIR [buildpaths] > > Signed-off-by: Mingli Yu <mingli.yu@windriver.com> > --- > .../vboxguestdrivers/vboxguestdrivers_7.0.10.bb | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb b/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb > index 8e9013824..847458645 100644 > --- a/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb > +++ b/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb > @@ -24,7 +24,8 @@ S:task-patch = "${WORKDIR}/${VBOX_NAME}" > export VBOX_KBUILD_TARGET_ARCH="${ARCH}" > export VBOX_KBUILD_TARGET_ARCH:x86-64="amd64" > > -EXTRA_OEMAKE += "KERN_DIR='${WORKDIR}/${KERNEL_VERSION}/build' KBUILD_VERBOSE=1" > +EXTRA_OEMAKE += "KERN_DIR='${WORKDIR}/${KERNEL_VERSION}/build' KBUILD_VERBOSE=1 CC='${CC} ${DEBUG_PREFIX_MAP} -fdebug-prefix-map=${STAGING_KERNEL_DIR}=${KERNEL_SRC_PATH} -fdebug-prefix-map=${STAGING_KERNEL_BUILDDIR}=${KERNEL_SRC_PATH}'" > +TOOLCHAIN = "gcc" I think its better to move it to conf/nonclangable.conf in meta-clang > > # otherwise 5.2.22 builds just vboxguest > MAKE_TARGETS = "all" > -- > 2.25.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#105830): https://lists.openembedded.org/g/openembedded-devel/message/105830 > Mute This Topic: https://lists.openembedded.org/mt/102335456/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb b/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb index 8e9013824..847458645 100644 --- a/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb +++ b/meta-oe/recipes-support/vboxguestdrivers/vboxguestdrivers_7.0.10.bb @@ -24,7 +24,8 @@ S:task-patch = "${WORKDIR}/${VBOX_NAME}" export VBOX_KBUILD_TARGET_ARCH="${ARCH}" export VBOX_KBUILD_TARGET_ARCH:x86-64="amd64" -EXTRA_OEMAKE += "KERN_DIR='${WORKDIR}/${KERNEL_VERSION}/build' KBUILD_VERBOSE=1" +EXTRA_OEMAKE += "KERN_DIR='${WORKDIR}/${KERNEL_VERSION}/build' KBUILD_VERBOSE=1 CC='${CC} ${DEBUG_PREFIX_MAP} -fdebug-prefix-map=${STAGING_KERNEL_DIR}=${KERNEL_SRC_PATH} -fdebug-prefix-map=${STAGING_KERNEL_BUILDDIR}=${KERNEL_SRC_PATH}'" +TOOLCHAIN = "gcc" # otherwise 5.2.22 builds just vboxguest MAKE_TARGETS = "all"