| Message ID | 20231026132203.3840009-2-pkj@axis.com |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [meta-oe,1/2] libwebsockets: Support building for native | expand |
On Thu, 2023-10-26 at 15:22 +0200, Peter Kjellerstedt wrote: > Support for building from native was removed in commit e1b332f2e > (meta-networking: Drop broken BBCLASSEXTEND variants), most likely due > to no support for building libwebsockets-native. That support has now > been added, so it is now possible to build mosquitto-native again. > > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> > --- > .../recipes-connectivity/mosquitto/mosquitto_2.0.18.bb | 2 ++ > 1 file changed, 2 insertions(+) I'm a little curious how this was being used given that libwebsockets- native was missing? Local changes? Cheers, Richard
> -----Original Message----- > From: Richard Purdie <richard.purdie@linuxfoundation.org> > Sent: den 26 oktober 2023 22:13 > To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; openembedded- > devel@lists.openembedded.org > Subject: Re: [oe] [meta-networking][PATCH 2/2] mosquitto: Support building > for native again > > On Thu, 2023-10-26 at 15:22 +0200, Peter Kjellerstedt wrote: > > Support for building from native was removed in commit e1b332f2e > > (meta-networking: Drop broken BBCLASSEXTEND variants), most likely due > > to no support for building libwebsockets-native. That support has now > > been added, so it is now possible to build mosquitto-native again. > > > > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> > > --- > > .../recipes-connectivity/mosquitto/mosquitto_2.0.18.bb | 2 ++ > > 1 file changed, 2 insertions(+) > > I'm a little curious how this was being used given that libwebsockets- > native was missing? Local changes? We do not have the "websockets" PACKAGECONFIG enabled. > Cheers, > > Richard //Peter
On Fri, 2023-10-27 at 04:51 +0000, Peter Kjellerstedt wrote: > > -----Original Message----- > > From: Richard Purdie <richard.purdie@linuxfoundation.org> > > Sent: den 26 oktober 2023 22:13 > > To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; openembedded- > > devel@lists.openembedded.org > > Subject: Re: [oe] [meta-networking][PATCH 2/2] mosquitto: Support > > building > > for native again > > > > On Thu, 2023-10-26 at 15:22 +0200, Peter Kjellerstedt wrote: > > > Support for building from native was removed in commit e1b332f2e > > > (meta-networking: Drop broken BBCLASSEXTEND variants), most > > > likely due > > > to no support for building libwebsockets-native. That support has > > > now > > > been added, so it is now possible to build mosquitto-native > > > again. > > > > > > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> > > > --- > > > .../recipes-connectivity/mosquitto/mosquitto_2.0.18.bb > > > | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > I'm a little curious how this was being used given that > > libwebsockets- > > native was missing? Local changes? > > We do not have the "websockets" PACKAGECONFIG enabled. That explains things, thanks. In some ways a better fix might have been to change the native PACKAGECONFIG and reduce dependencies and build time? That assumes you don't need the native config to enable the target one which I have no idea about though. Cheers, Richard
> -----Original Message----- > From: Richard Purdie <richard.purdie@linuxfoundation.org> > Sent: den 27 oktober 2023 10:47 > To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; openembedded- > devel@lists.openembedded.org > Subject: Re: [oe] [meta-networking][PATCH 2/2] mosquitto: Support building > for native again > > On Fri, 2023-10-27 at 04:51 +0000, Peter Kjellerstedt wrote: > > > -----Original Message----- > > > From: Richard Purdie <richard.purdie@linuxfoundation.org> > > > Sent: den 26 oktober 2023 22:13 > > > To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; openembedded- > > > devel@lists.openembedded.org > > > Subject: Re: [oe] [meta-networking][PATCH 2/2] mosquitto: Support > > > building > > > for native again > > > > > > On Thu, 2023-10-26 at 15:22 +0200, Peter Kjellerstedt wrote: > > > > Support for building from native was removed in commit e1b332f2e > > > > (meta-networking: Drop broken BBCLASSEXTEND variants), most > > > > likely due > > > > to no support for building libwebsockets-native. That support has > > > > now > > > > been added, so it is now possible to build mosquitto-native > > > > again. > > > > > > > > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> > > > > --- > > > > .../recipes-connectivity/mosquitto/mosquitto_2.0.18.bb > > > > | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > I'm a little curious how this was being used given that > > > libwebsockets- > > > native was missing? Local changes? > > > > We do not have the "websockets" PACKAGECONFIG enabled. > > That explains things, thanks. > > In some ways a better fix might have been to change the native > PACKAGECONFIG and reduce dependencies and build time? That assumes you > don't need the native config to enable the target one which I have no > idea about though. Unfortunately, I have no idea what we or anyone else use mosquitto for. I just make it build. ;) So while reducing the dependencies is generally a good idea, I do not know what the consequences would be. > Cheers, > > Richard //Peter
diff --git a/meta-networking/recipes-connectivity/mosquitto/mosquitto_2.0.18.bb b/meta-networking/recipes-connectivity/mosquitto/mosquitto_2.0.18.bb index 7685cc928..ea9eb4857 100644 --- a/meta-networking/recipes-connectivity/mosquitto/mosquitto_2.0.18.bb +++ b/meta-networking/recipes-connectivity/mosquitto/mosquitto_2.0.18.bb @@ -88,3 +88,5 @@ INITSCRIPT_PARAMS = "defaults 30" USERADD_PACKAGES = "${PN}" USERADD_PARAM:${PN} = "--system --no-create-home --shell /bin/false \ --user-group mosquitto" + +BBCLASSEXTEND = "native"
Support for building from native was removed in commit e1b332f2e (meta-networking: Drop broken BBCLASSEXTEND variants), most likely due to no support for building libwebsockets-native. That support has now been added, so it is now possible to build mosquitto-native again. Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> --- .../recipes-connectivity/mosquitto/mosquitto_2.0.18.bb | 2 ++ 1 file changed, 2 insertions(+)